diff options
author | Paolo Bonzini <pbonzini@redhat.com> | 2011-03-12 17:44:00 +0100 |
---|---|---|
committer | Blue Swirl <blauwirbel@gmail.com> | 2011-03-13 14:44:22 +0000 |
commit | 9705fbb5636fbe36956e6886227e9e871689cf83 (patch) | |
tree | 1ed88bd7ff2299e8d855207d8347069ec99e1153 | |
parent | 67bb172f9d995880a9c752e9f33819f4a63a3fda (diff) | |
download | qemu-9705fbb5636fbe36956e6886227e9e871689cf83.tar.gz qemu-9705fbb5636fbe36956e6886227e9e871689cf83.tar.bz2 qemu-9705fbb5636fbe36956e6886227e9e871689cf83.zip |
do not use timedwait on qemu_halt_cond
The following conditions can cause cpu_has_work(env) to become true:
- env->queued_work_first: run_on_cpu is already kicking the VCPU
- env->stop = 1: pause_all_vcpus is already kicking the VCPU
- env->stopped = 0: resume_all_vcpus is already kicking the VCPU
- vm_running = 1: vm_start is calling resume_all_vcpus
- env->halted = 0: see previous patch
- qemu_cpu_has_work(env): when it becomes true, board code should set
env->halted = 0 too.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
-rw-r--r-- | cpus.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -771,7 +771,7 @@ static void qemu_tcg_wait_io_event(void) CPUState *env; while (all_cpu_threads_idle()) { - qemu_cond_timedwait(tcg_halt_cond, &qemu_global_mutex, 1000); + qemu_cond_wait(tcg_halt_cond, &qemu_global_mutex); } qemu_mutex_unlock(&qemu_global_mutex); @@ -794,7 +794,7 @@ static void qemu_tcg_wait_io_event(void) static void qemu_kvm_wait_io_event(CPUState *env) { while (cpu_thread_is_idle(env)) { - qemu_cond_timedwait(env->halt_cond, &qemu_global_mutex, 1000); + qemu_cond_wait(env->halt_cond, &qemu_global_mutex); } qemu_kvm_eat_signals(env); |