diff options
| author | Naphtali Sprei <nsprei@redhat.com> | 2010-01-21 14:40:39 +0200 |
|---|---|---|
| committer | Anthony Liguori <aliguori@us.ibm.com> | 2010-01-26 15:42:01 -0600 |
| commit | 058fc8c768f81f9140db511171185dc8e0676163 (patch) | |
| tree | 2638db9a159c0b89d15882bfa43606fc1f6e75cc | |
| parent | 37226ad946597126f5bce36f75f818b12fe4b5b8 (diff) | |
| download | qemu-058fc8c768f81f9140db511171185dc8e0676163.tar.gz qemu-058fc8c768f81f9140db511171185dc8e0676163.tar.bz2 qemu-058fc8c768f81f9140db511171185dc8e0676163.zip | |
Ask for read-write permissions when opening files
Found some places that seems needs this explicitly, now that
read-write is not the default.
Signed-off-by: Naphtali Sprei <nsprei@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
| -rw-r--r-- | block/qcow2.c | 2 | ||||
| -rw-r--r-- | block/vvfat.c | 2 | ||||
| -rw-r--r-- | qemu-img.c | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/block/qcow2.c b/block/qcow2.c index 8fc8f8cc37..8c220ecdc5 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -998,7 +998,7 @@ exit: if (prealloc) { BlockDriverState *bs; bs = bdrv_new(""); - bdrv_open(bs, filename, BDRV_O_CACHE_WB); + bdrv_open(bs, filename, BDRV_O_CACHE_WB | BDRV_O_RDWR); preallocate(bs); bdrv_close(bs); } diff --git a/block/vvfat.c b/block/vvfat.c index df957e5ff8..d2787b9e76 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -2792,7 +2792,7 @@ static int enable_write_target(BDRVVVFATState *s) if (bdrv_create(bdrv_qcow, s->qcow_filename, options) < 0) return -1; s->qcow = bdrv_new(""); - if (s->qcow == NULL || bdrv_open(s->qcow, s->qcow_filename, 0) < 0) + if (s->qcow == NULL || bdrv_open(s->qcow, s->qcow_filename, BDRV_O_RDWR) < 0) return -1; #ifndef _WIN32 diff --git a/qemu-img.c b/qemu-img.c index 3cea8cecf5..cbba4fc790 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1116,7 +1116,7 @@ static int img_rebase(int argc, char **argv) if (!bs) error("Not enough memory"); - flags = BRDV_O_FLAGS | (unsafe ? BDRV_O_NO_BACKING : 0); + flags = BRDV_O_FLAGS | BDRV_O_RDWR | (unsafe ? BDRV_O_NO_BACKING : 0); if (bdrv_open2(bs, filename, flags, NULL) < 0) { error("Could not open '%s'", filename); } @@ -1157,7 +1157,7 @@ static int img_rebase(int argc, char **argv) } bs_new_backing = bdrv_new("new_backing"); - if (bdrv_open2(bs_new_backing, out_baseimg, BRDV_O_FLAGS, + if (bdrv_open2(bs_new_backing, out_baseimg, BRDV_O_FLAGS | BDRV_O_RDWR, new_backing_drv)) { error("Could not open new backing file '%s'", backing_name); |