diff options
| author | Alberto Garcia <berto@igalia.com> | 2016-07-28 11:08:12 +0300 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2016-08-05 09:59:06 +0100 |
| commit | aaa1e77ffae5255fb2a35284e7fc721742bb41c8 (patch) | |
| tree | 8943869d88edda55779aae1b5457842584673b66 | |
| parent | 555a608c5d5dcc44e45a483ca09b449d8db519d1 (diff) | |
| download | qemu-aaa1e77ffae5255fb2a35284e7fc721742bb41c8.tar.gz qemu-aaa1e77ffae5255fb2a35284e7fc721742bb41c8.tar.bz2 qemu-aaa1e77ffae5255fb2a35284e7fc721742bb41c8.zip | |
throttle: Don't allow burst limits to be lower than the normal limits
Setting FOO_max to a value that is lower than FOO does not make
sense, and it produces odd results depending on the value of
FOO_max_length. Although the user should not set that configuration
in the first place it's better to reject it explicitly.
https://bugzilla.redhat.com/show_bug.cgi?id=1355665
Signed-off-by: Alberto Garcia <berto@igalia.com>
Reported-by: Gu Nini <ngu@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Message-id: 663d5aca406060e31f80d8113f77b6feee63b919.1469693110.git.berto@igalia.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
| -rw-r--r-- | util/throttle.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/util/throttle.c b/util/throttle.c index 654f95caf2..3817d9b904 100644 --- a/util/throttle.c +++ b/util/throttle.c @@ -348,6 +348,11 @@ bool throttle_is_valid(ThrottleConfig *cfg, Error **errp) " bps/iops values"); return false; } + + if (cfg->buckets[i].max && cfg->buckets[i].max < cfg->buckets[i].avg) { + error_setg(errp, "bps_max/iops_max cannot be lower than bps/iops"); + return false; + } } return true; |