summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbellard <bellard@c046a42c-6fe2-441c-8c8c-71466251a162>2003-11-19 22:12:02 +0000
committerbellard <bellard@c046a42c-6fe2-441c-8c8c-71466251a162>2003-11-19 22:12:02 +0000
commit36bdbe5479cebb5765779a430d14daddddcab871 (patch)
tree092cd5144d8eac0007b39b3ff7fea281818e3533
parent8004340674c4b014e18357acfbcaa24d10ec9c22 (diff)
downloadqemu-36bdbe5479cebb5765779a430d14daddddcab871.tar.gz
qemu-36bdbe5479cebb5765779a430d14daddddcab871.tar.bz2
qemu-36bdbe5479cebb5765779a430d14daddddcab871.zip
fixed TB linking in case of code invalidation (fixes random segfaults)
git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@469 c046a42c-6fe2-441c-8c8c-71466251a162
-rw-r--r--cpu-exec.c13
-rw-r--r--exec-all.h1
-rw-r--r--exec.c2
3 files changed, 15 insertions, 1 deletions
diff --git a/cpu-exec.c b/cpu-exec.c
index 1f08934cb7..5bbace345f 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -21,6 +21,8 @@
#include "exec.h"
#include "disas.h"
+int tb_invalidated_flag;
+
//#define DEBUG_EXEC
//#define DEBUG_SIGNAL
@@ -273,8 +275,17 @@ int cpu_exec(CPUState *env1)
tb->tc_ptr = tc_ptr;
tb->cs_base = (unsigned long)cs_base;
tb->flags = flags;
- /* XXX: an MMU exception can occur here */
+ tb_invalidated_flag = 0;
cpu_gen_code(env, tb, CODE_GEN_MAX_SIZE, &code_gen_size);
+ if (tb_invalidated_flag) {
+ /* as some TB could have been invalidated because
+ of memory exceptions while generating the code, we
+ must recompute the hash index here */
+ ptb = &tb_hash[tb_hash_func((unsigned long)pc)];
+ while (*ptb != NULL)
+ ptb = &(*ptb)->hash_next;
+ T0 = 0;
+ }
*ptb = tb;
tb->hash_next = NULL;
tb_link(tb);
diff --git a/exec-all.h b/exec-all.h
index 7d0972e862..2023cf225e 100644
--- a/exec-all.h
+++ b/exec-all.h
@@ -416,6 +416,7 @@ static inline int spin_trylock(spinlock_t *lock)
extern spinlock_t tb_lock;
+extern int tb_invalidated_flag;
#if defined(TARGET_I386) && !defined(CONFIG_USER_ONLY)
diff --git a/exec.c b/exec.c
index ca767e2af0..9cc251f959 100644
--- a/exec.c
+++ b/exec.c
@@ -362,6 +362,8 @@ static inline void tb_invalidate(TranslationBlock *tb, int parity)
unsigned int h, n1;
TranslationBlock *tb1, *tb2;
+ tb_invalidated_flag = 1;
+
/* remove the TB from the hash list */
h = tb_hash_func(tb->pc);
tb_remove(&tb_hash[h], tb,