diff options
author | Eric Blake <eblake@redhat.com> | 2015-12-01 22:20:46 -0700 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2015-12-17 08:21:28 +0100 |
commit | 1310a3d3bd9301ff5a825287638cfab24c2c6689 (patch) | |
tree | 74f2be582a0fb7c44776d88c6e481d46951f37f7 | |
parent | 55e1819c509b3d9c10a54678b9c585bbda13889e (diff) | |
download | qemu-1310a3d3bd9301ff5a825287638cfab24c2c6689.tar.gz qemu-1310a3d3bd9301ff5a825287638cfab24c2c6689.tar.bz2 qemu-1310a3d3bd9301ff5a825287638cfab24c2c6689.zip |
qobject: Rename qtype_code to QType
The name QType matches our CODING_STYLE conventions for type names
in CamelCase. It also matches the fact that we are already naming
all the enum members with a prefix of QTYPE, not QTYPE_CODE. And
doing the rename will also make it easier for the next patch to use
QAPI for providing the enum, which also wants CamelCase type names.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1449033659-25497-3-git-send-email-eblake@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
-rw-r--r-- | block/qapi.c | 4 | ||||
-rw-r--r-- | include/hw/qdev-core.h | 2 | ||||
-rw-r--r-- | include/qapi/qmp/qobject.h | 8 | ||||
-rw-r--r-- | qobject/qdict.c | 3 | ||||
-rw-r--r-- | scripts/qapi.py | 2 |
5 files changed, 9 insertions, 10 deletions
diff --git a/block/qapi.c b/block/qapi.c index 267f147fe3..c0e877e07e 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -588,7 +588,7 @@ static void dump_qlist(fprintf_function func_fprintf, void *f, int indentation, int i = 0; for (entry = qlist_first(list); entry; entry = qlist_next(entry), i++) { - qtype_code type = qobject_type(entry->value); + QType type = qobject_type(entry->value); bool composite = (type == QTYPE_QDICT || type == QTYPE_QLIST); const char *format = composite ? "%*s[%i]:\n" : "%*s[%i]: "; @@ -606,7 +606,7 @@ static void dump_qdict(fprintf_function func_fprintf, void *f, int indentation, const QDictEntry *entry; for (entry = qdict_first(dict); entry; entry = qdict_next(dict, entry)) { - qtype_code type = qobject_type(entry->value); + QType type = qobject_type(entry->value); bool composite = (type == QTYPE_QDICT || type == QTYPE_QLIST); const char *format = composite ? "%*s%s:\n" : "%*s%s: "; char key[strlen(entry->key) + 1]; diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h index c537969f4e..abcdee852b 100644 --- a/include/hw/qdev-core.h +++ b/include/hw/qdev-core.h @@ -239,7 +239,7 @@ struct Property { PropertyInfo *info; ptrdiff_t offset; uint8_t bitnr; - qtype_code qtype; + QType qtype; int64_t defval; int arrayoffset; PropertyInfo *arrayinfo; diff --git a/include/qapi/qmp/qobject.h b/include/qapi/qmp/qobject.h index 550ba40dde..c0f1e99bca 100644 --- a/include/qapi/qmp/qobject.h +++ b/include/qapi/qmp/qobject.h @@ -45,10 +45,10 @@ typedef enum { QTYPE_QFLOAT, QTYPE_QBOOL, QTYPE_MAX, -} qtype_code; +} QType; typedef struct QObject { - qtype_code type; + QType type; size_t refcnt; } QObject; @@ -64,7 +64,7 @@ typedef struct QObject { qobject_decref(obj ? QOBJECT(obj) : NULL) /* Initialize an object to default values */ -static inline void qobject_init(QObject *obj, qtype_code type) +static inline void qobject_init(QObject *obj, QType type) { assert(QTYPE_NONE < type && type < QTYPE_MAX); obj->refcnt = 1; @@ -100,7 +100,7 @@ static inline void qobject_decref(QObject *obj) /** * qobject_type(): Return the QObject's type */ -static inline qtype_code qobject_type(const QObject *obj) +static inline QType qobject_type(const QObject *obj) { assert(QTYPE_NONE < obj->type && obj->type < QTYPE_MAX); return obj->type; diff --git a/qobject/qdict.c b/qobject/qdict.c index eeade159cc..19df837c55 100644 --- a/qobject/qdict.c +++ b/qobject/qdict.c @@ -177,8 +177,7 @@ size_t qdict_size(const QDict *qdict) /** * qdict_get_obj(): Get a QObject of a specific type */ -static QObject *qdict_get_obj(const QDict *qdict, const char *key, - qtype_code type) +static QObject *qdict_get_obj(const QDict *qdict, const char *key, QType type) { QObject *obj; diff --git a/scripts/qapi.py b/scripts/qapi.py index 10fcfbc8d2..b336fbd57c 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -33,7 +33,7 @@ builtin_types = { 'uint32': 'QTYPE_QINT', 'uint64': 'QTYPE_QINT', 'size': 'QTYPE_QINT', - 'any': None, # any qtype_code possible, actually + 'any': None, # any QType possible, actually } # Whitelist of commands allowed to return a non-dictionary |