summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHyojung Jo <hj903.jo@samsung.com>2015-10-12 17:06:40 +0900
committerHyojung Jo <hj903.jo@samsung.com>2015-10-12 20:21:27 +0900
commit68f7b3a7b102c15a895d5503c30fc4602592009b (patch)
tree84b810393f5d6f07df1ee9302d31a4c4d7e49a88
parent47a79b82bd32c618d64f90058a1e294ad88da9ab (diff)
downloadair_favorite-68f7b3a7b102c15a895d5503c30fc4602592009b.tar.gz
air_favorite-68f7b3a7b102c15a895d5503c30fc4602592009b.tar.bz2
air_favorite-68f7b3a7b102c15a895d5503c30fc4602592009b.zip
PREVENT 473451, 474214 : Fixed the code generating memory leak
Change-Id: I9b00d76ae8a40606604dd0009a7c41b6e5d3e37a Signed-off-by: Hyojung Jo <hj903.jo@samsung.com>
-rw-r--r--src/data/app.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/src/data/app.c b/src/data/app.c
index 6601d40..62135dc 100644
--- a/src/data/app.c
+++ b/src/data/app.c
@@ -70,15 +70,16 @@ static void _app_favorite_list_foreach(gpointer data, gpointer user_data)
if (id)
adata->id = strdup(id);
- if (name)
- adata->name = strdup(name);
- if (icon)
- adata->icon = strdup(icon);
/* FIXME: The browser's name and icon is defined as GUI. */
if (!strcmp(id, APP_ID_BROWSER)) {
- adata->name = STR_BROWSER;
- adata->icon = BROWSER_ICON_PNG;
+ adata->name = strdup(STR_BROWSER);
+ adata->icon = strdup(BROWSER_ICON_PNG);
+ } else {
+ if (name)
+ adata->name = strdup(name);
+ if (icon)
+ adata->icon = strdup(icon);
}
*l = eina_list_append(*l, adata);