diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-07-09 23:51:54 +0000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-10 11:09:16 -0700 |
| commit | edea2aceac3068aab66f0fe748ffc1c3125587da (patch) | |
| tree | aea111a7b9d2076708dae1fe39012c66057c1a5a /net | |
| parent | 0c41742f8b41c3fd81f96bffc8c65bbb1f0a0d8b (diff) | |
| download | kernel-common-edea2aceac3068aab66f0fe748ffc1c3125587da.tar.gz kernel-common-edea2aceac3068aab66f0fe748ffc1c3125587da.tar.bz2 kernel-common-edea2aceac3068aab66f0fe748ffc1c3125587da.zip | |
9p: strlen() doesn't count the terminator
commit 5c4bfa17f3ec46becec4b23d12323f7605ebd696 upstream.
This is an off by one bug because strlen() doesn't count the NULL
terminator. We strcpy() addr into a fixed length array of size
UNIX_PATH_MAX later on.
The addr variable is the name of the device being mounted.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'net')
| -rw-r--r-- | net/9p/trans_fd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c index 98ce9bcb0e15..c85109d809ca 100644 --- a/net/9p/trans_fd.c +++ b/net/9p/trans_fd.c @@ -948,7 +948,7 @@ p9_fd_create_unix(struct p9_client *client, const char *addr, char *args) csocket = NULL; - if (strlen(addr) > UNIX_PATH_MAX) { + if (strlen(addr) >= UNIX_PATH_MAX) { P9_EPRINTK(KERN_ERR, "p9_trans_unix: address too long: %s\n", addr); return -ENAMETOOLONG; |