summaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorVasiliy Kulikov <segoon@openwall.com>2011-02-14 13:54:26 +0300
committerGreg Kroah-Hartman <gregkh@suse.de>2011-04-14 16:53:01 -0700
commita578aadd26d69db27e80f01fbb88a7b91d4c7500 (patch)
tree3815f1a52e4c44a890211d64f358f8ee0dd9b771 /net
parenteb73bca39f4f5f2d5285dcb1dc1aa35433d89cef (diff)
downloadkernel-common-a578aadd26d69db27e80f01fbb88a7b91d4c7500.tar.gz
kernel-common-a578aadd26d69db27e80f01fbb88a7b91d4c7500.tar.bz2
kernel-common-a578aadd26d69db27e80f01fbb88a7b91d4c7500.zip
Bluetooth: sco: fix information leak to userspace
commit c4c896e1471aec3b004a693c689f60be3b17ac86 upstream. struct sco_conninfo has one padding byte in the end. Local variable cinfo of type sco_conninfo is copied to userspace with this uninizialized one byte, leading to old stack contents leak. Signed-off-by: Vasiliy Kulikov <segoon@openwall.com> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'net')
-rw-r--r--net/bluetooth/sco.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/net/bluetooth/sco.c b/net/bluetooth/sco.c
index 66cab63e76e3..dc009794118d 100644
--- a/net/bluetooth/sco.c
+++ b/net/bluetooth/sco.c
@@ -701,6 +701,7 @@ static int sco_sock_getsockopt_old(struct socket *sock, int optname, char __user
break;
}
+ memset(&cinfo, 0, sizeof(cinfo));
cinfo.hci_handle = sco_pi(sk)->conn->hcon->handle;
memcpy(cinfo.dev_class, sco_pi(sk)->conn->hcon->dev_class, 3);