diff options
| author | stephen hemminger <shemminger@vyatta.com> | 2010-07-27 08:26:30 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-07-28 10:50:55 -0700 |
| commit | eeaf61d8891f9c9ed12c1a667e72bf83f0857954 (patch) | |
| tree | daeda447800df1349559268d8f6e79c90dcd22dd /net/bridge/br_device.c | |
| parent | ff847ac2d3e90edd94674c28bade25ae1e6a2e49 (diff) | |
| download | kernel-common-eeaf61d8891f9c9ed12c1a667e72bf83f0857954.tar.gz kernel-common-eeaf61d8891f9c9ed12c1a667e72bf83f0857954.tar.bz2 kernel-common-eeaf61d8891f9c9ed12c1a667e72bf83f0857954.zip | |
bridge: add rcu_read_lock on transmit
Long ago, when bridge was converted to RCU, rcu lock was equivalent
to having preempt disabled. RCU has changed a lot since then and
bridge code was still assuming the since transmit was called with
bottom half disabled, it was RCU safe.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Tested-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_device.c')
| -rw-r--r-- | net/bridge/br_device.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/bridge/br_device.c b/net/bridge/br_device.c index 753fc4221f3c..4cec8051164d 100644 --- a/net/bridge/br_device.c +++ b/net/bridge/br_device.c @@ -22,7 +22,7 @@ #include <asm/uaccess.h> #include "br_private.h" -/* net device transmit always called with no BH (preempt_disabled) */ +/* net device transmit always called with BH disabled */ netdev_tx_t br_dev_xmit(struct sk_buff *skb, struct net_device *dev) { struct net_bridge *br = netdev_priv(dev); @@ -46,6 +46,7 @@ netdev_tx_t br_dev_xmit(struct sk_buff *skb, struct net_device *dev) skb_reset_mac_header(skb); skb_pull(skb, ETH_HLEN); + rcu_read_lock(); if (is_multicast_ether_addr(dest)) { if (br_multicast_rcv(br, NULL, skb)) goto out; @@ -61,6 +62,7 @@ netdev_tx_t br_dev_xmit(struct sk_buff *skb, struct net_device *dev) br_flood_deliver(br, skb); out: + rcu_read_unlock(); return NETDEV_TX_OK; } |