diff options
| author | Arjan van de Ven <arjan@linux.intel.com> | 2008-07-25 19:45:41 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-26 12:00:08 -0700 |
| commit | 267e2a9c71b8e088ac307f9549f71468e86e26c1 (patch) | |
| tree | a2fc7be0ee2d712841b4564abf4e63d814642ec3 /fs | |
| parent | 99fcd77d15357e8ba51005c25cc750b9c28b2688 (diff) | |
| download | kernel-common-267e2a9c71b8e088ac307f9549f71468e86e26c1.tar.gz kernel-common-267e2a9c71b8e088ac307f9549f71468e86e26c1.tar.bz2 kernel-common-267e2a9c71b8e088ac307f9549f71468e86e26c1.zip | |
Use WARN() in fs/proc/
Use WARN() instead of a printk+WARN_ON() pair; this way the message
becomes part of the warning section for better reporting/collection.
This way, the entire if() {} section can collapse into the WARN() as well.
Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/proc/generic.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index bc0a0dd2d844..cb4096cc3fb7 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -806,12 +806,9 @@ continue_removing: if (S_ISDIR(de->mode)) parent->nlink--; de->nlink = 0; - if (de->subdir) { - printk(KERN_WARNING "%s: removing non-empty directory " + WARN(de->subdir, KERN_WARNING "%s: removing non-empty directory " "'%s/%s', leaking at least '%s'\n", __func__, de->parent->name, de->name, de->subdir->name); - WARN_ON(1); - } if (atomic_dec_and_test(&de->count)) free_proc_entry(de); } |