diff options
| author | Jan Kara <jack@suse.cz> | 2012-07-22 20:29:31 -0400 |
|---|---|---|
| committer | Theodore Ts'o <tytso@mit.edu> | 2012-07-22 20:29:31 -0400 |
| commit | 97a7406880f61d7f89d613cf72e87682420e66b0 (patch) | |
| tree | cb6a314383e5279718eaa66c6d549d90e85aee99 /fs/ext4/mballoc.c | |
| parent | 254706056be7e4e161ae9675ead6cd4e269be966 (diff) | |
| download | kernel-common-97a7406880f61d7f89d613cf72e87682420e66b0.tar.gz kernel-common-97a7406880f61d7f89d613cf72e87682420e66b0.tar.bz2 kernel-common-97a7406880f61d7f89d613cf72e87682420e66b0.zip | |
ext4: remove useless marking of superblock dirty
Commit a0375156 properly notes that superblock doesn't need to be marked
as dirty when only number of free inodes / blocks / number of directories
changes since that is recomputed on each mount anyway. However that comment
leaves some unnecessary markings as dirty in place. Remove these.
Artem: tested using xfstests for both journalled and non-journalled ext4.
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Tested-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Diffstat (limited to 'fs/ext4/mballoc.c')
| -rw-r--r-- | fs/ext4/mballoc.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c index ca376e7d716a..8eae94771c45 100644 --- a/fs/ext4/mballoc.c +++ b/fs/ext4/mballoc.c @@ -2831,7 +2831,6 @@ ext4_mb_mark_diskspace_used(struct ext4_allocation_context *ac, err = ext4_handle_dirty_metadata(handle, NULL, gdp_bh); out_err: - ext4_mark_super_dirty(sb); brelse(bitmap_bh); return err; } @@ -4700,7 +4699,6 @@ do_more: put_bh(bitmap_bh); goto do_more; } - ext4_mark_super_dirty(sb); error_return: brelse(bitmap_bh); ext4_std_error(sb, err); |