diff options
| author | Jan Schmidt <list.btrfs@jan-o-sch.net> | 2012-10-23 14:21:05 +0200 |
|---|---|---|
| committer | Jan Schmidt <list.btrfs@jan-o-sch.net> | 2012-10-24 12:36:39 +0200 |
| commit | d638108484d186bf97a838d037f165d9b404e6ee (patch) | |
| tree | 4fb20d045666fc7228fe8a149172eec07595b240 /fs/btrfs | |
| parent | 5b6602e762cae17c8891d19698afea451e9c1d95 (diff) | |
| download | kernel-common-d638108484d186bf97a838d037f165d9b404e6ee.tar.gz kernel-common-d638108484d186bf97a838d037f165d9b404e6ee.tar.bz2 kernel-common-d638108484d186bf97a838d037f165d9b404e6ee.zip | |
Btrfs: fix extent buffer reference for tree mod log roots
In get_old_root we grab a lock on the extent buffer before we obtain a
reference on that buffer. That order is changed now.
Signed-off-by: Jan Schmidt <list.btrfs@jan-o-sch.net>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/ctree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c index ef68c33eefd9..f6739903d072 100644 --- a/fs/btrfs/ctree.c +++ b/fs/btrfs/ctree.c @@ -1279,6 +1279,7 @@ get_old_root(struct btrfs_root *root, u64 time_seq) if (!eb) return NULL; + extent_buffer_get(eb); btrfs_tree_read_lock(eb); if (old_root) { btrfs_set_header_bytenr(eb, eb->start); @@ -1291,7 +1292,6 @@ get_old_root(struct btrfs_root *root, u64 time_seq) __tree_mod_log_rewind(eb, time_seq, tm); else WARN_ON(btrfs_header_level(eb) != 0); - extent_buffer_get(eb); WARN_ON(btrfs_header_nritems(eb) > BTRFS_NODEPTRS_PER_BLOCK(root)); return eb; |