diff options
| author | Jens Axboe <jaxboe@fusionio.com> | 2010-04-16 21:11:21 +0200 |
|---|---|---|
| committer | Jens Axboe <jaxboe@fusionio.com> | 2011-03-10 08:45:54 +0100 |
| commit | 0a41e90bb7c931fd53d73ea770f5b251af6c91ce (patch) | |
| tree | efb0bdfece80587bdc4985500eeb43df08585feb | |
| parent | 3cca6dc1c81e2407928dc4c6105252146fd3924f (diff) | |
| download | kernel-common-0a41e90bb7c931fd53d73ea770f5b251af6c91ce.tar.gz kernel-common-0a41e90bb7c931fd53d73ea770f5b251af6c91ce.tar.bz2 kernel-common-0a41e90bb7c931fd53d73ea770f5b251af6c91ce.zip | |
ide-cd: convert to blk_delay_queue() for a short pause
It was always abuse to reuse the plugging infrastructure for this,
convert it to the (new) real API for delaying queueing a bit.
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
Acked-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/ide/ide-cd.c | 13 |
1 files changed, 2 insertions, 11 deletions
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 0c73fe39a236..7ce9caf4521b 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -258,17 +258,10 @@ static int ide_cd_breathe(ide_drive_t *drive, struct request *rq) if (time_after(jiffies, info->write_timeout)) return 0; else { - struct request_queue *q = drive->queue; - unsigned long flags; - /* - * take a breather relying on the unplug timer to kick us again + * take a breather */ - - spin_lock_irqsave(q->queue_lock, flags); - blk_plug_device(q); - spin_unlock_irqrestore(q->queue_lock, flags); - + blk_delay_queue(drive->queue, 1); return 1; } } @@ -1514,8 +1507,6 @@ static int ide_cdrom_setup(ide_drive_t *drive) blk_queue_dma_alignment(q, 31); blk_queue_update_dma_pad(q, 15); - q->unplug_delay = max((1 * HZ) / 1000, 1); - drive->dev_flags |= IDE_DFLAG_MEDIA_CHANGED; drive->atapi_flags = IDE_AFLAG_NO_EJECT | ide_cd_flags(id); |