diff options
| author | Vlad Yasevich <vladislav.yasevich@hp.com> | 2010-09-15 10:00:26 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-03-21 12:45:46 -0700 |
| commit | 272d7ea16c12f3bd2720a862a28eeb39ca884129 (patch) | |
| tree | 92e62b2d5ec008aa1bdf63f0db1e1f83401d0dd2 | |
| parent | ebe7aad41efd6c6fbf8c943e433689289d153c93 (diff) | |
| download | kernel-common-272d7ea16c12f3bd2720a862a28eeb39ca884129.tar.gz kernel-common-272d7ea16c12f3bd2720a862a28eeb39ca884129.tar.bz2 kernel-common-272d7ea16c12f3bd2720a862a28eeb39ca884129.zip | |
sctp: Do not reset the packet during sctp_packet_config().
commit 4bdab43323b459900578b200a4b8cf9713ac8fab upstream.
sctp_packet_config() is called when getting the packet ready
for appending of chunks. The function should not touch the
current state, since it's possible to ping-pong between two
transports when sending, and that can result packet corruption
followed by skb overlfow crash.
Reported-by: Thomas Dreibholz <dreibh@iem.uni-due.de>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | net/sctp/output.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/sctp/output.c b/net/sctp/output.c index 7c5589363433..0ba3addf228a 100644 --- a/net/sctp/output.c +++ b/net/sctp/output.c @@ -91,7 +91,6 @@ struct sctp_packet *sctp_packet_config(struct sctp_packet *packet, SCTP_DEBUG_PRINTK("%s: packet:%p vtag:0x%x\n", __func__, packet, vtag); - sctp_packet_reset(packet); packet->vtag = vtag; if (ecn_capable && sctp_packet_empty(packet)) { |