diff options
| author | Patrick McHardy <kaber@trash.net> | 2007-04-10 13:38:39 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-04-13 13:47:05 -0700 |
| commit | fa520f761777759cf1aebfda81ce250fc840719f (patch) | |
| tree | 9b5db85389be0ea96cd5a953e83e0da124afa38c | |
| parent | c823d26e9a668566fa92f7486b2380191497ba7a (diff) | |
| download | kernel-common-fa520f761777759cf1aebfda81ce250fc840719f.tar.gz kernel-common-fa520f761777759cf1aebfda81ce250fc840719f.tar.bz2 kernel-common-fa520f761777759cf1aebfda81ce250fc840719f.zip | |
Fix tcindex classifier ABI borkage...
[NET_SCHED]: cls_tcindex: fix compatibility breakage
Userspace uses an integer for TCA_TCINDEX_SHIFT, the kernel was changed
to expect and use a u16 value in 2.6.11, which broke compatibility on
big endian machines. Change back to use int.
Reported by Ole Reinartz <ole.reinartz@gmx.de>
Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
| -rw-r--r-- | net/sched/cls_tcindex.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c index 5af8a59e1503..49bb50438491 100644 --- a/net/sched/cls_tcindex.c +++ b/net/sched/cls_tcindex.c @@ -245,9 +245,9 @@ tcindex_set_parms(struct tcf_proto *tp, unsigned long base, u32 handle, } if (tb[TCA_TCINDEX_SHIFT-1]) { - if (RTA_PAYLOAD(tb[TCA_TCINDEX_SHIFT-1]) < sizeof(u16)) + if (RTA_PAYLOAD(tb[TCA_TCINDEX_SHIFT-1]) < sizeof(int)) goto errout; - cp.shift = *(u16 *) RTA_DATA(tb[TCA_TCINDEX_SHIFT-1]); + cp.shift = *(int *) RTA_DATA(tb[TCA_TCINDEX_SHIFT-1]); } err = -EBUSY; |