diff options
author | Lim DoHyung <delight.lim@samsung.com> | 2016-07-11 06:57:04 -0700 |
---|---|---|
committer | Hye Kyoung Hwang <cookie@samsung.com> | 2016-07-11 06:57:30 -0700 |
commit | 779c98bb32b60f46d8765c92979877726ba196a3 (patch) | |
tree | b260ca02b3c4a69bc9da3327641e2b247fc7bf37 /services/WebPageUI | |
parent | 1fa673a98030443de6eca6fd9cd62e2b4a02af97 (diff) | |
download | browser-779c98bb32b60f46d8765c92979877726ba196a3.tar.gz browser-779c98bb32b60f46d8765c92979877726ba196a3.tar.bz2 browser-779c98bb32b60f46d8765c92979877726ba196a3.zip |
Sometimes scroll is not working.
Revert "Fix for not working history list"
This reverts commit 933348348cf450b45ec957a7ec2c4f6015ea999f.
Change-Id: If467d6539954c042e6d667396a14fd8ada0a7eda
Diffstat (limited to 'services/WebPageUI')
-rw-r--r-- | services/WebPageUI/URIEntry.cpp | 6 | ||||
-rw-r--r-- | services/WebPageUI/URIEntry.h | 1 | ||||
-rw-r--r-- | services/WebPageUI/UrlHistoryList/UrlHistoryList.cpp | 2 | ||||
-rwxr-xr-x | services/WebPageUI/WebPageUI.cpp | 20 | ||||
-rw-r--r-- | services/WebPageUI/WebPageUI.h | 2 |
5 files changed, 15 insertions, 16 deletions
diff --git a/services/WebPageUI/URIEntry.cpp b/services/WebPageUI/URIEntry.cpp index d83a07bd..1c857529 100644 --- a/services/WebPageUI/URIEntry.cpp +++ b/services/WebPageUI/URIEntry.cpp @@ -347,9 +347,6 @@ void URIEntry::clearFocus() { BROWSER_LOGD("[%s:%d] ", __PRETTY_FUNCTION__, __LINE__); elm_object_focus_set(m_entry, EINA_FALSE); -#if PROFILE_MOBILE - hideHistoryList(); -#endif } void URIEntry::setFocus() @@ -387,9 +384,6 @@ void URIEntry::_uri_entry_selection_changed(void* data, Evas_Object* /*obj*/, vo BROWSER_LOGD("[%s:%d] ", __PRETTY_FUNCTION__, __LINE__); URIEntry* self = static_cast<URIEntry*>(data); self->m_entrySelectionState = SelectionState::SELECTION_KEEP; -#if PROFILE_MOBILE - self->hideHistoryList(); -#endif } void URIEntry::_uri_entry_longpressed(void* data, Evas_Object* /*obj*/, void* /*event_info*/) diff --git a/services/WebPageUI/URIEntry.h b/services/WebPageUI/URIEntry.h index 3776e66b..3684a2b7 100644 --- a/services/WebPageUI/URIEntry.h +++ b/services/WebPageUI/URIEntry.h @@ -59,7 +59,6 @@ public: boost::signals2::signal<void ()> mobileEntryUnfocused; boost::signals2::signal<void ()> secureIconClicked; boost::signals2::signal<bool (const std::string&)> isValidCert; - boost::signals2::signal<void ()> hideHistoryList; void updateSecureIcon(); void showSecureIcon(bool show, bool secure); #endif diff --git a/services/WebPageUI/UrlHistoryList/UrlHistoryList.cpp b/services/WebPageUI/UrlHistoryList/UrlHistoryList.cpp index abdf0142..ac28b49c 100644 --- a/services/WebPageUI/UrlHistoryList/UrlHistoryList.cpp +++ b/services/WebPageUI/UrlHistoryList/UrlHistoryList.cpp @@ -148,8 +148,6 @@ void UrlHistoryList::onItemSelect(std::string content) } else { uriChanged(content); } - if (getGenlistVisible()) - hideWidget(); } void UrlHistoryList::onListWidgetFocusChange(bool focused) diff --git a/services/WebPageUI/WebPageUI.cpp b/services/WebPageUI/WebPageUI.cpp index 58b02387..f68a4fd9 100755 --- a/services/WebPageUI/WebPageUI.cpp +++ b/services/WebPageUI/WebPageUI.cpp @@ -550,12 +550,8 @@ void WebPageUI::setContentFocus() void WebPageUI::_content_clicked(void *data, Evas_Object *, void *) { BROWSER_LOGD("[%s:%d] ", __PRETTY_FUNCTION__, __LINE__); - if (data) { - WebPageUI* webpageUI = static_cast<WebPageUI*>(data); - webpageUI->hideHistoryList(); - webpageUI->setContentFocus(); - } else - BROWSER_LOGE("WebPageUI data is null!"); + WebPageUI* webpageUI = static_cast<WebPageUI*>(data); + webpageUI->setContentFocus(); } void WebPageUI::_more_menu_background_clicked(void* data, Evas_Object*, const char*, const char*) @@ -760,7 +756,19 @@ void WebPageUI::mobileEntryUnfocused() } else { elm_object_signal_emit(m_mainLayout, "decrease_unfocused_uri_wp", "ui"); } + + // delay hiding on one efl loop iteration to enable genlist item selected callback to come + ecore_timer_add(0.0, _hideDelay, this); } + +Eina_Bool WebPageUI::_hideDelay(void *data) +{ + BROWSER_LOGD("[%s:%d] ", __PRETTY_FUNCTION__, __LINE__); + auto self = static_cast<WebPageUI*>(data); + self->m_urlHistoryList->hideWidget(); + return ECORE_CALLBACK_CANCEL; +} + #endif } // namespace tizen_browser diff --git a/services/WebPageUI/WebPageUI.h b/services/WebPageUI/WebPageUI.h index e129bebf..a189f97c 100644 --- a/services/WebPageUI/WebPageUI.h +++ b/services/WebPageUI/WebPageUI.h @@ -92,6 +92,7 @@ public: void mobileEntryFocused(); void mobileEntryUnfocused(); void setContentFocus(); + static Eina_Bool _hideDelay(void *data); #else void onRedKeyPressed(); void onYellowKeyPressed(); @@ -105,7 +106,6 @@ public: #if PROFILE_MOBILE boost::signals2::signal<void ()> hideMoreMenu; boost::signals2::signal<void ()> qaOrientationChanged; - boost::signals2::signal<void ()> hideHistoryList; #else boost::signals2::signal<void ()> showZoomNavigation; #endif |