diff options
author | cookie <cookie@samsung.com> | 2017-08-11 05:08:59 +0000 |
---|---|---|
committer | cookie <cookie@samsung.com> | 2017-08-11 05:08:59 +0000 |
commit | eaeb28f6edb799ef9f2b80f6d53ffd294ae4b084 (patch) | |
tree | 8e11e78c8fc65d36f9b91dbac7a6a47b2701d866 | |
parent | b4c02af630e78f55c4ce8b043206ce9163aea1d1 (diff) | |
download | browser-eaeb28f6edb799ef9f2b80f6d53ffd294ae4b084.tar.gz browser-eaeb28f6edb799ef9f2b80f6d53ffd294ae4b084.tar.bz2 browser-eaeb28f6edb799ef9f2b80f6d53ffd294ae4b084.zip |
Fix the PVS V547, V690
[ Problem ]Expression '!urlPair' is always false.
[ Soluction] Fix the issue
Change-Id: Id67e918da6a52abb127c6a77b1017ee39c65c1ef
Signed-off-by: cookie <cookie@samsung.com>
-rwxr-xr-x[-rw-r--r--] | core/Tools/BrowserImage.cpp | 10 | ||||
-rwxr-xr-x[-rw-r--r--] | core/Tools/BrowserImage.h | 1 | ||||
-rwxr-xr-x[-rw-r--r--] | services/WebPageUI/UrlHistoryList/GenlistManager.cpp | 2 |
3 files changed, 10 insertions, 3 deletions
diff --git a/core/Tools/BrowserImage.cpp b/core/Tools/BrowserImage.cpp index df9f027a..1d34c2c8 100644..100755 --- a/core/Tools/BrowserImage.cpp +++ b/core/Tools/BrowserImage.cpp @@ -77,7 +77,15 @@ BrowserImage::BrowserImage(const BrowserImage& copy) : setData(copy.getData(), copy.isSharedData(), copy.getImageType()); } - +BrowserImage& BrowserImage::operator=(const BrowserImage& copy) +{ + m_width = copy.getWidth(); + m_height = copy.getHeight(); + m_dataSize = copy.getSize(); + m_colorSpace = copy.getColorSpace(); + setData(copy.getData(), copy.isSharedData(), copy.getImageType()); + return *this; +} void BrowserImage::setData(void* data, bool isSharedData, ImageType type) { diff --git a/core/Tools/BrowserImage.h b/core/Tools/BrowserImage.h index b1cb4108..6fe8462e 100644..100755 --- a/core/Tools/BrowserImage.h +++ b/core/Tools/BrowserImage.h @@ -38,6 +38,7 @@ public: BrowserImage(Evas_Object* image); BrowserImage(const BrowserImage& copy); ~BrowserImage(); + BrowserImage& operator=(const BrowserImage&); /** * Sets image raw data pointer, type and memory share diff --git a/services/WebPageUI/UrlHistoryList/GenlistManager.cpp b/services/WebPageUI/UrlHistoryList/GenlistManager.cpp index 93808696..b66fc6f3 100644..100755 --- a/services/WebPageUI/UrlHistoryList/GenlistManager.cpp +++ b/services/WebPageUI/UrlHistoryList/GenlistManager.cpp @@ -140,8 +140,6 @@ string GenlistManager::getItemUrl( if (!data) continue; const UrlPair* const urlPair = reinterpret_cast<UrlPair*>(data); - if (!urlPair) - continue; return urlPair->urlOriginal; } return ""; |