diff options
author | Konrad Lipinski <k.lipinski2@partner.samsung.com> | 2019-06-11 16:25:51 +0200 |
---|---|---|
committer | Konrad Lipinski <k.lipinski2@samsung.com> | 2019-08-01 14:37:53 +0200 |
commit | cc6febdd37186eeea33bcbce89d79f661ee0009f (patch) | |
tree | 100542f7f8fd3b3c9548150362efe35adde47551 /HACKING | |
parent | c40fbfa8503e7763ef630496852f4d6b5e63b58c (diff) | |
download | xmlsec1-cc6febdd37186eeea33bcbce89d79f661ee0009f.tar.gz xmlsec1-cc6febdd37186eeea33bcbce89d79f661ee0009f.tar.bz2 xmlsec1-cc6febdd37186eeea33bcbce89d79f661ee0009f.zip |
Import upstream commit c4d0493d545b99194eea1b2b058930d5a9bb91b1 (1.2.28)
Change-Id: I10f71567cb140be223923e1cd0b5895e366ac23e
Diffstat (limited to 'HACKING')
-rw-r--r-- | HACKING | 10 |
1 files changed, 5 insertions, 5 deletions
@@ -95,17 +95,17 @@ Igor Zlatkovic get an exception for the send before commit rule. - Errors reporting (XMLSEC_ERRORS_R_XMLSEC_FAILED vs. XMLSEC_ERRORS_R_CRYPTO_FAILED) The correct usage rule is: if the failed function starts with "xmlSec" then use - XMLSEC_ERRORS_R_XMLSEC_FAILED - else if it is xmlMalloc/xmlFree/xmlStrdup/etc then use - XMLSEC_ERRORS_R_MALLOC_FAILED + xmlSecInternalError() aka XMLSEC_ERRORS_R_XMLSEC_FAILED + else if it is xmlMalloc/xmlFree/etc then use + xmlSecMallocError() aka XMLSEC_ERRORS_R_MALLOC_FAILED else if the function starts with "xml" or "xslt" (i.e. it comes from libxml or libxslt) then use - XMLSEC_ERRORS_R_XML_FAILED + xmlSecXmlError/xmlSecXmlParserError aka XMLSEC_ERRORS_R_XML_FAILED else if it is related to IO (fopen, fread, fwrite, etc.) then use XMLSEC_ERRORS_R_IO_FAILED else if the function could be used only from xmlsec-crypto (i.e. it is crypto engine related) then use - XMLSEC_ERRORS_R_CRYPTO_FAILED + xmlSecOpenSSLError/... aka XMLSEC_ERRORS_R_CRYPTO_FAILED else if there is another reason (invalid data, invalid size, etc.) corresponding error reason should be used else |