diff options
author | Dongsun Lee <ds73.lee@samsung.com> | 2018-04-09 08:58:53 +0900 |
---|---|---|
committer | Dongsun Lee <ds73.lee@samsung.com> | 2018-04-09 08:58:53 +0900 |
commit | 417c65d2e8f273cd775dab69a57f8bb8ce49f999 (patch) | |
tree | c907460d19ad0905a02c23c4319e48c6010736b0 | |
parent | 26886364827e02666560aaf8a156b87df681061e (diff) | |
download | xmlsec1-accepted/tizen/unified/20180416.213743.tar.gz xmlsec1-accepted/tizen/unified/20180416.213743.tar.bz2 xmlsec1-accepted/tizen/unified/20180416.213743.zip |
Fix Coverity defectssubmit/tizen_5.0/20181101.000008submit/tizen/20180415.233519submit/tizen/20180413.092019accepted/tizen/unified/20180416.213743accepted/tizen/5.0/unified/20181102.025950tizen_5.0accepted/tizen_5.0_unified
- 78087: Unchecked return value
- 73634: Unchecked return value
Change-Id: I232316246682914718979312beb87e842636fae3
Signed-off-by: Dongsun Lee <ds73.lee@samsung.com>
-rw-r--r-- | src/openssl/x509vfy.c | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/src/openssl/x509vfy.c b/src/openssl/x509vfy.c index 155e1ab5..f828afb2 100644 --- a/src/openssl/x509vfy.c +++ b/src/openssl/x509vfy.c @@ -291,7 +291,14 @@ xmlSecOpenSSLX509StoreVerify(xmlSecKeyDataStorePtr store, XMLSEC_STACK_OF_X509* if(xmlSecOpenSSLX509FindNextChainCert(certs2, cert) == NULL) { X509_STORE_CTX xsc; - X509_STORE_CTX_init (&xsc, ctx->xst, cert, certs2); + if(!X509_STORE_CTX_init(&xsc, ctx->xst, cert, certs2)) { + xmlSecError(XMLSEC_ERRORS_HERE, + xmlSecErrorsSafeString(xmlSecKeyDataStoreGetName(store)), + "X509_STORE_CTX_init", + XMLSEC_ERRORS_R_CRYPTO_FAILED, + XMLSEC_ERRORS_NO_MESSAGE); + goto done; + } if(keyInfoCtx->certsVerificationTime > 0) { X509_STORE_CTX_set_time(&xsc, 0, keyInfoCtx->certsVerificationTime); } @@ -741,7 +748,15 @@ xmlSecOpenSSLX509VerifyCRL(X509_STORE* xst, X509_CRL *crl ) { xmlSecAssert2(xst != NULL, -1); xmlSecAssert2(crl != NULL, -1); - X509_STORE_CTX_init(&xsc, xst, NULL, NULL); + ret = X509_STORE_CTX_init(&xsc, xst, NULL, NULL); + if(ret <= 0) { + xmlSecError(XMLSEC_ERRORS_HERE, + NULL, + "X509_STORE_CTX_init", + XMLSEC_ERRORS_R_CRYPTO_FAILED, + XMLSEC_ERRORS_NO_MESSAGE); + return(-1); + } ret = X509_STORE_get_by_subject(&xsc, X509_LU_X509, X509_CRL_get_issuer(crl), &xobj); if(ret <= 0) { |