From cdc405512844671bc3b2c8bd28f583036e5530a2 Mon Sep 17 00:00:00 2001
From: "E.Z. Hart" <hartez@users.noreply.github.com>
Date: Tue, 25 Apr 2017 12:16:25 -0600
Subject: Better error handling for image loading errors on iOS/Android (#849)

* First run at removing async void image update methods

Consistent error logging and IsLoading on Android,iOS,UWP

Move error logging into image handlers for better messages

Add demo of custom ImageRenderer error handling

Update docs

Make the test smaller so the results don't get pushed offscreen

Fix namespace error

* Update error handling for fast image renderer

* Update 37625 test to use image we control

* Add java disposed check to avoid ObjectDisposedException in async operations

* Add disposed checks to legacy renderer; null check element before SetIsLoading

* Check disposed on GetDesiredSize for fast renderer
Use local disposed member where possible for disposed check

* Check for disposal after async handlers in iOS

* Add disposal checks after async methods in Windows

* Reset linker settings on project; reduce redundant casts in ImageViewExtensions
---
 .../Xamarin.Forms/FileImageSource.xml                   | 17 +++++++++++++++++
 .../Xamarin.Forms.Core/Xamarin.Forms/UriImageSource.xml | 17 +++++++++++++++++
 2 files changed, 34 insertions(+)

(limited to 'docs')

diff --git a/docs/Xamarin.Forms.Core/Xamarin.Forms/FileImageSource.xml b/docs/Xamarin.Forms.Core/Xamarin.Forms/FileImageSource.xml
index 61fe4dcc..cdd27028 100644
--- a/docs/Xamarin.Forms.Core/Xamarin.Forms/FileImageSource.xml
+++ b/docs/Xamarin.Forms.Core/Xamarin.Forms/FileImageSource.xml
@@ -183,5 +183,22 @@
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
+    <Member MemberName="ToString">
+      <MemberSignature Language="C#" Value="public override string ToString ();" />
+      <MemberSignature Language="ILAsm" Value=".method public hidebysig virtual instance string ToString() cil managed" />
+      <MemberType>Method</MemberType>
+      <AssemblyInfo>
+        <AssemblyVersion>2.0.0.0</AssemblyVersion>
+      </AssemblyInfo>
+      <ReturnValue>
+        <ReturnType>System.String</ReturnType>
+      </ReturnValue>
+      <Parameters />
+      <Docs>
+        <summary>To be added.</summary>
+        <returns>To be added.</returns>
+        <remarks>To be added.</remarks>
+      </Docs>
+    </Member>
   </Members>
 </Type>
diff --git a/docs/Xamarin.Forms.Core/Xamarin.Forms/UriImageSource.xml b/docs/Xamarin.Forms.Core/Xamarin.Forms/UriImageSource.xml
index 889b02df..303717b8 100644
--- a/docs/Xamarin.Forms.Core/Xamarin.Forms/UriImageSource.xml
+++ b/docs/Xamarin.Forms.Core/Xamarin.Forms/UriImageSource.xml
@@ -114,6 +114,23 @@
         <remarks>To be added.</remarks>
       </Docs>
     </Member>
+    <Member MemberName="ToString">
+      <MemberSignature Language="C#" Value="public override string ToString ();" />
+      <MemberSignature Language="ILAsm" Value=".method public hidebysig virtual instance string ToString() cil managed" />
+      <MemberType>Method</MemberType>
+      <AssemblyInfo>
+        <AssemblyVersion>2.0.0.0</AssemblyVersion>
+      </AssemblyInfo>
+      <ReturnValue>
+        <ReturnType>System.String</ReturnType>
+      </ReturnValue>
+      <Parameters />
+      <Docs>
+        <summary>To be added.</summary>
+        <returns>To be added.</returns>
+        <remarks>To be added.</remarks>
+      </Docs>
+    </Member>
     <Member MemberName="Uri">
       <MemberSignature Language="C#" Value="public Uri Uri { get; set; }" />
       <MemberSignature Language="ILAsm" Value=".property instance class System.Uri Uri" />
-- 
cgit v1.2.3