From e6d5186c8acbf37b877c7ca3c77a378352a3743d Mon Sep 17 00:00:00 2001 From: kingces95 Date: Tue, 7 Mar 2017 14:56:24 -0500 Subject: Remove InternalsVisibleTo from Core to XF.Platforms.* (#782) * Remove InternalsVisibleTo from Core to XF.Platforms.* * Changes per Jason's code review * Move LockableObservableListWrapper to internals namespace * Changes per Stephane's code review * update docs * Touch code to get CI to run tests * Rebase; Update documentation --- Xamarin.Forms.Core/Registrar.cs | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) (limited to 'Xamarin.Forms.Core/Registrar.cs') diff --git a/Xamarin.Forms.Core/Registrar.cs b/Xamarin.Forms.Core/Registrar.cs index 0b13a611..617066af 100644 --- a/Xamarin.Forms.Core/Registrar.cs +++ b/Xamarin.Forms.Core/Registrar.cs @@ -1,11 +1,13 @@ using System; using System.Collections.Generic; +using System.ComponentModel; using System.Linq; using System.Reflection; -namespace Xamarin.Forms + +namespace Xamarin.Forms.Internals { - internal class Registrar where TRegistrable : class + public class Registrar where TRegistrable : class { readonly Dictionary _handlers = new Dictionary(); @@ -24,15 +26,17 @@ namespace Xamarin.Forms return (TRegistrable)handler; } - internal TOut GetHandler(Type type) where TOut : TRegistrable + [EditorBrowsable(EditorBrowsableState.Never)] + public TOut GetHandler(Type type) where TOut : TRegistrable { return (TOut)GetHandler(type); } - internal Type GetHandlerType(Type viewType) + [EditorBrowsable(EditorBrowsableState.Never)] + public Type GetHandlerType(Type viewType) { Type type; - if(LookupHandlerType(viewType, out type)) + if (LookupHandlerType(viewType, out type)) return type; // lazy load render-view association with RenderWithAttribute (as opposed to using ExportRenderer) @@ -84,7 +88,7 @@ namespace Xamarin.Forms } } - internal static class Registrar + public static class Registrar { static Registrar() { @@ -93,11 +97,14 @@ namespace Xamarin.Forms internal static Dictionary Effects { get; } = new Dictionary(); - internal static IEnumerable ExtraAssemblies { get; set; } + [EditorBrowsable(EditorBrowsableState.Never)] + public static IEnumerable ExtraAssemblies { get; set; } - internal static Registrar Registered { get; } + [EditorBrowsable(EditorBrowsableState.Never)] + public static Registrar Registered { get; } - internal static void RegisterAll(Type[] attrTypes) + [EditorBrowsable(EditorBrowsableState.Never)] + public static void RegisterAll(Type[] attrTypes) { Assembly[] assemblies = Device.GetAssemblies(); if (ExtraAssemblies != null) -- cgit v1.2.3