From 30c0dcb949186c21c60c4c9ddf8a581d40a43662 Mon Sep 17 00:00:00 2001 From: "E.Z. Hart" Date: Tue, 16 Aug 2016 12:10:32 -0600 Subject: Fix Entry/SearchBar color issues (#306) * Fix disappearing Entry text on UWP Anniversary Edition Fix background color reversion bug in UWP Phone Move SearchBar styling on UWP to its own file Make foreground/background color changes on UWP SearchBar/Entry consistent Fix SearchBar color toggle bug on WP8 * Temporarily moving SDK target to previous version * Fix build error on OSX --- .nuspec/Xamarin.Forms.nuspec | 1 + ...in.Forms.ControlGallery.WindowsUniversal.csproj | 2 +- .../DefaultColorToggleTest.cs | 4 +- Xamarin.Forms.Platform.UAP/AutoSuggestStyle.xaml | 389 +++++++++++++++++++++ Xamarin.Forms.Platform.UAP/FormsTextBoxStyle.xaml | 8 +- Xamarin.Forms.Platform.UAP/Resources.xaml | 384 +------------------- Xamarin.Forms.Platform.UAP/SearchBarRenderer.cs | 40 +-- .../Xamarin.Forms.Platform.UAP.csproj | 7 + Xamarin.Forms.Platform.WP8/BrushHelpers.cs | 37 ++ Xamarin.Forms.Platform.WP8/EntryRenderer.cs | 45 +-- Xamarin.Forms.Platform.WP8/SearchBarRenderer.cs | 36 +- .../Xamarin.Forms.Platform.WP8.csproj | 1 + Xamarin.Forms.Platform.WinRT/BrushHelpers.cs | 43 +++ Xamarin.Forms.Platform.WinRT/EntryRenderer.cs | 62 ++-- Xamarin.Forms.Platform.WinRT/FormsTextBox.cs | 16 +- .../Xamarin.Forms.Platform.WinRT.csproj | 1 + 16 files changed, 544 insertions(+), 532 deletions(-) create mode 100644 Xamarin.Forms.Platform.UAP/AutoSuggestStyle.xaml create mode 100644 Xamarin.Forms.Platform.WP8/BrushHelpers.cs create mode 100644 Xamarin.Forms.Platform.WinRT/BrushHelpers.cs diff --git a/.nuspec/Xamarin.Forms.nuspec b/.nuspec/Xamarin.Forms.nuspec index f57e53ad..16520f0f 100644 --- a/.nuspec/Xamarin.Forms.nuspec +++ b/.nuspec/Xamarin.Forms.nuspec @@ -239,6 +239,7 @@ + diff --git a/Xamarin.Forms.ControlGallery.WindowsUniversal/Xamarin.Forms.ControlGallery.WindowsUniversal.csproj b/Xamarin.Forms.ControlGallery.WindowsUniversal/Xamarin.Forms.ControlGallery.WindowsUniversal.csproj index a4952000..58ad67b3 100644 --- a/Xamarin.Forms.ControlGallery.WindowsUniversal/Xamarin.Forms.ControlGallery.WindowsUniversal.csproj +++ b/Xamarin.Forms.ControlGallery.WindowsUniversal/Xamarin.Forms.ControlGallery.WindowsUniversal.csproj @@ -12,7 +12,7 @@ Xamarin.Forms.ControlGallery.WindowsUniversal en-US UAP - 10.0.10240.0 + 10.0.10586.0 10.0.10240.0 14 true diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/DefaultColorToggleTest.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/DefaultColorToggleTest.cs index 4cd6cf5f..f943f158 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/DefaultColorToggleTest.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/DefaultColorToggleTest.cs @@ -58,7 +58,7 @@ namespace Xamarin.Forms.Controls static ContentPage SearchBarPage() { - var searchbarTextColorDefaultToggle = new Entry() { Text = "Default SearchBar Text Color" }; + var searchbarTextColorDefaultToggle = new SearchBar() { Text = "Default SearchBar Text Color" }; var searchbarTextColorToggleButton = new Button() { Text = "Toggle SearchBar Color" }; searchbarTextColorToggleButton.Clicked += (sender, args) => { if (searchbarTextColorDefaultToggle.TextColor.IsDefault) @@ -73,7 +73,7 @@ namespace Xamarin.Forms.Controls } }; - var searchbarPlaceholderColorDefaultToggle = new Entry() { Placeholder = "Default Placeholder Color" }; + var searchbarPlaceholderColorDefaultToggle = new SearchBar() { Placeholder = "Default Placeholder Color" }; var searchbarPlaceholderToggleButton = new Button() { Text = "Toggle Placeholder Color" }; searchbarPlaceholderToggleButton.Clicked += (sender, args) => { if (searchbarPlaceholderColorDefaultToggle.PlaceholderColor.IsDefault) diff --git a/Xamarin.Forms.Platform.UAP/AutoSuggestStyle.xaml b/Xamarin.Forms.Platform.UAP/AutoSuggestStyle.xaml new file mode 100644 index 00000000..3c85a01f --- /dev/null +++ b/Xamarin.Forms.Platform.UAP/AutoSuggestStyle.xaml @@ -0,0 +1,389 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Visible + + + + + + + + + + + + + + + + + + + + + + + +