summaryrefslogtreecommitdiff
path: root/Xamarin.Forms.Controls.Issues
AgeCommit message (Collapse)AuthorFilesLines
2017-03-24Clean sync with 2.3.4-2Kangho Hur24-609/+70
Change-Id: I6a7423d2690a1c30f46e0c128d9504a2464f8f0b
2017-03-24[WinRT/UWP] Fix Slider binding value incorrectly (#729)Paul DiPietro2-0/+63
2017-03-24Add MacOS gallery and UITest (#721)Rui Marinho17-70/+181
* [MacOS] Cleanup * [Controls] Add Header support to ListView * [MacOS] NSView reuse on NSTableView * [MacOS] Some fix on layour order * [MacOS] Add CarouselPageRenderer * [MacOS] Implement EventTracker on PageRenderer * [MacOS] Cleanup CarouselPageRenderer * [MacOS] Add MasterDetailPage renderer * [MacOS] MDP renderer don't allow drag of splitter * [MacOS] Add TabbedPage renderer * [MacOS] Initial sketch of NavigationPageRenderer * [MacOS] Send disappearing of CurrentPage on Dispose on NavigationPageRenderer * [MacOS] Add Gallery page for Mac * [MacOS] Add MacOSExpressionSearch * [MacOS] Fix ColorExtension * [MacOS] Fix MDP renderer layout * [MacOS] Implement native selection on ListViewRenderer * [MacOS] Deselect a item on NSTableView * [MacOS] Remove previous SplitViewItems * [MacOS] Fix navigationpage height * [MacOS] Add toolbar for NavigationPageRenderer * [MacOS] Don't remove selection for now (crashing) * [MacOS] Refactor page and back button title on NavigationPageRenderer * [MacOS] Fix bug when native navigate back * [MacOS] Hide layer when transition * [MacOS] ListviewRenderer fix BbackgroundColor * [MacOS] Fix background on ScrollViewRenderer * [MacOS] Fix header measure on ListViewRenderer * [MacOS] Add Mac twitter demo * [Controls] Spaces for easy reading * [MacOS] More xaml cleanup * [Core] Add Mac as aTargetPlatform * [MacOS] Add alerts and actionsheets * [MacOS] Add GestureRecognizers * [MacOS] Fix Layout issues when adding children, enable transformations * [MacOS] Fix title on tab item, move to tabbed navigation based on segmented control * [MacOS] Hide toolbar when not needed, this allows to work with tabbed page, cleanup * [MacOS] Add NativeBindings and NativeViewWrapper * [MacOS] Fix AssemblyInfo * [MacOS] FIX NRE on SetBackgroundColor BoxView * [MacOS] Fix NavigationPageRenderer * [MacOS] Fix build * [MacOS] Also update page when it resizes * [MacOS] Add LayoutRenderer for handle items position when the bounds change. * [MacOS] Refactor/Cleanup * [MacOS] Add toolbar items support to NavigationPage * [MacOS] Resize images for TabViewITems * [MacOS] Fix TabbedPage resize issues , allow users to override some features when creating TVI * [MacOS] Fix hide/show Navigation toolbar * [MacOS] Redo CarouselPageRenderer with NSPageController * [MacOS] Add support for Modal pages * [MacOS] Refactor navigation from platform * [Nuget] Add nuget for MacOS * [Nuget]Fix nuspec * [Nuget] Add variables for CI * [Controls] Remove MainMenu from MacOS * [MacOS] Add TableView renderer (no headers yet) * [MacOS] Refactoring, marking extensions as internal * [MacOS] Add group headers for TableViewRenderer * [MacOS] Workaround for updates on listview collection * [MacOS] Handle updates of rows in the ListViewRenderer properly * [MacOS] Fix navigation animation * Fix navigation header issues with modal pages * [MacOS] Fix MDP issues with resizing * [MacOS] Fix general dispose * [MacOS] Add a ViewControllerWrapper for NSSplitView * [MacOS] MDP renderer fix animation * [MacOS] Fix ListView selection bug * [MacOS] Fix rendering MDP Layout inside wrappers * [MacOS] Re write the MainToolbar handler * [MacOS] Don't use Sierra new extensions so we can run in stable channel * [MacOS] Another way to hide the toolbar (smarter i think) * [MacOS] Fix MDP bug and remove debug color * [Controls] Add HanselForms sample * [MacOS] Fix NRE WebviewRenderer * [MacOS] Fix uneven rows on ListView renderer * [MacOS] Fix NRE on load (can+t find the reason this happens) * [MacOS] Fix uneven rows * [MacOS] Fix header sizing on ListViewRenderer * [Controls] More stuff on HanselForms * [MacOS] Remove warning from ListViewRenderer * [MacOS] Fix PageRenderer bug double init * [MacOS] Don't calculate height if RowHeight is provided * [Controls] More Hanselforms stuff * [MacOS] Once again a new implementation for the NavigationBar, this time using a custom view to support BackgroundColor * [MacOS] Fix build * [MacOS] Refactoring AwesomeBar related controls * Fix build * [MacOS] NavigationBar update background and t test colors * [MacOS] Fix when we remove navigation so it works when the NavigationRenderer wasn't removed from the parent controller like in a TabbedPage * [MacOS] Add support for ListView grouping * [MacOS] Fix image extension method. * [MacOS] Add base Maps project * [MacOS] Export MapRenderer * [MacOS] Add pin click and geocoderbacked for Maps * [MacOS] Add extra binding project for API not in stable. * [MacOS] Add MacOS Maps lib * [MacOS]Fix build on alpha * [MacOS] Remove MacOS Maps extra binding * [UITest] Basic macOS setup * [UITest] Add MacOSApp wrapper implementation * [MacOS] Set AutomationID * [UITests] Add ActionSheetUITests to MacOS UITest * [MacOS] Fix bug on Picker * [UITests] Link basic uitest basefixture and related files * [MacOS] Fix pickers reuse * [UItests] Fix MacOS app path * [UITest] Ignore UItest for appearing on macOS for now * [UITest] Update macOS for 2.0.3 * [UITest] Refactor EnterText MacOS app * [UITest]Fix ViewQuery on MacOS * [UITest]Fix IsEnabled UItest on macOS * [UITest] Implement Enter, mark some tests inconclusive fix others * [MacOS] Implement Entry Completed event * [UITests] Fix UITest for IsVisible, ignore ToolbarItem test for now * [UITests] Fix ISVisible again add extra category * [Controls] Cleanup macOS gallery * [MacOS] Fix Assembly info * [Docs] Fix docs * Fix build * [Nuget] Fix nuspec * [Controls] Link files on MacOS * [Core] Update Forms stack before firing a event saying page was removed, possible breaking change * [MacOS] Implement RemovePage on NavigationPAgeRenderer * [UItest] Ignore some , implement back on MacOS UITest app * [MacOS] Add default back button name (needs to be translated) * [MacOS] Fix dispose * [UITest] Make 29257 work on MacOS * [MacOS] Rename stuff * [MacOS] More renaming and cleanup * [MacOS] Share implementations for iOS * [MacOS] Reuse more IOS extensions * [MacOS] Reuse FontExtensions * [MacOS] Share NativeViewWrapper related stuff * [MAcOS] Share event args and ExportRenderer * [MacOS] Share platform effect * [MacOS] Fix build * [Docs]Fixing docs * [MacOS] Fix ViewCell reuse * [Core] Support ListView CachingStrategy on MacOS * [MacOS] Fix issues with TextCell and ImageCell (we can’t set null to a NSControl value) * [MacOS] Fix MDP child sizing bug [UITest] Query marked by id and text * [MacOS] Comment test related with context actions * [MacOS] Implement missing stuff on ticker * [MacOS] Make sure VisualElemenTracker calls the ticker update * [UITests]Ignore context actions and not possible to test * [MacOS] Fix Grouping bug on Listview * [MacOS] Fix selection on Listview when using grouping * [MacOS] Update navbar when page is popped * [MacOS] Cleanup NavigationBar * [Controls] More info on exceptions * [MacOS] Fix bug animation pop modal * [MacOS] Bring back BackgroundColor of NavigationBar * [MacOS] Fix UITest animation delay * [MacOS] Treat warnings as errors * [MacOS] Center title on toolbar * [Core] Add Platform configuration specific for MacOS * [MacOS] Implement TabbedPage platform specific to handle TabItems on NavigationPage bar * [MacOS] Fix warning * [MacOS] Fix bug on SearchBar color * [MacOS]Fix build * [MacOS] remove extra dll from maps * [Docs] Update docs * [MacOS]Cleanup and refactoring * Revert "[MacOS] remove extra dll from maps" This reverts commit 73b948937001fea3f28449a963d0b94943e07aa0. * [MacOS] Fix wrong refactoring * [MacOS] dix formatting * [MacOS] Fix build * [MacOS] Fix bug on TabbedPageRenderer no title * [MacOS,UITest] Update packages * [MacOS ,UITest] Add delay when tapping something, and focus with double click * [MacOS,UITest] Ignore UITest, not possible to test with current version * [MacOS,UITest] Ignore test that uses Frame, UITest doesn’t return it * [MacOS] Fix bug when no title on toolbar items * [MacOS] Remove FormsNSView * [MacOS] Cleanup on dispose on MDP renderer * [MacOS] Different way to test leak of MDP, need to look at this again after * [MacOS] Update current page when source changes * [MacOS] More cleanup * [MacOS,UITest] Implement ClearText * [MacOS,UITest] ClearText doesn’t work for now on MacOS uitest * [MacOS] Make sure we show the previous page when popping a Modal * [MacOS] Fix issue with sizing the Header and visibility, remove for now header renderer reuse * [MacOS] Clean CustomNSTableView * [MacOS] Share LabelRenderer with iOS * [MacOS,UITest] Don’t try to scroll for the element * [MacOS] Share ResourcesProvider with iOS * [MAcoS] Share VisualElementPackager with iOS * [MacOS] Share ViewRenderer with iOS * [MacOS] Merge with VisualElementTracker from iOS * [MacOS] Merge with EventTracker from iOS * [MacOS] Merge with VisualElementRenderer of iOS * [MacOS] Make sure we always have a layer * [MacOS] Fix Tracker merge with iOS version * [MacOS] Fix bug with tabbed page on modal without navigation * [Core] Rever change on core * [Controls] Add missing image * [MacOS] Clear renderers before setting them MDP * [MacOS] Update tabbedPage ContainerArea * [Controls] Add Custom renderers tests * [MacOS] Fix ListViewRenderer * [MacOS,UITest] Refactoring, implement index * [MacOS] Make sure we don’t pass null to TextField string value * [MacOS] Support for multiple clicks in same selected item on NSTableView * [MacOS, UITest] Fix bug on Back because of refactoring * [MacOS,UITest] Ignore UITest because we’d-not have ScrollDownTo yet * [MacOS] Support Focus on EntryRenderer * [MacOS,UITest] Ignore more a couple of tests that we can’t test on UITest Desktop * [MacOS,UITest] MacOSApp looks for StaticText fields too * [MacOS, UITest] Fix EnterText for marked Entry * [MacOS] Fix index bug on TablevIewDataSource * [MacOS] Fix SelectedItem TableViewDataSource * [Nuget] Add Mac to Maps nuspec * [Nuget]Fix path * [Controls] Add basic FormsGallery sample * [macOS] Fixed Tab NSImage crash in TabbedPageRenderer (#705) * [macOS] Fixed Tab NSImage crash in TabbedPageRenderer * Coding Style * Coding Style * [MacOS] Fix previous merge with master * [MacOS] Possible simple fix for click on views overlapping * [UItest] Ignore this part of the test we can’t click on NSViews yet * [MacOS] Rename to IsOnViewCell * fix docs * [MacOS] Cleanup, Address feedback from Samantha’s review * [MacOS] Add ContextActions * [Controls] Remove FormsGalery for now * [Docs] Update docs * [MacOS] Implement ContextActions * [MacOS,UITests] Enable and support UITests of ContextActions
2017-03-24Use a prototype TextBlock to resolve theme resources on Windows (#703)E.Z. Hart2-0/+31
* Use a prototype TextBlock to resolve theme resources on Windows * Move textblock declaration to beginning of class * Don't retain prototype TextBlock in memory
2017-03-24[Android] Keyboard should not change layout while dismissing on Entry and ↵adrianknight892-0/+50
Editor (#663) * handle keyboard on entry * add sample code * editor changes * change text * better fix * changes
2017-03-24[iOS/Critical] Fix ListView memory leaks (#524)adrianknight893-0/+280
* fix memory leaks added sample code changed page name Changed page title add screen instructions fix copy paste error change subview dispose logic Fix context action memory leak add sample code change custom page names Revert "change custom page names" This reverts commit 7aaab2625d9526080ca5c51c02e909f09ee3f610. changed class names changes UI test for 32206 update ui test fix whitespace UITests done * run UI tests on iOS only * fix code style * dispose prototype * fix child renderer issue * add null check
2017-03-24Pool and reuse MKMapView instances on iOS 9 as well as iOS 10 (#680)E.Z. Hart1-0/+4
2017-03-22[iOS/Win] Label will not unnecessarily expand (#827)Samantha Houts2-0/+36
* Add repro for 53362 * [iOS] Label will not unnecessarily expand * [Win] Label will not unnecessarily expand
2017-03-22[Win] Labels will now wrap when inside horizontally infinite layouts (#639)Samantha Houts2-0/+68
* Add repro for 42559 * [Win] Override GetDesiredSize for LabelRenderer * [Win] Invalidate size on font/align change
2017-03-20Add check for disposed gesture detector on VisualElementRendererE.Z. Hart2-0/+120
2017-03-14Fix buildbeta-2.3.4-pre5Rui Marinho1-1/+0
2017-03-14Bug 51536, initial iOS cell layout is incorrect when cell has context ↵Vitaly Knyazev2-0/+83
actions … (#787) * Bug 51536, initial height is incorrect when cell has context actions or ListView is in recycle mode * Improved fix for iOS uneven height cell layout * Fixed indentation and added test case for issue 44525 * Fixed indentation for test case * Added 1px room, this will fix Bugzilla31330 test, renamed test case to 51536 * Updated shared project file
2017-03-10Fix buildbeta-2.3.4-pre4Rui Marinho1-1/+0
2017-03-10[UWP] Improve toolbar consistency on MasterDetailPage (#744)Jimmy Garrido3-0/+83
* Improve toolbar consistency on MasterDetailPage * Properly indent xaml page
2017-03-10Add repro for 52533Samantha Houts2-0/+65
2017-03-10[Controls] Fix build of test caseRui Marinho1-0/+2
2017-03-10Add Preserve attributePaul DiPietro1-0/+1
2017-03-10[C] Update SelectedItem prior to event invokePaul DiPietro2-12/+15
2017-03-10[UWP] connect the actual ObservableCollection to the ComboBox.ItemsSourceStephane Delcroix3-0/+65
2017-03-08Fix buildRui Marinho1-5/+0
2017-03-03Fix for Android Visibility/Opacity crash (#785)E.Z. Hart2-0/+70
* Repro * Fix for UI test * Cache the Alpha value and queue up restoration after the visibility is changed * Fix issue with negative height/width in UpdateLayout * Clean up usings
2017-03-03[Android] Don't crash if Control is accessed in Effect OnDetached when Page ↵Samantha Houts2-0/+58
is Disposed. (#772) * Add repro for 51505 * [Android] Don't dispose of EffectControlProvider * Oops
2017-01-19Fix NullReferenceException in VisualElement finalize. (#701)Kevin Petit2-0/+81
2017-01-12Fix out-of-memory crashes on iOS when creating maps (#467)E.Z. Hart1-4/+31
* Pool map views on iOS 10 to avoid memory issues Clean up disposal implementation for map renderer, delegate * Enable 39489 test on iOS * Add missing XF Maps references * Add missing maps reference to Windows 8.1 project * Actually enable the test for iOS * Fix placement of Isolate override * Don't create a new control for ImageRenderer if NewElement is null * Reverting fixes to ViewRenderer Dispose; have to fix that in a separate PR
2017-01-12[C] new OnPlatform mechanism (#658)Stephane Delcroix18-45/+54
* [C] Obsolete TargetPlatform * [Xaml] support and test the new syntax * blind fix windows platforms
2017-01-12[iOS] Labels with WordWrap or CharacterWrap will Expand (#529)Samantha Houts2-0/+166
* Add reproduction for 28650 * [iOS] Expand the label to fill width if wrapping Also, simplify the `if` statement, since `LineBreakMode` is not a flags enum and the only excluded member was `None`. * Test two small labels next to each other in horizontal layout
2017-01-10iOS and Android timers should be runnable from any thread and execute… (#374)adrianknight892-0/+117
* iOS and Android timers should be runnable from any thread and executed on the main thread * removing unused Timer class declarations with minor refactoring efforts * iOS and Android timers should be runnable from any thread and executed on the main thread * removing bak file * switch to v7 * add test code
2017-01-10Update 45926 test to account for NavigationPage ref to popped pageE.Z. Hart1-1/+12
2017-01-03Allow subscriber to be collected if MessagingCenter is the only reference to ↵E.Z. Hart2-0/+112
it (#617) * Repro * Make messaging center callbacks weak references * Preserve attribute * Fix test method name * Watch for collection of actual delegate target instead of wrapper delegate * Preserve the original platform instance when changing main page * Better tests for lambda situations * Update tests, make callback target a weakreference if it's the subscriber * Ensure old Platform MessagingCenter subs are gone before creating new Platform
2017-01-03[WinRT/UWP] Apply BackgroundColor to Stepper buttons (#581)Paul DiPietro2-0/+47
* [WinRT/UWP] Apply BackgroundColor to Stepper buttons * Add explanatory text; use nameof * Move explanatory text to a label
2017-01-03[iOS] Prevent multiple ListView cells from being swiped simultaneously (#578)adrianknight892-0/+62
* disable multiple cell swipe * add sample code * refactored * convert to weakreference * remove null setting * change weakreference setting place * remove if * revert isopen changes * add instructions
2017-01-03Make UWP toolbar display rules consistent with other platforms (#638)E.Z. Hart2-0/+36
2016-12-30[iOS] Change keyboard type while keyboard is visible (#443)adrianknight892-0/+79
* Change keyboard while changing text * add sample code
2016-12-28fix nre when changing content in datepickerselected (#494)adrianknight892-0/+59
2016-12-27[UWP] Fix TextBox style for foreground focus color (#618)Paul DiPietro2-0/+119
2016-12-22[iOS] Entry should not pass a newline to the next responder (#397)adrianknight892-0/+54
* UITextField should not return so that the next field does not get passed a newline * Added code sample
2016-12-19[UWP] Use toolbar foreground color on primary items (#640)Paul DiPietro2-0/+56
2016-12-16[WinRT] Use a queue to prevent multiple MessageDialogs from causing a crash ↵Paul DiPietro2-0/+38
(#347) * [WinRT] Use a queue to prevent multiple MessageDialogs from causing a crash * Make change to use Device.IsInvokeRequired
2016-12-14Fix potential NRE in ConditionalFocusLayout (#587)2.3.3.175E.Z. Hart2-0/+53
2016-12-13Disable using EstimatedRowHeight for uneven rows with known heights (#454)E.Z. Hart2-0/+205
2016-12-12Add missing interface implementationsE.Z. Hart1-0/+10
2016-12-07Fix 41415 test (use rounding)E.Z. Hart1-3/+4
2016-12-07[UITest] Only run 41415 test on AndroidRui Marinho1-1/+1
2016-12-06Put test in the correct namespaceE.Z. Hart1-1/+1
2016-12-06[Android] Dismiss context menu when view cell is removed (#568)adrianknight892-0/+107
* close context action when cell is no longer available * rename method
2016-12-06[Android] ScrollView should send correct ScrollX and ScrollY (#394)adrianknight892-0/+116
* Android should show correct ScrollX and ScrollY when scrolling in both directions * Adding sample code to demonstrate scrolling * Orientation fix * ScrollTo should work for horizontal + vertical scrolling * Get correct scroll x and y values for ScrollOrientation.Both * Convert positions to pixels * Adding unit test to watch out for incorrect animation positioning * automated test * improvements * fixed texts
2016-12-05[WinRT/UWP] Adjust margin for centered Slider (#604)Paul DiPietro2-0/+50
2016-12-01Revert "Jimmgarrido uwp toolbar (#588)"Stephane Delcroix2-41/+1
This reverts commit 1ff0db9c6f4ba1167e6b2620066f83088f23c5bf.
2016-12-01Jimmgarrido uwp toolbar (#588)Stephane Delcroix2-1/+41
* Fixed CommandBar being clipped when expanded by removing explicit Height * Add UITest
2016-12-01Don't run Command CanExecute on incorrect inherited binding context type (#572)E.Z. Hart2-0/+110
* Allow Command CanExecute to recover when run on inherited bindingcontext * Make exception handler more generic * Checking types in Command delegates to avoid exception in the first place * Adding type chekc to other Command constructor * Use nameof for ArgumentNullExceptions * Add unit tests for null parameters, handle value types and Nullable<T>