diff options
Diffstat (limited to 'Xamarin.Forms.Controls.Issues')
6 files changed, 70 insertions, 4 deletions
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla45874.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla45874.cs index 46c53607..37bee9b4 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla45874.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla45874.cs @@ -26,7 +26,7 @@ namespace Xamarin.Forms.Controls.Issues var scrollView = new ScrollView { Content = label }; - var effect = Effect.Resolve("XamControl.BorderEffect"); + var effect = Effect.Resolve($"{Issues.Effects.ResolutionGroupName}.BorderEffect"); scrollView.Effects.Add(effect); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla51505.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla51505.cs index 2851009e..e34b2ed3 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla51505.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla51505.cs @@ -22,7 +22,7 @@ namespace Xamarin.Forms.Controls.Issues protected override void Init() { - var effect = Effect.Resolve("XamControl.BorderEffect"); + var effect = Effect.Resolve($"{Issues.Effects.ResolutionGroupName}.BorderEffect"); var button = new Button { Text = "Click me", AutomationId = ButtonId }; button.Clicked += async (sender, e) => diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla56609.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla56609.cs index dad544c8..968de6e4 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla56609.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla56609.cs @@ -20,7 +20,7 @@ namespace Xamarin.Forms.Controls.Issues VerticalOptions = LayoutOptions.CenterAndExpand, HorizontalOptions = LayoutOptions.CenterAndExpand }; - entry.Effects.Add(Effect.Resolve("Xamarin.FocusEffect")); + entry.Effects.Add(Effect.Resolve($"{Issues.Effects.ResolutionGroupName}.FocusEffect")); Content = new StackLayout { @@ -38,7 +38,7 @@ namespace Xamarin.Forms.Controls.Issues } public class Bugzilla56609FocusEffect : RoutingEffect { - public Bugzilla56609FocusEffect() : base("Xamarin.FocusEffect") + public Bugzilla56609FocusEffect() : base($"{Effects.ResolutionGroupName}.FocusEffect") { } } diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla58406.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla58406.cs new file mode 100644 index 00000000..3a31ca33 --- /dev/null +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla58406.cs @@ -0,0 +1,57 @@ +using Xamarin.Forms.CustomAttributes; +using Xamarin.Forms.Internals; + +#if UITEST +using Xamarin.UITest; +using NUnit.Framework; +using Xamarin.Forms.Core.UITests; +#endif + +namespace Xamarin.Forms.Controls.Issues +{ +#if UITEST + [Category(UITestCategories.Effects)] + [Category(UITestCategories.Label)] +#endif + + [Preserve(AllMembers = true)] + [Issue(IssueTracker.Bugzilla, 58406, + "Effect is never attached to Label, but is attached to Label subclass (Android)", PlatformAffected.Android)] + public class Bugzilla58406 : TestContentPage + { + public const string EffectName = "_58406Effect"; + const string InitialText = "_58406"; + const string ReversedText = "60485_"; + + [Preserve(AllMembers = true)] + public class _58406Effect : RoutingEffect + { + public _58406Effect() : base($"{Issues.Effects.ResolutionGroupName}.{EffectName}") + { + } + } + + protected override void Init() + { + var label = new Label { Text = InitialText }; + label.Effects.Add(Effect.Resolve($"{Issues.Effects.ResolutionGroupName}.{EffectName}")); + + Content = new StackLayout + { + Padding = new Thickness(0, 20, 0, 0), + Children = + { + label + } + }; + } + +#if UITEST + [Test] + public void EffectAppliesToLabel() + { + RunningApp.WaitForElement(ReversedText); + } +#endif + } +}
\ No newline at end of file diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Effects.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Effects.cs new file mode 100644 index 00000000..58648a42 --- /dev/null +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Effects.cs @@ -0,0 +1,7 @@ +namespace Xamarin.Forms.Controls.Issues +{ + public static class Effects + { + public const string ResolutionGroupName = "XamControl"; + } +}
\ No newline at end of file diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems index 8f175b96..090643b1 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems @@ -215,6 +215,7 @@ <Compile Include="$(MSBuildThisFileDirectory)Bugzilla57317.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla57114.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla57758.cs" /> + <Compile Include="$(MSBuildThisFileDirectory)Bugzilla58406.cs" /> <Compile Include="$(MSBuildThisFileDirectory)ButtonBackgroundColorTest.cs" /> <Compile Include="$(MSBuildThisFileDirectory)CarouselAsync.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla34561.cs" /> @@ -225,6 +226,7 @@ <Compile Include="$(MSBuildThisFileDirectory)Bugzilla38416.xaml.cs"> <DependentUpon>Bugzilla38416.xaml</DependentUpon> </Compile> + <Compile Include="$(MSBuildThisFileDirectory)Effects.cs" /> <Compile Include="$(MSBuildThisFileDirectory)FailImageSource.cs" /> <Compile Include="$(MSBuildThisFileDirectory)GestureBubblingTests.cs" /> <Compile Include="$(MSBuildThisFileDirectory)InputTransparentTests.cs" /> |