diff options
Diffstat (limited to 'Xamarin.Forms.Controls.Issues')
24 files changed, 70 insertions, 609 deletions
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla25979.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla25979.cs index 08b6f8a6..dc07c04b 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla25979.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla25979.cs @@ -115,17 +115,11 @@ namespace Xamarin.Forms.Controls.Issues RunningApp.Screenshot ("At page one"); RunningApp.WaitForElement (q => q.Marked ("PageOneButtonId")); RunningApp.Tap (q => q.Marked ("PageOneButtonId")); -#if __MACOS__ - System.Threading.Thread.Sleep(2000); -#endif RunningApp.WaitForElement (q => q.Marked ("PageTwoId")); RunningApp.Screenshot ("At page two - I didn't crash"); RunningApp.WaitForElement (q => q.Marked ("PageTwoButtonId")); RunningApp.Tap (q => q.Marked ("PageTwoButtonId")); -#if __MACOS__ - System.Threading.Thread.Sleep(2000); -#endif RunningApp.WaitForElement (q => q.Marked ("PageThreeId")); RunningApp.Screenshot ("At page three - I didn't crash"); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla26501.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla26501.cs index b2f13b0a..56ccec81 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla26501.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla26501.cs @@ -136,7 +136,7 @@ namespace Xamarin.Forms.Controls.Issues #if UITEST [Test] - public void TestCellsShowAfterRefresh() + public void TestCellsShowAfterRefresh () { RunningApp.Tap (q => q.Marked ("Refresh")); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla26993.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla26993.cs index 77081ccc..5ba0de11 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla26993.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla26993.cs @@ -87,9 +87,6 @@ namespace Xamarin.Forms.Controls.Issues #if UITEST [Test] -#if __MACOS__ - [Ignore("Webview query is not implemented yet on UITEst desktop")] -#endif public void Bugzilla26993Test () { RunningApp.Screenshot ("I am at BZ26993"); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla29257.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla29257.cs index a05be9fb..35503f9c 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla29257.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla29257.cs @@ -81,42 +81,18 @@ namespace Xamarin.Forms.Controls.Issues public void Bugzilla29257Test () { RunningApp.Tap (q => q.Marked ("Page 1")); -#if __MACOS__ - System.Threading.Thread.Sleep(2000); -#endif RunningApp.WaitForElement (q => q.Marked ("This is page 1")); RunningApp.Back (); -#if __MACOS__ - System.Threading.Thread.Sleep(2000); -#endif RunningApp.Tap (q => q.Marked ("Page 2")); -#if __MACOS__ - System.Threading.Thread.Sleep(2000); -#endif RunningApp.WaitForElement (q => q.Marked ("This is page 2")); RunningApp.Back (); RunningApp.Tap (q => q.Marked ("Page 3")); -#if __MACOS__ - System.Threading.Thread.Sleep(2000); -#endif RunningApp.WaitForElement (q => q.Marked ("This is page 3")); RunningApp.Back (); -#if __MACOS__ - System.Threading.Thread.Sleep(2000); -#endif RunningApp.Tap (q => q.Marked ("Page 4")); -#if __MACOS__ - System.Threading.Thread.Sleep(2000); -#endif RunningApp.WaitForElement (q => q.Marked ("This is page 4")); RunningApp.Back (); -#if __MACOS__ - System.Threading.Thread.Sleep(2000); -#endif RunningApp.Tap (q => q.Marked ("Page 5")); -#if __MACOS__ - System.Threading.Thread.Sleep(2000); -#endif RunningApp.WaitForElement (q => q.Marked ("This is page 5")); } #endif diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla30353.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla30353.cs index 3738c7e8..cde2fad5 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla30353.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla30353.cs @@ -10,69 +10,62 @@ using NUnit.Framework; namespace Xamarin.Forms.Controls.Issues { - [Preserve(AllMembers = true)] - [Issue(IssueTracker.Bugzilla, 30353, "MasterDetailPage.IsPresentedChanged is not raised")] + [Preserve (AllMembers = true)] + [Issue (IssueTracker.Bugzilla, 30353, "MasterDetailPage.IsPresentedChanged is not raised")] public class Bugzilla30353 : TestMasterDetailPage { - protected override void Init() + protected override void Init () { - var lbl = new Label - { + var lbl = new Label { HorizontalOptions = LayoutOptions.CenterAndExpand, VerticalOptions = LayoutOptions.CenterAndExpand, Text = "Detail" }; -#if !UITEST - if (App.IOSVersion == 7 || Device.RuntimePlatform == Device.macOS) - { + #if !UITEST + if (App.IOSVersion == 7) { lbl.Text = "Don't run"; } -#endif + #endif - var lblMaster = new Label - { + var lblMaster = new Label { HorizontalOptions = LayoutOptions.CenterAndExpand, VerticalOptions = LayoutOptions.CenterAndExpand, Text = "Master" }; - var btn = new Button() - { + var btn = new Button () { Text = "Toggle" }; - var btn1 = new Button() - { + var btn1 = new Button () { Text = "Toggle" }; btn.Clicked += (object sender, EventArgs e) => IsPresented = !IsPresented; btn1.Clicked += (object sender, EventArgs e) => IsPresented = !IsPresented; - var stacklayout = new StackLayout(); - stacklayout.Children.Add(lbl); - stacklayout.Children.Add(btn); + var stacklayout = new StackLayout (); + stacklayout.Children.Add (lbl); + stacklayout.Children.Add (btn); - var stacklayout1 = new StackLayout(); - stacklayout1.Children.Add(lblMaster); - stacklayout1.Children.Add(btn1); + var stacklayout1 = new StackLayout (); + stacklayout1.Children.Add (lblMaster); + stacklayout1.Children.Add (btn1); - Master = new ContentPage - { + Master = new ContentPage { Title = "IsPresentedChanged Test", BackgroundColor = Color.Green, Content = stacklayout1 }; - Detail = new ContentPage - { + Detail = new ContentPage { BackgroundColor = Color.Gray, Content = stacklayout }; MasterBehavior = MasterBehavior.Popover; IsPresentedChanged += (s, e) => - lblMaster.Text = lbl.Text = string.Format("The Master is now {0}", IsPresented ? "visible" : "invisible"); + lblMaster.Text = lbl.Text = string.Format ("The Master is now {0}", IsPresented ? "visible" : "invisible"); } -#if UITEST + #if UITEST [Test] public void Bugzilla30353Test () { diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31330.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31330.cs index 5ab11a06..75e30b13 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31330.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31330.cs @@ -127,7 +127,7 @@ namespace Xamarin.Forms.Controls.Issues } } -#if UITEST + #if UITEST [Test] public void Bugzilla31330Test () { diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31333.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31333.cs index 830982ea..52c9f578 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31333.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31333.cs @@ -210,9 +210,6 @@ namespace Xamarin.Forms.Controls.Issues #if UITEST [Test] -#if __MACOS__ - [Ignore("EnterText on UITest.Desktop not implemented")] -#endif [UiTest (typeof(NavigationPage))] public void Issue31333FocusEntryInListViewCell () { @@ -225,9 +222,6 @@ namespace Xamarin.Forms.Controls.Issues } [Test] -#if __MACOS__ - [Ignore("EnterText on UITest.Desktop not implemented")] -#endif [UiTest (typeof(NavigationPage))] public void Issue31333FocusEditorInListViewCell () { @@ -241,9 +235,6 @@ namespace Xamarin.Forms.Controls.Issues [Test] -#if __MACOS__ - [Ignore("EnterText on UITest.Desktop not implemented")] -#endif [UiTest (typeof(NavigationPage))] public void Issue31333FocusEntryInTableViewCell () { @@ -256,9 +247,6 @@ namespace Xamarin.Forms.Controls.Issues } [Test] -#if __MACOS__ - [Ignore("EnterText on UITest.Desktop not implemented")] -#endif [UiTest (typeof(NavigationPage))] public void Issue31333FocusEditorInTableViewCell () { diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla32206.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla32206.cs deleted file mode 100644 index 428538f6..00000000 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla32206.cs +++ /dev/null @@ -1,142 +0,0 @@ -using System; -using System.Collections.Generic; -using Xamarin.Forms.CustomAttributes; -using Xamarin.Forms.Internals; -using System.Threading; - -#if UITEST -using Xamarin.UITest; -using NUnit.Framework; -#endif - -namespace Xamarin.Forms.Controls.Issues -{ - [Preserve(AllMembers = true)] - [Issue(IssueTracker.Bugzilla, 32206, "ContextActions cause memory leak: Page is never destroyed", PlatformAffected.iOS)] - public class Bugzilla32206 : TestNavigationPage - { - protected override void Init() - { - PushAsync(new LandingPage32206()); - } - -#if UITEST && __IOS__ - [Test] - public void Bugzilla32206Test() - { - for (var n = 0; n < 10; n++) - { - RunningApp.WaitForElement(q => q.Marked("Push")); - RunningApp.Tap(q => q.Marked("Push")); - - RunningApp.WaitForElement(q => q.Marked("ListView")); - RunningApp.Back(); - } - - // At this point, the counter can be any value, but it's most likely not zero. - // Invoking GC once is enough to clean up all garbage data and set counter to zero - RunningApp.WaitForElement(q => q.Marked("GC")); - RunningApp.Tap(q => q.Marked("GC")); - - RunningApp.WaitForElement(q => q.Marked("Counter: 0")); - } -#endif - } - - [Preserve(AllMembers = true)] - public class LandingPage32206 : ContentPage - { - public static int Counter; - public Label Label; - - public LandingPage32206() - { - Label = new Label - { - Text = "Counter: " + Counter, - HorizontalTextAlignment = TextAlignment.Center, - VerticalTextAlignment = TextAlignment.Center - }; - - Content = new StackLayout - { - Orientation = StackOrientation.Vertical, - HorizontalOptions = LayoutOptions.Center, - VerticalOptions = LayoutOptions.Center, - Spacing = 15, - Children = - { - new Label - { - Text = "Click Push to show a ListView. When you hit the Back button, Counter will show the number of pages that have not been finalized yet." - + " If you click GC, the counter should be 0." - }, - Label, - new Button - { - Text = "GC", - AutomationId = "GC", - Command = new Command(o => - { - GC.Collect(); - GC.WaitForPendingFinalizers(); - GC.Collect(); - Label.Text = "Counter: " + Counter; - }) - }, - new Button - { - Text = "Push", - AutomationId = "Push", - Command = new Command(async o => - { - await Navigation.PushAsync(new ContentPage32206()); - }) - } - } - }; - } - - protected override void OnAppearing() - { - base.OnAppearing(); - - if (Label != null) - Label.Text = "Counter: " + Counter; - } - } - - [Preserve(AllMembers = true)] - public class ContentPage32206 : ContentPage - { - public ContentPage32206() - { - Interlocked.Increment(ref LandingPage32206.Counter); - System.Diagnostics.Debug.WriteLine("Page: " + LandingPage32206.Counter); - - Content = new ListView - { - ItemsSource = new List<string> { "Apple", "Banana", "Cherry" }, - ItemTemplate = new DataTemplate(typeof(ViewCell32206)), - AutomationId = "ListView" - }; - } - - ~ContentPage32206() - { - Interlocked.Decrement(ref LandingPage32206.Counter); - System.Diagnostics.Debug.WriteLine("Page: " + LandingPage32206.Counter); - } - } - - [Preserve(AllMembers = true)] - public class ViewCell32206 : ViewCell - { - public ViewCell32206() - { - View = new Label(); - View.SetBinding(Label.TextProperty, "."); - ContextActions.Add(new MenuItem { Text = "Delete" }); - } - } -}
\ No newline at end of file diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla36171.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla36171.cs index bb8743d4..6bcd16b7 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla36171.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla36171.cs @@ -67,9 +67,6 @@ namespace Xamarin.Forms.Controls.Issues #if UITEST [Test] -#if __MACOS__ - [Ignore("Missing UITest for focus")] -#endif public void EntryTextDoesNotDisplayNonnumericInput () { RunningApp.WaitForElement ("Start Entry"); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39489.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39489.cs index 622a5f4b..0e04fcd5 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39489.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39489.cs @@ -7,7 +7,6 @@ using System.Threading.Tasks; using Xamarin.Forms.Maps; #if UITEST -using Xamarin.Forms.Core.UITests; using Xamarin.UITest; using NUnit.Framework; #endif @@ -15,9 +14,6 @@ using NUnit.Framework; namespace Xamarin.Forms.Controls.Issues { [Preserve(AllMembers = true)] -#if UITEST - [Category(UITestCategories.Maps)] -#endif [Issue(IssueTracker.Bugzilla, 39489, "Memory leak when using NavigationPage with Maps", PlatformAffected.Android | PlatformAffected.iOS)] public class Bugzilla39489 : TestNavigationPage { diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39530.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39530.cs index 6b7d380a..735b7197 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39530.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39530.cs @@ -57,9 +57,6 @@ namespace Xamarin.Forms.Controls.Issues #if UITEST [Test] -#if __MACOS__ - [Ignore("UITest.Desktop doesn't return empty NSView yet so it can't find the frame")] -#endif public void Bugzilla39530PanTest() { // Got to wait for the element to be visible to the UI test framework, otherwise we get occasional @@ -72,9 +69,6 @@ namespace Xamarin.Forms.Controls.Issues } [Test] -#if __MACOS__ - [Ignore("UITest.Desktop doesn't return empty NSView yet so it can't find the frame")] -#endif public void Bugzilla39530PinchTest() { RunningApp.PinchToZoomIn ("frame"); @@ -82,9 +76,6 @@ namespace Xamarin.Forms.Controls.Issues } [Test] -#if __MACOS__ - [Ignore("UITest.Desktop doesn't return empty NSView yet so it can't find the frame")] -#endif public void Bugzilla39530TapTest() { RunningApp.WaitForElement (q => q.Marked ("frame")); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40173.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40173.cs index 61d2b1b6..054a68c8 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40173.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40173.cs @@ -32,10 +32,9 @@ namespace Xamarin.Forms.Controls.Issues RunningApp.Tap(q => q.All().Marked(CanTouchButtonId)); RunningApp.WaitForElement(q => q.All().Text(CanTouchSuccessText)); -#if !__MACOS__ + RunningApp.Tap(q => q.All().Marked(ListTapTarget)); RunningApp.WaitForElement(q => q.All().Text(ListTapSuccessText)); -#endif } #endif diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40704.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40704.cs index 7efea71b..1298110f 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40704.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla40704.cs @@ -224,9 +224,6 @@ namespace Xamarin.Forms.Controls.Issues RunningApp.WaitForElement("Menu - 0"); } [Test] -#if __MACOS__ - [Ignore("ScrollDownTo not implemented in UITest.Desktop")] -#endif public void Bugzilla40704Test() { RunningApp.ScrollDownTo("btnCollappse", "lstMain", ScrollStrategy.Gesture, 0.8, timeout: TimeSpan.FromMinutes(2)); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla41619.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla41619.cs deleted file mode 100644 index 24c277de..00000000 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla41619.cs +++ /dev/null @@ -1,62 +0,0 @@ -using Xamarin.Forms.CustomAttributes; -using Xamarin.Forms.Internals; -using System.ComponentModel; -using System.Runtime.CompilerServices; - -#if UITEST -using Xamarin.UITest; -using NUnit.Framework; -#endif - -namespace Xamarin.Forms.Controls.Issues -{ - [Preserve(AllMembers = true)] - [Issue(IssueTracker.Bugzilla, 41619, "[WinRT/UWP] Slider binding works incorrectly", PlatformAffected.WinRT)] - public class Bugzilla41619 : TestContentPage - { - protected override void Init() - { - var vm = new Bugzilla41619ViewModel { SliderValue = 5 }; - BindingContext = vm; - var label = new Label(); - label.SetBinding(Label.TextProperty, "SliderValue"); - var slider = new Slider - { - Maximum = 10, - Minimum = 1, - }; - slider.SetBinding(Slider.ValueProperty, "SliderValue", BindingMode.TwoWay); - Content = new StackLayout - { - Children = - { - label, - slider, - new Label { Text = "The initial slider value above should be 5." } - } - }; - } - - class Bugzilla41619ViewModel : INotifyPropertyChanged - { - private double _sliderValue; - - public double SliderValue - { - get { return _sliderValue; } - set - { - _sliderValue = value; - OnPropertyChanged(); - } - } - - public event PropertyChangedEventHandler PropertyChanged; - - protected virtual void OnPropertyChanged([CallerMemberName] string propertyName = null) - { - PropertyChanged?.Invoke(this, new PropertyChangedEventArgs(propertyName)); - } - } - } -}
\ No newline at end of file diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43783.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43783.cs deleted file mode 100644 index 99d4fcae..00000000 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43783.cs +++ /dev/null @@ -1,30 +0,0 @@ -using Xamarin.Forms.CustomAttributes; -using Xamarin.Forms.Internals; - -namespace Xamarin.Forms.Controls.Issues -{ - [Preserve(AllMembers = true)] - [Issue(IssueTracker.Bugzilla, 43783, "[WP8.1] Most Device Styles do not render correctly in Windows Phone 8.1 (RT) applications", PlatformAffected.WinPhone)] - public class Bugzilla43783 : TestContentPage - { - protected override void Init() - { - Title = "Device"; - - Content = new StackLayout - { - Children = { - new Label { Margin = new Thickness(10), Text = "The Labels for Body, Caption, List Item, List Item Detail, and No Style should not all look the same. If all of them look the same, this test has failed."}, - new Label { Text = "Title style", Style = Device.Styles.TitleStyle }, - new Label { Text = "Subtitle style", Style = Device.Styles.SubtitleStyle }, - new Label { Text = "Body style", Style = Device.Styles.BodyStyle }, - new Label { Text = "Caption style", Style = Device.Styles.CaptionStyle }, - new Label { Text = "List item text style", Style = Device.Styles.ListItemTextStyle }, - new Label { Text = "List item detail text style", Style = Device.Styles.ListItemDetailTextStyle }, - new Label { Text = "No style" } - } - }; - } - - } -}
\ No newline at end of file diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43867.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43867.cs deleted file mode 100644 index 938200c0..00000000 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43867.cs +++ /dev/null @@ -1,49 +0,0 @@ -using Xamarin.Forms.CustomAttributes; -using Xamarin.Forms.Internals; -using Xamarin.Forms.PlatformConfiguration; -using Xamarin.Forms.PlatformConfiguration.AndroidSpecific; - -#if UITEST -using Xamarin.UITest; -using NUnit.Framework; -#endif - -namespace Xamarin.Forms.Controls.Issues -{ - [Preserve(AllMembers = true)] - [Issue(IssueTracker.Bugzilla, 43867, "Numeric keyboard shows text / default keyboard when back button is hit", PlatformAffected.Android)] - public class Bugzilla43867 : TestContentPage // or TestMasterDetailPage, etc ... - { - protected override void Init() - { - Application.Current.On<Android>().UseWindowSoftInputModeAdjust(WindowSoftInputModeAdjust.Resize); - - Content = new StackLayout - { - Spacing = 10, - VerticalOptions = LayoutOptions.Center, - Children = - { - new Label - { - Text = "Focus and unfocus each element 10 times using the Back button. Observe that the soft keyboard does not show different characters while hiding. Now repeat the test by tapping off of the element." - }, - new Entry - { - WidthRequest = 250, - HeightRequest = 50, - BackgroundColor = Color.AntiqueWhite, - Keyboard = Keyboard.Numeric - }, - new Editor - { - WidthRequest = 250, - HeightRequest = 50, - BackgroundColor = Color.BurlyWood, - Keyboard = Keyboard.Numeric - } - } - }; - } - } -}
\ No newline at end of file diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43941.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43941.cs deleted file mode 100644 index b69e968a..00000000 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla43941.cs +++ /dev/null @@ -1,136 +0,0 @@ -using System; -using System.Collections.Generic; -using Xamarin.Forms.CustomAttributes; -using Xamarin.Forms.Internals; -using System.Threading; - -#if UITEST -using Xamarin.UITest; -using NUnit.Framework; -#endif - -namespace Xamarin.Forms.Controls.Issues -{ - [Preserve(AllMembers = true)] - [Issue(IssueTracker.Bugzilla, 43941, "Memory leak with ListView's RecycleElement on iOS", PlatformAffected.iOS)] - public class Bugzilla43941 : TestNavigationPage - { - protected override void Init() - { - PushAsync(new LandingPage43941()); - } - -#if UITEST && __IOS__ - [Test] - public void Bugzilla43941Test() - { - for (var n = 0; n < 10; n++) - { - RunningApp.WaitForElement(q => q.Marked("Push")); - RunningApp.Tap(q => q.Marked("Push")); - - RunningApp.WaitForElement(q => q.Marked("ListView")); - RunningApp.Back(); - } - - // At this point, the counter can be any value, but it's most likely not zero. - // Invoking GC once is enough to clean up all garbage data and set counter to zero - RunningApp.WaitForElement(q => q.Marked("GC")); - RunningApp.Tap(q => q.Marked("GC")); - - RunningApp.WaitForElement(q => q.Marked("Counter: 0")); - } -#endif - } - - [Preserve(AllMembers = true)] - public class ContentPage43941 : ContentPage - { - public ContentPage43941() - { - Interlocked.Increment(ref LandingPage43941.Counter); - System.Diagnostics.Debug.WriteLine("Page: " + LandingPage43941.Counter); - - var list = new List<int>(); - for (var i = 0; i < 30; i++) - list.Add(i); - - Title = "ContentPage43941"; - Content = new ListView - { - HasUnevenRows = true, - ItemsSource = list, - AutomationId = "ListView" - }; - } - - ~ContentPage43941() - { - Interlocked.Decrement(ref LandingPage43941.Counter); - System.Diagnostics.Debug.WriteLine("Page: " + LandingPage43941.Counter); - } - } - - [Preserve(AllMembers = true)] - public class LandingPage43941 : ContentPage - { - public static int Counter; - public Label Label; - - public LandingPage43941() - { - Label = new Label - { - Text = "Counter: " + Counter, - HorizontalTextAlignment = TextAlignment.Center, - VerticalTextAlignment = TextAlignment.Center - }; - - Content = new StackLayout - { - Orientation = StackOrientation.Vertical, - HorizontalOptions = LayoutOptions.Center, - VerticalOptions = LayoutOptions.Center, - Spacing = 15, - Children = - { - new Label - { - Text = "Click Push to show a ListView. When you hit the Back button, Counter will show the number of pages that have not been finalized yet." - + " If you click GC, the counter should be 0." - }, - Label, - new Button - { - Text = "GC", - AutomationId = "GC", - Command = new Command(o => - { - GC.Collect(); - GC.WaitForPendingFinalizers(); - GC.Collect(); - Label.Text = "Counter: " + Counter; - }) - }, - new Button - { - Text = "Push", - AutomationId = "Push", - Command = new Command(async o => - { - await Navigation.PushAsync(new ContentPage43941()); - }) - } - } - }; - } - - protected override void OnAppearing() - { - base.OnAppearing(); - - if (Label != null) - Label.Text = "Counter: " + Counter; - } - } -}
\ No newline at end of file diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44166.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44166.cs index 85c168c2..e38da023 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44166.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla44166.cs @@ -49,13 +49,7 @@ namespace Xamarin.Forms.Controls.Issues Debug.WriteLine($">>>>>>>> Post-GC, {_44166NavContent.Counter} {nameof(_44166NavContent)} allocated"); } - int success = 0; - - //some reason there's always 1 instance around i don't know why yet, if we were leaking it should be 8 here - if (Device.RuntimePlatform == Device.macOS) - success = 4; - - if (_44166NavContent.Counter + _44166Detail.Counter + _44166Master.Counter + _44166MDP.Counter == success) + if (_44166NavContent.Counter + _44166Detail.Counter + _44166Master.Counter + _44166MDP.Counter == 0) { label.Text = "Success"; } @@ -190,7 +184,7 @@ namespace Xamarin.Forms.Controls.Issues { public static int Counter; - public _44166NavContent() + public _44166NavContent () { Interlocked.Increment(ref Counter); Debug.WriteLine($"++++++++ {nameof(_44166NavContent)} constructor, {Counter} allocated"); @@ -204,7 +198,7 @@ namespace Xamarin.Forms.Controls.Issues }; } - ~_44166NavContent() + ~_44166NavContent () { Interlocked.Decrement(ref Counter); Debug.WriteLine($"-------- {nameof(_44166NavContent)} destructor, {Counter} allocated"); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue198.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue198.cs index 540ab59f..b0e30112 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue198.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue198.cs @@ -64,10 +64,10 @@ namespace Xamarin.Forms.Controls.Issues RunningApp.Screenshot ("Clicked Leave"); RunningApp.WaitForElement (q => q.Marked ("Bug Repro's")); -#if !__MACOS__ + RunningApp.ClearText(q => q.Raw("* marked:'SearchBarGo'")); RunningApp.EnterText(q => q.Raw("* marked:'SearchBarGo'"), "G198"); -#endif + RunningApp.Tap (q => q.Marked ("SearchButton")); RunningApp.Screenshot ("Navigate into gallery again"); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue206.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue206.cs index 61f63720..cb3831a0 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue206.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue206.cs @@ -37,11 +37,9 @@ namespace Xamarin.Forms.Controls.Issues RunningApp.Screenshot ("All elements exist"); -#if !__MACOS__ var scrollRect = RunningApp.Query (q => q.Raw ("* index:0"))[0].Rect; Xamarin.Forms.Core.UITests.Gestures.ScrollForElement (RunningApp, "* marked:'9'", new Xamarin.Forms.Core.UITests.Drag (scrollRect, Xamarin.Forms.Core.UITests.Drag.Direction.BottomToTop, Xamarin.Forms.Core.UITests.Drag.DragLength.Long)); RunningApp.Screenshot ("I see 9"); -#endif RunningApp.Tap (q => q.Marked ("9")); RunningApp.WaitForNoElement (q => q.Marked ("9")); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2272.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2272.cs index b0efc276..d084de9c 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2272.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2272.cs @@ -31,9 +31,6 @@ namespace Xamarin.Forms.Controls.Issues #if UITEST [Test] -#if __MACOS__ - [Ignore("EnterText problems in UITest Desktop")] -#endif public void TestFocusIsOnTheEndAfterSettingText () { RunningApp.Tap (c => c.Marked ("userNameEditorEmptyString")); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2411.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2411.cs index 8b76e796..f3237973 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2411.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2411.cs @@ -31,9 +31,6 @@ namespace Xamarin.Forms.Controls.Issues #if __ANDROID__ [Ignore("Appearing event is tied to virtualization in TabbedPage for Material")] #endif -#if __MACOS__ - [Ignore("ScrollTo not implemented on MacOS")] -#endif [Issue(IssueTracker.Github, 2411, "ScrollToPosition.MakeVisible not called every time TabbedPage", PlatformAffected.Android)] public void Issue2411ScrollToPositionMakeVisible() { @@ -60,9 +57,6 @@ namespace Xamarin.Forms.Controls.Issues [Test] [Issue(IssueTracker.Github, 2411, "ScrollToPosition.End crashing in TabbedPage", PlatformAffected.Android)] -#if __MACOS__ - [Ignore("ScrollTo not implemented on MacOS")] -#endif public void Issue2411ScrollToPositionEndCrash() { RunningApp.Tap(q => q.Marked("Crash in ScrollToPosition.End")); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs index 1fda224f..6400a2ac 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs @@ -1,5 +1,8 @@ using System; +using System.Collections.Generic; +using System.Text; using System.Reflection; + using Xamarin.Forms.CustomAttributes; #if UITEST @@ -11,24 +14,18 @@ using Xamarin.UITest; namespace Xamarin.Forms.Controls { internal static class AppPaths - { - public static string ApkPath = "../../../Xamarin.Forms.ControlGallery.Android/bin/Debug/AndroidControlGallery.AndroidControlGallery-Signed.apk"; - - public static string MacOSPath = "../../../Xamarin.Forms.ControlGallery.MacOS/bin/Debug/Xamarin.Forms.ControlGallery.MacOS.app"; - - // Have to continue using the old BundleId for now; Test Cloud doesn't like - // when you change the BundleId - public static string BundleId = "com.xamarin.quickui.controlgallery"; + { + public static string ApkPath = "../../../Xamarin.Forms.ControlGallery.Android/bin/Debug/AndroidControlGallery.AndroidControlGallery-Signed.apk"; // Have to continue using the old BundleId for now; Test Cloud doesn't like // when you change the BundleId - public static string MacOSBundleId = "com.xamarin.xamarin-forms-controlgallery-macos"; - } + public static string BundleId = "com.xamarin.quickui.controlgallery"; + } #if UITEST internal static class AppSetup { - static IApp InitializeApp() + static IApp InitializeApp () { IApp app = null; #if __ANDROID__ @@ -38,13 +35,9 @@ namespace Xamarin.Forms.Controls #elif __IOS__ app = InitializeiOSApp(); - -#elif __MACOS__ - Xamarin.UITest.Desktop.TestAgent.Start(); - app = InitializeMacOSApp(); #endif if (app == null) - throw new NullReferenceException("App was not initialized."); + throw new NullReferenceException ("App was not initialized."); // Wrap the app in ScreenshotConditional so it only takes screenshots if the SCREENSHOTS symbol is specified return new ScreenshotConditionalApp(app); @@ -76,38 +69,22 @@ namespace Xamarin.Forms.Controls } #endif -#if __MACOS__ - static IApp InitializeMacOSApp() + public static void NavigateToIssue (Type type, IApp app) { - // Running on a device - var configurator = new Xamarin.UITest.Desktop.CocoaAppConfigurator(); - var app = configurator - //.AppBundle("/Users/rmarinho/Xamarin/Xamarin.Forms/Xamarin.Forms.ControlGallery.MacOS/bin/Debug/Xamarin.Forms.ControlGallery.MacOS.app") - .AppBundle(AppPaths.MacOSPath) - .BundleId(AppPaths.MacOSBundleId) - .StartApp(); - return new Xamarin.Forms.Core.macOS.UITests.MacOSApp(app); - } -#endif - - public static void NavigateToIssue(Type type, IApp app) - { - var typeIssueAttribute = type.GetTypeInfo().GetCustomAttribute<IssueAttribute>(); + var typeIssueAttribute = type.GetTypeInfo ().GetCustomAttribute <IssueAttribute> (); string cellName = ""; - if (typeIssueAttribute.IssueTracker.ToString() != "None" && + if (typeIssueAttribute.IssueTracker.ToString () != "None" && typeIssueAttribute.IssueNumber != 1461 && - typeIssueAttribute.IssueNumber != 342) - { - cellName = typeIssueAttribute.IssueTracker.ToString().Substring(0, 1) + typeIssueAttribute.IssueNumber.ToString(); - } - else { + typeIssueAttribute.IssueNumber != 342) { + cellName = typeIssueAttribute.IssueTracker.ToString ().Substring(0, 1) + typeIssueAttribute.IssueNumber.ToString (); + } else { cellName = typeIssueAttribute.Description; } int maxAttempts = 2; int attempts = 0; - + while (attempts < maxAttempts) { attempts += 1; @@ -174,20 +151,17 @@ namespace Xamarin.Forms.Controls } } - public static IApp Setup(Type pageType = null) + public static IApp Setup (Type pageType = null) { IApp runningApp = null; - try - { - runningApp = InitializeApp(); + try { + runningApp = InitializeApp (); + } catch (Exception e) { + Assert.Inconclusive ($"App did not start for some reason: {e}"); } - catch (Exception e) - { - Assert.Inconclusive($"App did not start for some reason: {e}"); - } - + if (pageType != null) - NavigateToIssue(pageType, runningApp); + NavigateToIssue (pageType, runningApp); return runningApp; } @@ -259,10 +233,10 @@ namespace Xamarin.Forms.Controls protected virtual bool Isolate => false; #endif - protected TestPage() + protected TestPage () { #if APP - Init(); + Init (); #endif } @@ -293,7 +267,7 @@ namespace Xamarin.Forms.Controls } #endif - protected abstract void Init(); + protected abstract void Init (); } @@ -305,16 +279,16 @@ namespace Xamarin.Forms.Controls protected virtual bool Isolate => false; #endif - protected TestContentPage() + protected TestContentPage () { #if APP - Init(); + Init (); #endif } #if UITEST [SetUp] - public void Setup() + public void Setup () { if (Isolate) { @@ -339,7 +313,7 @@ namespace Xamarin.Forms.Controls } #endif - protected abstract void Init(); + protected abstract void Init (); } public abstract class TestCarouselPage : CarouselPage @@ -350,10 +324,10 @@ namespace Xamarin.Forms.Controls protected virtual bool Isolate => false; #endif - protected TestCarouselPage() + protected TestCarouselPage () { #if APP - Init(); + Init (); #endif } @@ -384,7 +358,7 @@ namespace Xamarin.Forms.Controls } #endif - protected abstract void Init(); + protected abstract void Init (); } public abstract class TestMasterDetailPage : MasterDetailPage @@ -395,10 +369,10 @@ namespace Xamarin.Forms.Controls protected virtual bool Isolate => false; #endif - protected TestMasterDetailPage() + protected TestMasterDetailPage () { #if APP - Init(); + Init (); #endif } @@ -429,7 +403,7 @@ namespace Xamarin.Forms.Controls } #endif - protected abstract void Init(); + protected abstract void Init (); } public abstract class TestNavigationPage : NavigationPage @@ -440,10 +414,10 @@ namespace Xamarin.Forms.Controls protected virtual bool Isolate => false; #endif - protected TestNavigationPage() + protected TestNavigationPage () { #if APP - Init(); + Init (); #endif } @@ -474,7 +448,7 @@ namespace Xamarin.Forms.Controls } #endif - protected abstract void Init(); + protected abstract void Init (); } public abstract class TestTabbedPage : TabbedPage @@ -485,10 +459,10 @@ namespace Xamarin.Forms.Controls protected virtual bool Isolate => false; #endif - protected TestTabbedPage() + protected TestTabbedPage () { #if APP - Init(); + Init (); #endif } @@ -519,7 +493,7 @@ namespace Xamarin.Forms.Controls } #endif - protected abstract void Init(); + protected abstract void Init (); } } diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems index b8e45b44..fab19248 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems @@ -51,7 +51,6 @@ <Compile Include="$(MSBuildThisFileDirectory)Bugzilla31964.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla32033.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla32034.cs" /> - <Compile Include="$(MSBuildThisFileDirectory)Bugzilla32206.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla32776.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla32842.xaml.cs"> <DependentUpon>Bugzilla32842.xaml</DependentUpon> @@ -127,7 +126,6 @@ <Compile Include="$(MSBuildThisFileDirectory)Bugzilla41415.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla41418.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla41424.cs" /> - <Compile Include="$(MSBuildThisFileDirectory)Bugzilla41619.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla42069.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla42069_Page.xaml.cs"> <DependentUpon>Bugzilla42069_Page.xaml</DependentUpon> @@ -141,11 +139,8 @@ <Compile Include="$(MSBuildThisFileDirectory)Bugzilla43313.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla43469.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla43516.cs" /> - <Compile Include="$(MSBuildThisFileDirectory)Bugzilla43941.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla43663.cs" /> - <Compile Include="$(MSBuildThisFileDirectory)Bugzilla43867.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla43735.cs" /> - <Compile Include="$(MSBuildThisFileDirectory)Bugzilla43783.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla44453.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla51536.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla44944.cs" /> |