summaryrefslogtreecommitdiff
path: root/Xamarin.Forms.Platform.iOS
diff options
context:
space:
mode:
authorSamantha Houts <samhouts@users.noreply.github.com>2017-03-24 11:02:59 (GMT)
committerRui Marinho <me@ruimarinho.net>2017-03-24 11:02:59 (GMT)
commiteea0bdcc6e3fdfcf3229abedac32204e47602f60 (patch)
treed6cadd11b85585adc33ea4c5d0948e884c3f15a3 /Xamarin.Forms.Platform.iOS
parent79ecf97d92331c790b5ba5c99f453607260f40cb (diff)
downloadxamarin-forms-eea0bdcc6e3fdfcf3229abedac32204e47602f60.zip
xamarin-forms-eea0bdcc6e3fdfcf3229abedac32204e47602f60.tar.gz
xamarin-forms-eea0bdcc6e3fdfcf3229abedac32204e47602f60.tar.bz2
[iOS] Don't skip row height estimation for grouped lists (#838)
* Nest bugzilla 51536 classes for less pollution * Add repro for 53834 * [iOS] Don't skip row height estimation for grouped lists
Diffstat (limited to 'Xamarin.Forms.Platform.iOS')
-rw-r--r--Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs5
1 files changed, 3 insertions, 2 deletions
diff --git a/Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs b/Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs
index b4333c6..99a1066 100644
--- a/Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs
+++ b/Xamarin.Forms.Platform.iOS/Renderers/ListViewRenderer.cs
@@ -644,10 +644,11 @@ namespace Xamarin.Forms.Platform.iOS
return DefaultRowHeight;
}
- // We're going to base our estimate off of the first cell
+ // We're going to base our estimate off of the first cell
var firstCell = templatedItems.First();
- if (firstCell.Height > 0)
+ // Let's skip this optimization for grouped lists. It will likely cause more trouble than it's worth.
+ if (firstCell.Height > 0 && !List.IsGroupingEnabled)
{
// Seems like we've got cells which already specify their height; since the heights are known,
// we don't need to use estimatedRowHeight at all; zero will disable it and use the known heights