summaryrefslogtreecommitdiff
path: root/Xamarin.Forms.Platform.WinRT
diff options
context:
space:
mode:
authorPaul DiPietro <paul.dipietro@me.com>2016-04-12 19:30:27 (GMT)
committerJason Smith <jason.smith@xamarin.com>2016-04-12 19:30:27 (GMT)
commitb42460c2c32a5b24a3f344121876534e61399140 (patch)
treec65a4dc15ae21c267a2d4ee60d5a40a532be10c5 /Xamarin.Forms.Platform.WinRT
parent10f6c08ceb89b8b302cb41dd6fe7b1ccf70884ba (diff)
downloadxamarin-forms-b42460c2c32a5b24a3f344121876534e61399140.zip
xamarin-forms-b42460c2c32a5b24a3f344121876534e61399140.tar.gz
xamarin-forms-b42460c2c32a5b24a3f344121876534e61399140.tar.bz2
Enable CS1998 warnings as errors (#65)
Diffstat (limited to 'Xamarin.Forms.Platform.WinRT')
-rw-r--r--Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs2
-rw-r--r--Xamarin.Forms.Platform.WinRT/NavigationPageRenderer.cs2
-rw-r--r--Xamarin.Forms.Platform.WinRT/Platform.cs2
-rw-r--r--Xamarin.Forms.Platform.WinRT/Xamarin.Forms.Platform.WinRT.csproj4
4 files changed, 8 insertions, 2 deletions
diff --git a/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs b/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs
index 05e3f93..bbd101f 100644
--- a/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs
+++ b/Xamarin.Forms.Platform.WinRT/ListViewRenderer.cs
@@ -278,7 +278,9 @@ namespace Xamarin.Forms.Platform.WinRT
ScrollTo(til.ListProxy.ProxiedEnumerable, til.ListProxy[0], ScrollToPosition.Start, true, true);
}
+#pragma warning disable 1998 // considered for removal
async void ScrollTo(object group, object item, ScrollToPosition toPosition, bool shouldAnimate, bool includeGroup = false, bool previouslyFailed = false)
+#pragma warning restore 1998
{
ScrollViewer viewer = GetScrollViewer();
if (viewer == null)
diff --git a/Xamarin.Forms.Platform.WinRT/NavigationPageRenderer.cs b/Xamarin.Forms.Platform.WinRT/NavigationPageRenderer.cs
index 1e48d7e..8bcf207 100644
--- a/Xamarin.Forms.Platform.WinRT/NavigationPageRenderer.cs
+++ b/Xamarin.Forms.Platform.WinRT/NavigationPageRenderer.cs
@@ -496,7 +496,9 @@ namespace Xamarin.Forms.Platform.WinRT
(this as ITitleProvider).BarForegroundBrush = GetBarForegroundBrush();
}
+#pragma warning disable 1998 // considered for removal
async void UpdateTitleOnParents()
+#pragma warning restore 1998
{
if (Element == null)
return;
diff --git a/Xamarin.Forms.Platform.WinRT/Platform.cs b/Xamarin.Forms.Platform.WinRT/Platform.cs
index 012dd2c..4d7309d 100644
--- a/Xamarin.Forms.Platform.WinRT/Platform.cs
+++ b/Xamarin.Forms.Platform.WinRT/Platform.cs
@@ -493,7 +493,9 @@ namespace Xamarin.Forms.Platform.WinRT
return GetCommandBarAsync();
}
+#pragma warning disable 1998 // considered for removal
async Task<CommandBar> GetCommandBarAsync()
+#pragma warning restore 1998
{
#if !WINDOWS_UWP
return _page.BottomAppBar as CommandBar;
diff --git a/Xamarin.Forms.Platform.WinRT/Xamarin.Forms.Platform.WinRT.csproj b/Xamarin.Forms.Platform.WinRT/Xamarin.Forms.Platform.WinRT.csproj
index 34a62fa..7f41e8b 100644
--- a/Xamarin.Forms.Platform.WinRT/Xamarin.Forms.Platform.WinRT.csproj
+++ b/Xamarin.Forms.Platform.WinRT/Xamarin.Forms.Platform.WinRT.csproj
@@ -37,7 +37,7 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
- <NoWarn>1998</NoWarn>
+ <NoWarn></NoWarn>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>pdbonly</DebugType>
@@ -47,7 +47,7 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
- <NoWarn>1998</NoWarn>
+ <NoWarn></NoWarn>
</PropertyGroup>
<ItemGroup>
<!-- A reference to the entire .NET Framework is automatically included -->