Refactoring Renderers

 - Apply Dispose pattern
 - Handle IBatchable interface on VisualElementRenderer
 - Make pair Event subscribe/unsubscribe

Change-Id: I65018652132494722d52b1d62798f1cf1f6fc6fd

1 files changed, 16 insertions, 10 deletions

diff --git a/Xamarin.Forms.Platform.Tizen/Renderers/ScrollViewRenderer.cs b/Xamarin.Forms.Platform.Tizen/Renderers/ScrollViewRenderer.cs
index 76ce555e..0168d2df 100644
--- a/Xamarin.Forms.Platform.Tizen/Renderers/ScrollViewRenderer.cs
+++ b/Xamarin.Forms.Platform.Tizen/Renderers/ScrollViewRenderer.cs
@@ -27,20 +27,18 @@ namespace Xamarin.Forms.Platform.Tizen
 		{
 			if (Control == null)
 			{
-				var scrollView = new Scroller(Forms.Context.MainWindow);
-				SetNativeControl(scrollView);
+				SetNativeControl(new Scroller(Forms.Context.MainWindow));
+				Control.Scrolled += OnScrolled;
 			}
 
 			if (e.OldElement != null)
 			{
-				Control.Scrolled -= ScrollViewScrolledHandler;
-				(e.OldElement as IScrollViewController).ScrollToRequested -= ScrollRequestHandler;
+				(e.OldElement as IScrollViewController).ScrollToRequested -= OnScrollRequested;
 			}
 
 			if (e.NewElement != null)
 			{
-				Control.Scrolled += ScrollViewScrolledHandler;
-				(e.NewElement as IScrollViewController).ScrollToRequested += ScrollRequestHandler;
+				(e.NewElement as IScrollViewController).ScrollToRequested += OnScrollRequested;
 			}
 
 			UpdateAll();
@@ -50,9 +48,17 @@ namespace Xamarin.Forms.Platform.Tizen
 
 		protected override void Dispose(bool disposing)
 		{
-			if (null != Element)
+			if (disposing)
 			{
-				(Element as IScrollViewController).ScrollToRequested -= ScrollRequestHandler;
+				if (null != Element)
+				{
+					(Element as IScrollViewController).ScrollToRequested -= OnScrollRequested;
+				}
+
+				if (Control != null)
+				{
+					Control.Scrolled -= OnScrolled;
+				}
 			}
 
 			base.Dispose(disposing);
@@ -129,13 +135,13 @@ namespace Xamarin.Forms.Platform.Tizen
 			base.OnElementPropertyChanged(sender, e);
 		}
 
-		void ScrollViewScrolledHandler(object sender, EventArgs e)
+		void OnScrolled(object sender, EventArgs e)
 		{
 			var region = Control.CurrentRegion;
 			((IScrollViewController)Element).SetScrolledPosition(region.X, region.Y);
 		}
 
-		void ScrollRequestHandler(object sender, ScrollToRequestedEventArgs e)
+		void OnScrollRequested(object sender, ScrollToRequestedEventArgs e)
 		{
 			var x = e.ScrollX;
 			var y = e.ScrollY;