diff options
| author | E.Z. Hart <hartez@users.noreply.github.com> | 2016-09-21 16:04:36 -0600 |
|---|---|---|
| committer | Rui Marinho <me@ruimarinho.net> | 2016-09-21 23:04:36 +0100 |
| commit | 74cb5c4a97dcb123eb471f6b1dffa1267d0305aa (patch) | |
| tree | d463831cc17cba1ddfb4ba977cdc6054597ed61a /Xamarin.Forms.Platform.Android/VisualElementTracker.cs | |
| parent | d4efe0a37ea87967e38a7d0325df8d84e1c125fc (diff) | |
| download | xamarin-forms-74cb5c4a97dcb123eb471f6b1dffa1267d0305aa.tar.gz xamarin-forms-74cb5c4a97dcb123eb471f6b1dffa1267d0305aa.tar.bz2 xamarin-forms-74cb5c4a97dcb123eb471f6b1dffa1267d0305aa.zip | |
Implement dispose pattern correctly to support derived classes (#364)
Diffstat (limited to 'Xamarin.Forms.Platform.Android/VisualElementTracker.cs')
| -rw-r--r-- | Xamarin.Forms.Platform.Android/VisualElementTracker.cs | 24 |
1 files changed, 17 insertions, 7 deletions
diff --git a/Xamarin.Forms.Platform.Android/VisualElementTracker.cs b/Xamarin.Forms.Platform.Android/VisualElementTracker.cs index 2b9815d3..7ade4596 100644 --- a/Xamarin.Forms.Platform.Android/VisualElementTracker.cs +++ b/Xamarin.Forms.Platform.Android/VisualElementTracker.cs @@ -45,18 +45,28 @@ namespace Xamarin.Forms.Platform.Android public void Dispose() { + Dispose(true); + GC.SuppressFinalize(this); + } + + protected virtual void Dispose(bool disposing) + { if (_disposed) return; - _disposed = true; - SetElement(_element, null); + _disposed = true; - if (_renderer != null) + if (disposing) { - _renderer.ElementChanged -= RendererOnElementChanged; - _renderer.ViewGroup.RemoveOnAttachStateChangeListener(AttachTracker.Instance); - _renderer = null; - _context = null; + SetElement(_element, null); + + if (_renderer != null) + { + _renderer.ElementChanged -= RendererOnElementChanged; + _renderer.ViewGroup.RemoveOnAttachStateChangeListener(AttachTracker.Instance); + _renderer = null; + _context = null; + } } } |