diff options
author | Paul DiPietro <paul.dipietro@me.com> | 2016-04-12 12:30:27 -0700 |
---|---|---|
committer | Jason Smith <jason.smith@xamarin.com> | 2016-04-12 12:30:27 -0700 |
commit | b42460c2c32a5b24a3f344121876534e61399140 (patch) | |
tree | c65a4dc15ae21c267a2d4ee60d5a40a532be10c5 /Xamarin.Forms.Controls.Issues | |
parent | 10f6c08ceb89b8b302cb41dd6fe7b1ccf70884ba (diff) | |
download | xamarin-forms-b42460c2c32a5b24a3f344121876534e61399140.tar.gz xamarin-forms-b42460c2c32a5b24a3f344121876534e61399140.tar.bz2 xamarin-forms-b42460c2c32a5b24a3f344121876534e61399140.zip |
Enable CS1998 warnings as errors (#65)
Diffstat (limited to 'Xamarin.Forms.Controls.Issues')
8 files changed, 22 insertions, 2 deletions
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27350.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27350.cs index e4899358..a705fdd0 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27350.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla27350.cs @@ -30,7 +30,9 @@ namespace Xamarin.Forms.Controls public ObservableCollection<RecipeGroup> RecipeGroups { get; set; } +#pragma warning disable 1998 // considered for removal public async Task LoadRecipesAsync () +#pragma warning restore 1998 { var groups = new ObservableCollection<RecipeGroup> (); groups.Add (new RecipeGroup { Title = "Teste 1" }); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31114.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31114.cs index 8f56fdbb..16d4afa4 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31114.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla31114.cs @@ -377,7 +377,9 @@ namespace Xamarin.Forms.Controls } } +#pragma warning disable 1998 // considered for removal async void FastCompleteForCmd(object sender) +#pragma warning restore 1998 { try { diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39821.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39821.cs index ab998d0a..4a3ed1d5 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39821.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla39821.cs @@ -59,7 +59,9 @@ namespace Xamarin.Forms.Controls.Issues }; } +#pragma warning disable 1998 // considered for removal async Task CheckTranslateRunning(BoxView box) +#pragma warning restore 1998 { Debug.WriteLine(box.AnimationIsRunning("TranslateTo") ? "Translate is running" : "Translate is not running"); } @@ -84,18 +86,24 @@ namespace Xamarin.Forms.Controls.Issues await box.RelRotateTo(360); } +#pragma warning disable 1998 // considered for removal async Task Cancel(BoxView box) +#pragma warning restore 1998 { box.AbortAnimation("animate"); box.AbortAnimation("kinetic"); } +#pragma warning disable 1998 // considered for removal async Task Animate(BoxView box) +#pragma warning restore 1998 { box.Animate("animate", d => d, d => { }, 100, 1); } +#pragma warning disable 1998 // considered for removal async Task Kinetic(BoxView box) +#pragma warning restore 1998 { var resultList = new List<Tuple<double, double>>(); diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs index 2ad70257..edb66831 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1461.cs @@ -278,7 +278,7 @@ namespace Xamarin.Forms.Controls try { IsPresented = !IsPresented; } catch (InvalidOperationException ex) { - DisplayAlert ("Error", ex.Message, "ok"); + await DisplayAlert ("Error", ex.Message, "ok"); } } diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1758.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1758.cs index 7cb392f1..ebd9f649 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1758.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1758.cs @@ -63,7 +63,7 @@ namespace Xamarin.Forms.Controls // Comment this delay out to see the bug // await Task.Delay(500); - _button.LayoutTo(new Rectangle(100, 100, 100, 100), 1000); + await _button.LayoutTo(new Rectangle(100, 100, 100, 100), 1000); } } }
\ No newline at end of file diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1875.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1875.cs index 0391ef4d..09e5eca4 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1875.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1875.cs @@ -92,7 +92,9 @@ namespace Xamarin.Forms.Controls } } +#pragma warning disable 1998 // considered for removal public async Task LoadData (int start, int numberOfRecords) +#pragma warning restore 1998 { IsLoading = true; for (int counter = 0; counter < numberOfRecords; counter++) diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2357.xaml.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2357.xaml.cs index 54c8e0b3..99b85b73 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2357.xaml.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2357.xaml.cs @@ -210,7 +210,9 @@ namespace Xamarin.Forms.Controls _mainMenuItems = new ObservableCollection<MainMenuItem> (Enumerable.Empty<MainMenuItem> ()); } +#pragma warning disable 1998 // considered for removal public async Task InitializeAsync () +#pragma warning restore 1998 { var items = new List<MainMenuItem> (); items.Add (new MainMenuItem { diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3319.xaml.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3319.xaml.cs index d2f54cd0..04593195 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3319.xaml.cs +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue3319.xaml.cs @@ -56,7 +56,9 @@ namespace Xamarin.Forms.Controls } +#pragma warning disable 1998 // considered for removal public async void OnDelete (object sender, EventArgs e) +#pragma warning restore 1998 { var mi = ((MenuItem)sender); if (mi.CommandParameter == null) @@ -105,7 +107,9 @@ namespace Xamarin.Forms.Controls } } +#pragma warning disable 1998 // considered for removal public async Task ExecuteFavoritesCommand () +#pragma warning restore 1998 { if (IsBusy) return; |