summaryrefslogtreecommitdiff
path: root/Xamarin.Forms.Controls.Issues
diff options
context:
space:
mode:
authoradrianknight89 <adrianknight89@outlook.com>2017-02-06 05:59:11 -0600
committerRui Marinho <me@ruimarinho.net>2017-02-06 11:59:11 +0000
commit28237b7b27ef318b2c811e9829c2442613c42feb (patch)
tree78a91ae8be6dd37b03c2f345b54c07472d7f58b9 /Xamarin.Forms.Controls.Issues
parentc29403ac31aa689df97aa1d99c95e25d93c428c2 (diff)
downloadxamarin-forms-28237b7b27ef318b2c811e9829c2442613c42feb.tar.gz
xamarin-forms-28237b7b27ef318b2c811e9829c2442613c42feb.tar.bz2
xamarin-forms-28237b7b27ef318b2c811e9829c2442613c42feb.zip
[iOS/Android] Handle item selection highlight when ListView cell is tapped erratically (#520)
* Fix multi tap selection highlight * added sample code * add ios fix
Diffstat (limited to 'Xamarin.Forms.Controls.Issues')
-rw-r--r--Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla32956.cs48
-rw-r--r--Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems1
2 files changed, 49 insertions, 0 deletions
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla32956.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla32956.cs
new file mode 100644
index 00000000..b1baafe5
--- /dev/null
+++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla32956.cs
@@ -0,0 +1,48 @@
+using System.Collections.Generic;
+using Xamarin.Forms.CustomAttributes;
+using Xamarin.Forms.Internals;
+using System.Threading.Tasks;
+
+#if UITEST
+using Xamarin.UITest;
+using NUnit.Framework;
+#endif
+
+namespace Xamarin.Forms.Controls
+{
+ [Preserve(AllMembers = true)]
+ [Issue(IssueTracker.Bugzilla, 32956, "Setting ListView.SelectedItem to null does not remove list item highlight when list item is tapped multiple times quickly", PlatformAffected.Android | PlatformAffected.iOS)]
+ public class Bugzilla32956 : TestNavigationPage
+ {
+ protected override void Init()
+ {
+ var list = new List<int>();
+ for(var i=0; i<10; i++)
+ list.Add(i);
+
+ var listView = new ListView
+ {
+ ItemsSource = list
+ };
+ listView.ItemSelected += async (sender, args) =>
+ {
+ if (args.SelectedItem == null)
+ return;
+
+ await Task.Delay(1000);
+ await Navigation.PushAsync(new ContentPage());
+ };
+
+ var contentPage = new ContentPage
+ {
+ Content = listView
+ };
+ contentPage.Appearing += (sender, args) =>
+ {
+ listView.SelectedItem = null;
+ };
+
+ PushAsync(contentPage);
+ }
+ }
+} \ No newline at end of file
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
index 859f3c08..e55302a9 100644
--- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
+++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
@@ -58,6 +58,7 @@
<SubType>Code</SubType>
</Compile>
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla32847.cs" />
+ <Compile Include="$(MSBuildThisFileDirectory)Bugzilla32956.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla33248.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla33268.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla33612.cs" />