Adding some restart logic to the UI tests if navigation fails (#550)

1 files changed, 55 insertions, 18 deletions

diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs
index 0439c791..32a88642 100644
--- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs
+++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/TestPages/TestPages.cs
@@ -82,15 +82,22 @@ namespace Xamarin.Forms.Controls
 				cellName = typeIssueAttribute.Description;
 			}
 
-			try
+			int maxAttempts = 2;
+			int attempts = 0;
+			
+			while (attempts < maxAttempts)
 			{
-				// Attempt the direct way of navigating to the test page
-#if __ANDROID__
+				attempts += 1;
 
-				if (bool.Parse((string)app.Invoke("NavigateToTest", cellName)))
+				try
 				{
-					return;
-				}
+					// Attempt the direct way of navigating to the test page
+#if __ANDROID__
+
+					if (bool.Parse((string)app.Invoke("NavigateToTest", cellName)))
+					{
+						return;
+					}
 #endif
 #if __IOS__
 				if (bool.Parse(app.Invoke("navigateToTest:", cellName).ToString()))
@@ -98,20 +105,50 @@ namespace Xamarin.Forms.Controls
 					return;
 				}
 #endif
-			}
-			catch (Exception ex)
-			{
-				System.Diagnostics.Debug.WriteLine($"Could not directly invoke test, using UI navigation. {ex}");
-			}
-			
-			// Fall back to the "manual" navigation method
-			app.Tap (q => q.Button ("Go to Test Cases"));
-			app.WaitForElement (q => q.Raw ("* marked:'TestCasesIssueList'"));
+				}
+				catch (Exception ex)
+				{
+					var debugMessage = $"Could not directly invoke test; using UI navigation instead. {ex}";
+
+					System.Diagnostics.Debug.WriteLine(debugMessage);
+					Console.WriteLine(debugMessage);
+				}
+
+				try
+				{
+					// Fall back to the "manual" navigation method
+					app.Tap(q => q.Button("Go to Test Cases"));
+					app.WaitForElement(q => q.Raw("* marked:'TestCasesIssueList'"));
+
+					app.EnterText(q => q.Raw("* marked:'SearchBarGo'"), cellName);
 
-			app.EnterText (q => q.Raw ("* marked:'SearchBarGo'"), cellName);
+					app.WaitForElement(q => q.Raw("* marked:'SearchButton'"));
+					app.Tap(q => q.Raw("* marked:'SearchButton'"));
 
-			app.WaitForElement (q => q.Raw ("* marked:'SearchButton'"));
-			app.Tap (q => q.Raw ("* marked:'SearchButton'"));
+					return;
+				}
+				catch (Exception ex)
+				{
+					var debugMessage = $"Both navigation methods failed. {ex}";
+
+					System.Diagnostics.Debug.WriteLine(debugMessage);
+					Console.WriteLine(debugMessage);
+
+					if (attempts < maxAttempts)
+					{
+						// Something has failed and we're stuck in a place where we can't navigate
+						// to the test. Usually this is because we're getting network/HTTP errors 
+						// communicating with the server on the device. So we'll try restarting the app.
+						RunningApp = InitializeApp();
+					}
+					else
+					{
+						// But if it's still not working after [maxAttempts], we've got assume this is a legit
+						// problem that restarting won't fix
+						throw;
+					}
+				}
+			}
 		}
 
 		public static IApp Setup (Type pageType = null)