summaryrefslogtreecommitdiff
path: root/Xamarin.Forms.Controls.Issues
diff options
context:
space:
mode:
authorRui Marinho <me@ruimarinho.net>2017-08-15 15:39:02 (GMT)
committerGitHub <noreply@github.com>2017-08-15 15:39:02 (GMT)
commit565973a42fc2b6a86dd50fbf2bf6d843b3c6f5e9 (patch)
tree41fee027de972cc4f76da2d6a312039aa813f82f /Xamarin.Forms.Controls.Issues
parentaf404c55296340d92c3ac4a7cdfdd445b1b06543 (diff)
downloadxamarin-forms-565973a42fc2b6a86dd50fbf2bf6d843b3c6f5e9.zip
xamarin-forms-565973a42fc2b6a86dd50fbf2bf6d843b3c6f5e9.tar.gz
xamarin-forms-565973a42fc2b6a86dd50fbf2bf6d843b3c6f5e9.tar.bz2
[Android] Fix missing shadow on Button fast renderer (#1034)
* [Android] Fix missing shadow on Button fast renderer * [Android] Fix z index on Loplipop * [Android] Make sure we don't hit NRE when updating background * [Android] Fix possible NRE on BackgroundTracker * [Android] Remove elevation fix * [Android] Set elevation in Android Views if needed * [Android] Add UITest for button on fast renderes * [Controls] New test for elevation with fast renderer button
Diffstat (limited to 'Xamarin.Forms.Controls.Issues')
-rw-r--r--Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ButtonFastRendererTest.cs43
-rw-r--r--Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems1
2 files changed, 44 insertions, 0 deletions
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ButtonFastRendererTest.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ButtonFastRendererTest.cs
new file mode 100644
index 0000000..4f76819
--- /dev/null
+++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/ButtonFastRendererTest.cs
@@ -0,0 +1,43 @@
+using System;
+using Xamarin.Forms.CustomAttributes;
+using Xamarin.Forms.Internals;
+
+#if UITEST
+using NUnit.Framework;
+using Xamarin.UITest;
+#endif
+
+namespace Xamarin.Forms.Controls.Issues
+{
+ [Preserve(AllMembers = true)]
+ [Issue(IssueTracker.None, 9999, "Button FastRenderers", PlatformAffected.All)]
+ public class ButtonFastRendererTest : TestContentPage
+ {
+ const string Running = "Running...";
+ const string Success = "Success";
+ const string Failure = "Failure";
+ const string btnId = "btnHello";
+ protected override void Init()
+ {
+ var label = new Label { Text = Running };
+ var img = new Image { Source = "cover1.jpg", HorizontalOptions = LayoutOptions.Center, VerticalOptions = LayoutOptions.Center };
+ var btn = new Button { AutomationId = btnId, Text = "hello", HorizontalOptions = LayoutOptions.Center, VerticalOptions = LayoutOptions.Center };
+ btn.Clicked += (sender, e) => { label.Text = Success; };
+ var grd = new Grid();
+ grd.Children.Add(btn);
+ grd.Children.Add(img);
+ grd.Children.Add(label);
+ Content = grd;
+ }
+
+#if UITEST
+ [Test]
+ public void TestButtonUsingElevation ()
+ {
+ RunningApp.WaitForElement(Running);
+ RunningApp.Tap(btnId);
+ RunningApp.WaitForNoElement(Success);
+ }
+#endif
+ }
+}
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
index e2d574f..fe99642 100644
--- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
+++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
@@ -588,6 +588,7 @@
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla56710.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla52700.cs" />
<Compile Include="$(MSBuildThisFileDirectory)Bugzilla39407.cs" />
+ <Compile Include="$(MSBuildThisFileDirectory)ButtonFastRendererTest.cs" />
</ItemGroup>
<ItemGroup>
<EmbeddedResource Include="$(MSBuildThisFileDirectory)Bugzilla22229.xaml">