diff options
author | Stephane Delcroix <stephane@delcroix.org> | 2016-12-01 22:39:43 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2016-12-01 22:39:43 +0100 |
commit | 1ff0db9c6f4ba1167e6b2620066f83088f23c5bf (patch) | |
tree | dbab7e305046c6ee4b1ccafd60afd3e255385320 /Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared | |
parent | e413e0cf331ae1512e2d8a6fcc89446c1cf2225c (diff) | |
download | xamarin-forms-1ff0db9c6f4ba1167e6b2620066f83088f23c5bf.tar.gz xamarin-forms-1ff0db9c6f4ba1167e6b2620066f83088f23c5bf.tar.bz2 xamarin-forms-1ff0db9c6f4ba1167e6b2620066f83088f23c5bf.zip |
Jimmgarrido uwp toolbar (#588)
* Fixed CommandBar being clipped when expanded by removing explicit Height
* Add UITest
Diffstat (limited to 'Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared')
2 files changed, 41 insertions, 1 deletions
diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla47295.cs b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla47295.cs new file mode 100644 index 00000000..0277e7d4 --- /dev/null +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Bugzilla47295.cs @@ -0,0 +1,39 @@ +using Xamarin.Forms.CustomAttributes; +using Xamarin.Forms.Internals; + +#if UITEST +using Xamarin.UITest; +using NUnit.Framework; +#endif + +namespace Xamarin.Forms.Controls.Issues +{ + [Preserve(AllMembers = true)] + [Issue(IssueTracker.Bugzilla, 47295, "Toolbar in a NavigationPage is clipped when expanded", PlatformAffected.WinRT)] + public class Bugzilla47295 : TestNavigationPage + { + protected override void Init() + { + PushAsync(new TestPage47295()); + } + } + + [Preserve(AllMembers = true)] + public class TestPage47295 : ContentPage + { + public TestPage47295() + { + var descLabel = new Label { Text = "Press '...' to expand the CommandBar. The ToolbarItem's text label should not be clipped." }; + var pressedLabel = new Label { Text = "ToolbarItem pressed.", IsVisible = false }; + Content = new StackLayout + { + Children = { + descLabel, + pressedLabel + } + }; + + ToolbarItems.Add(new ToolbarItem("Test", "toolbar_close", () => pressedLabel.IsVisible = true)); + } + } +}
\ No newline at end of file diff --git a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems index 08c26ba1..625226db 100644 --- a/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems +++ b/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems @@ -140,6 +140,7 @@ <Compile Include="$(MSBuildThisFileDirectory)Bugzilla44476.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla46630.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla47971.cs" /> + <Compile Include="$(MSBuildThisFileDirectory)Bugzilla47295.cs" /> <Compile Include="$(MSBuildThisFileDirectory)CarouselAsync.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla34561.cs" /> <Compile Include="$(MSBuildThisFileDirectory)Bugzilla34727.cs" /> @@ -605,4 +606,4 @@ <Generator>MSBuild:UpdateDesignTimeXaml</Generator> </EmbeddedResource> </ItemGroup> -</Project>
\ No newline at end of file +</Project> |