summaryrefslogtreecommitdiff
path: root/Xamarin.Forms.ControlGallery.Android
diff options
context:
space:
mode:
authorSamantha Houts <samhouts@users.noreply.github.com>2017-10-18 21:28:18 (GMT)
committerRui Marinho <me@ruimarinho.net>2017-10-18 21:46:09 (GMT)
commit3b9712aaf5d0e8932d1e30facc9ec842a43f6860 (patch)
tree71b91ca39de0c0fc9ad3e5cebe42755c8d3b9e94 /Xamarin.Forms.ControlGallery.Android
parent0927f1e6889a2f92864c8bfc384cfd4c3fa9c7ed (diff)
downloadxamarin-forms-3b9712aaf5d0e8932d1e30facc9ec842a43f6860.zip
xamarin-forms-3b9712aaf5d0e8932d1e30facc9ec842a43f6860.tar.gz
xamarin-forms-3b9712aaf5d0e8932d1e30facc9ec842a43f6860.tar.bz2
[Android] Prevent ObjectDisposedExceptions in ListViews with Header/FooterTemplates (#1155)
* Update repro to include header/footers with bound props * [Android] Clear renderers of ListView header/footers And don't call `RemoveAllViews`, because that causes the ObjectDisposedExceptions.
Diffstat (limited to 'Xamarin.Forms.ControlGallery.Android')
-rw-r--r--Xamarin.Forms.ControlGallery.Android/CustomRenderers.cs5
1 files changed, 3 insertions, 2 deletions
diff --git a/Xamarin.Forms.ControlGallery.Android/CustomRenderers.cs b/Xamarin.Forms.ControlGallery.Android/CustomRenderers.cs
index d8c5b9c..21bcd74 100644
--- a/Xamarin.Forms.ControlGallery.Android/CustomRenderers.cs
+++ b/Xamarin.Forms.ControlGallery.Android/CustomRenderers.cs
@@ -31,7 +31,7 @@ using Xamarin.Forms.Controls.Issues;
[assembly: ExportRenderer(typeof(Bugzilla42000._42000NumericEntryNoDecimal), typeof(EntryRendererNoDecimal))]
[assembly: ExportRenderer(typeof(Bugzilla42000._42000NumericEntryNoNegative), typeof(EntryRendererNoNegative))]
//[assembly: ExportRenderer(typeof(AndroidHelpText.HintLabel), typeof(HintLabel))]
-[assembly: ExportRenderer(typeof(Bugzilla57910QuickCollectNavigationPage), typeof(QuickCollectNavigationPage))]
+[assembly: ExportRenderer(typeof(QuickCollectNavigationPage), typeof(QuickCollectNavigationPageRenderer))]
[assembly: ExportRenderer(typeof(Xamarin.Forms.Controls.Issues.NoFlashTestNavigationPage), typeof(Xamarin.Forms.ControlGallery.Android.NoFlashTestNavigationPage))]
@@ -548,7 +548,8 @@ namespace Xamarin.Forms.ControlGallery.Android
#endif
}
- public class QuickCollectNavigationPage
+#pragma warning disable CS0618 // Leaving in old constructor so we can verify it works
+ public class QuickCollectNavigationPageRenderer
#if FORMS_APPLICATION_ACTIVITY
: Xamarin.Forms.Platform.Android.NavigationRenderer
#else