diff options
| author | Stephane Delcroix <stephane@delcroix.org> | 2017-02-02 11:14:35 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-02-02 11:14:35 +0100 |
| commit | c25a360efbbbe1f161e6737e61aed4b96cd37ac3 (patch) | |
| tree | bf8dac966d5b5c5d3851ed507e729547efff9df9 /Xamarin.Forms.Build.Tasks | |
| parent | fa0882114d31387acaa8d6f43b638a0bf1efa871 (diff) | |
| download | xamarin-forms-c25a360efbbbe1f161e6737e61aed4b96cd37ac3.tar.gz xamarin-forms-c25a360efbbbe1f161e6737e61aed4b96cd37ac3.tar.bz2 xamarin-forms-c25a360efbbbe1f161e6737e61aed4b96cd37ac3.zip | |
[Xaml[C]] throw meaningful exception while trying to set the content … (#714)
* [Xaml[C]] throw meaningful exception while trying to set the content of a property without ContentPropertyAttribute
* fix test
Diffstat (limited to 'Xamarin.Forms.Build.Tasks')
| -rw-r--r-- | Xamarin.Forms.Build.Tasks/SetPropertiesVisitor.cs | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/Xamarin.Forms.Build.Tasks/SetPropertiesVisitor.cs b/Xamarin.Forms.Build.Tasks/SetPropertiesVisitor.cs index 608fab5b..64bc7585 100644 --- a/Xamarin.Forms.Build.Tasks/SetPropertiesVisitor.cs +++ b/Xamarin.Forms.Build.Tasks/SetPropertiesVisitor.cs @@ -128,7 +128,7 @@ namespace Xamarin.Forms.Build.Tasks // Collection element, implicit content, or implicit collection element. string contentProperty; var parentVar = Context.Variables[(IElementNode)parentNode]; - if (parentVar.VariableType.ImplementsInterface(Module.ImportReference(typeof (IEnumerable)))) + if (parentVar.VariableType.ImplementsInterface(Module.ImportReference(typeof (IEnumerable))) && parentVar.VariableType.GetMethods(md => md.Name == "Add" && md.Parameters.Count == 1, Module).Any()) { var elementType = parentVar.VariableType; if (elementType.FullName != "Xamarin.Forms.ResourceDictionary" && elementType.Resolve().BaseType.FullName != "Xamarin.Forms.ResourceDictionary") @@ -152,7 +152,8 @@ namespace Xamarin.Forms.Build.Tasks if (parentNode is IElementNode && ((IElementNode)parentNode).SkipProperties.Contains (propertyName)) return; Context.IL.Append(SetPropertyValue(Context.Variables[(IElementNode)parentNode], name, node, Context, node)); - } + } else + throw new XamlParseException($"Can not set the content of {((IElementNode)parentNode).XmlType.Name} as it doesn't have a ContentPropertyAttribute", node); } else if (IsCollectionItem(node, parentNode) && parentNode is ListNode) { |