summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRui Marinho <me@ruimarinho.net>2017-08-15 10:44:02 +0100
committerGitHub <noreply@github.com>2017-08-15 10:44:02 +0100
commit4eb64b900c3fc5c06907d7856653842e09a423eb (patch)
tree0b3aa6dd406e9f637a860d093e0ee2dd6da7dfe4
parent8771b4fa31856d28cbac28e8a5267f20c3c893b2 (diff)
downloadxamarin-forms-4eb64b900c3fc5c06907d7856653842e09a423eb.tar.gz
xamarin-forms-4eb64b900c3fc5c06907d7856653842e09a423eb.tar.bz2
xamarin-forms-4eb64b900c3fc5c06907d7856653842e09a423eb.zip
[MacOS]Remove extra lib that's not needed for Maps (#1100)
* [MacOS]Remove extra lib that's not needed for Maps * [Nuget] Update nuspec
-rw-r--r--.nuspec/Xamarin.Forms.Maps.nuspec2
-rw-r--r--Xamarin.Forms.Maps.MacOS.Extra/ApiDefinition.cs33
-rw-r--r--Xamarin.Forms.Maps.MacOS.Extra/Properties/AssemblyInfo.cs34
-rw-r--r--Xamarin.Forms.Maps.MacOS.Extra/Xamarin.Forms.Maps.MacOS.Extra.csproj43
-rwxr-xr-xXamarin.Forms.Maps.MacOS/Libs/Xamarin.Forms.Maps.MacOS.Extra.dllbin13312 -> 0 bytes
-rw-r--r--Xamarin.Forms.Maps.MacOS/Xamarin.Forms.Maps.macOS.csproj35
-rw-r--r--Xamarin.Forms.Maps.iOS/GeocoderBackend.cs6
7 files changed, 21 insertions, 132 deletions
diff --git a/.nuspec/Xamarin.Forms.Maps.nuspec b/.nuspec/Xamarin.Forms.Maps.nuspec
index f0b6bb56..ddfc9fcc 100644
--- a/.nuspec/Xamarin.Forms.Maps.nuspec
+++ b/.nuspec/Xamarin.Forms.Maps.nuspec
@@ -62,7 +62,6 @@
<group targetFramework="Xamarin.Mac">
<reference file="Xamarin.Forms.Maps.dll" />
<reference file="Xamarin.Forms.Maps.macOS.dll" />
- <reference file="Xamarin.Forms.Maps.MacOS.Extra.dll" />
</group>
</references>
</metadata>
@@ -139,7 +138,6 @@
<file src="..\Xamarin.Forms.Maps.Design\bin\$Configuration$\Xamarin.Forms.Maps.Design.dll" target="lib\uap10.0\Design" />
<file src="..\Xamarin.Forms.Maps.MacOS\bin\$Configuration$\Xamarin.Forms.Maps.macOS.dll" target="lib\Xamarin.Mac" />
- <file src="..\Xamarin.Forms.Maps.MacOS\bin\$Configuration$\Xamarin.Forms.Maps.MacOS.Extra.dll" target="lib\Xamarin.Mac" />
<file src="..\Xamarin.Forms.Maps\bin\$Configuration$\Xamarin.Forms.Maps.dll" target="lib\Xamarin.Mac" />
<file src="..\docs\Xamarin.Forms.Maps.xml" target="lib\Xamarin.Mac" />
</files>
diff --git a/Xamarin.Forms.Maps.MacOS.Extra/ApiDefinition.cs b/Xamarin.Forms.Maps.MacOS.Extra/ApiDefinition.cs
deleted file mode 100644
index c6a92d91..00000000
--- a/Xamarin.Forms.Maps.MacOS.Extra/ApiDefinition.cs
+++ /dev/null
@@ -1,33 +0,0 @@
-using CoreLocation;
-using Foundation;
-
-namespace Xamarin.Forms.Maps.MacOS.Extra
-{
- delegate void CLGeocodeCompletionHandler(CLPlacemark[] placemarks, NSError error);
-
- [BaseType(typeof(NSObject))]
- interface CLGeocoder
- {
- [Export("isGeocoding")]
- bool Geocoding { get; }
-
- [Export("reverseGeocodeLocation:completionHandler:")]
- [Async]
- void ReverseGeocodeLocation(CLLocation location, CLGeocodeCompletionHandler completionHandler);
-
- [Export("geocodeAddressDictionary:completionHandler:")]
- [Async]
- void GeocodeAddress(NSDictionary addressDictionary, CLGeocodeCompletionHandler completionHandler);
-
- [Export("geocodeAddressString:completionHandler:")]
- [Async]
- void GeocodeAddress(string addressString, CLGeocodeCompletionHandler completionHandler);
-
- [Export("geocodeAddressString:inRegion:completionHandler:")]
- [Async]
- void GeocodeAddress(string addressString, CLRegion region, CLGeocodeCompletionHandler completionHandler);
-
- [Export("cancelGeocode")]
- void CancelGeocode();
- }
-}
diff --git a/Xamarin.Forms.Maps.MacOS.Extra/Properties/AssemblyInfo.cs b/Xamarin.Forms.Maps.MacOS.Extra/Properties/AssemblyInfo.cs
deleted file mode 100644
index 9e5eaa0c..00000000
--- a/Xamarin.Forms.Maps.MacOS.Extra/Properties/AssemblyInfo.cs
+++ /dev/null
@@ -1,34 +0,0 @@
-using System.Reflection;
-using System.Runtime.CompilerServices;
-
-using Foundation;
-
-// This attribute allows you to mark your assemblies as “safe to link”.
-// When the attribute is present, the linker—if enabled—will process the assembly
-// even if you’re using the “Link SDK assemblies only” option, which is the default for device builds.
-
-[assembly: LinkerSafe]
-
-// Information about this assembly is defined by the following attributes.
-// Change them to the values specific to your project.
-
-[assembly: AssemblyTitle("Xamarin.Forms.Maps.MacOS.Extra")]
-[assembly: AssemblyDescription("")]
-[assembly: AssemblyConfiguration("")]
-[assembly: AssemblyCompany("")]
-[assembly: AssemblyProduct("")]
-[assembly: AssemblyCopyright("")]
-[assembly: AssemblyTrademark("")]
-[assembly: AssemblyCulture("")]
-
-// The assembly version has the format "{Major}.{Minor}.{Build}.{Revision}".
-// The form "{Major}.{Minor}.*" will automatically update the build and revision,
-// and "{Major}.{Minor}.{Build}.*" will update just the revision.
-
-[assembly: AssemblyVersion("1.0.*")]
-
-// The following attributes are used to specify the signing key for the assembly,
-// if desired. See the Mono documentation for more information about signing.
-
-//[assembly: AssemblyDelaySign(false)]
-//[assembly: AssemblyKeyFile("")]
diff --git a/Xamarin.Forms.Maps.MacOS.Extra/Xamarin.Forms.Maps.MacOS.Extra.csproj b/Xamarin.Forms.Maps.MacOS.Extra/Xamarin.Forms.Maps.MacOS.Extra.csproj
deleted file mode 100644
index af4f4aac..00000000
--- a/Xamarin.Forms.Maps.MacOS.Extra/Xamarin.Forms.Maps.MacOS.Extra.csproj
+++ /dev/null
@@ -1,43 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
- <PropertyGroup>
- <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
- <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
- <ProjectGuid>{6346D187-BA87-4F18-A165-F27C5B7F25D0}</ProjectGuid>
- <ProjectTypeGuids>{810C163F-4746-4721-8B8E-88A3673A62EA};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
- <OutputType>Library</OutputType>
- <RootNamespace>Xamarin.Forms.Maps.MacOS.Extra</RootNamespace>
- <AssemblyName>Xamarin.Forms.Maps.MacOS.Extra</AssemblyName>
- <MacResourcePrefix>Resources</MacResourcePrefix>
- </PropertyGroup>
- <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
- <DebugSymbols>true</DebugSymbols>
- <DebugType>full</DebugType>
- <Optimize>false</Optimize>
- <OutputPath>bin\Debug</OutputPath>
- <DefineConstants>DEBUG;</DefineConstants>
- <ErrorReport>prompt</ErrorReport>
- <WarningLevel>4</WarningLevel>
- <AllowUnsafeBlocks>false</AllowUnsafeBlocks>
- </PropertyGroup>
- <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
- <Optimize>true</Optimize>
- <OutputPath>bin\Release</OutputPath>
- <DefineConstants></DefineConstants>
- <ErrorReport>prompt</ErrorReport>
- <WarningLevel>4</WarningLevel>
- <AllowUnsafeBlocks>false</AllowUnsafeBlocks>
- </PropertyGroup>
- <ItemGroup>
- <Reference Include="System" />
- <Reference Include="System.Core" />
- <Reference Include="Xamarin.Mac" />
- </ItemGroup>
- <ItemGroup>
- <Compile Include="Properties\AssemblyInfo.cs" />
- </ItemGroup>
- <ItemGroup>
- <ObjcBindingApiDefinition Include="ApiDefinition.cs" />
- </ItemGroup>
- <Import Project="$(MSBuildExtensionsPath)\Xamarin\Mac\Xamarin.Mac.ObjcBinding.CSharp.targets" />
-</Project> \ No newline at end of file
diff --git a/Xamarin.Forms.Maps.MacOS/Libs/Xamarin.Forms.Maps.MacOS.Extra.dll b/Xamarin.Forms.Maps.MacOS/Libs/Xamarin.Forms.Maps.MacOS.Extra.dll
deleted file mode 100755
index 0c17fff6..00000000
--- a/Xamarin.Forms.Maps.MacOS/Libs/Xamarin.Forms.Maps.MacOS.Extra.dll
+++ /dev/null
Binary files differ
diff --git a/Xamarin.Forms.Maps.MacOS/Xamarin.Forms.Maps.macOS.csproj b/Xamarin.Forms.Maps.MacOS/Xamarin.Forms.Maps.macOS.csproj
index af3da201..2e47f59b 100644
--- a/Xamarin.Forms.Maps.MacOS/Xamarin.Forms.Maps.macOS.csproj
+++ b/Xamarin.Forms.Maps.MacOS/Xamarin.Forms.Maps.macOS.csproj
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build" ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
@@ -25,15 +25,20 @@
<EnablePackageSigning>false</EnablePackageSigning>
<IncludeMonoRuntime>false</IncludeMonoRuntime>
<UseSGen>false</UseSGen>
- <HttpClientHandler></HttpClientHandler>
- <TlsProvider></TlsProvider>
- <LinkMode></LinkMode>
- <XamMacArch></XamMacArch>
+ <HttpClientHandler>
+ </HttpClientHandler>
+ <TlsProvider>
+ </TlsProvider>
+ <LinkMode>
+ </LinkMode>
+ <XamMacArch>
+ </XamMacArch>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<Optimize>true</Optimize>
<OutputPath>bin\Release</OutputPath>
- <DefineConstants></DefineConstants>
+ <DefineConstants>
+ </DefineConstants>
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<EnableCodeSigning>false</EnableCodeSigning>
@@ -41,18 +46,19 @@
<EnablePackageSigning>false</EnablePackageSigning>
<IncludeMonoRuntime>false</IncludeMonoRuntime>
<UseSGen>false</UseSGen>
- <HttpClientHandler></HttpClientHandler>
- <TlsProvider></TlsProvider>
- <LinkMode></LinkMode>
- <XamMacArch></XamMacArch>
+ <HttpClientHandler>
+ </HttpClientHandler>
+ <TlsProvider>
+ </TlsProvider>
+ <LinkMode>
+ </LinkMode>
+ <XamMacArch>
+ </XamMacArch>
</PropertyGroup>
<ItemGroup>
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="Xamarin.Mac" />
- <Reference Include="Xamarin.Forms.Maps.MacOS.Extra">
- <HintPath>Libs\Xamarin.Forms.Maps.MacOS.Extra.dll</HintPath>
- </Reference>
</ItemGroup>
<ItemGroup>
<Compile Include="Properties\AssemblyInfo.cs" />
@@ -86,8 +92,5 @@
<Name>Xamarin.Forms.Maps</Name>
</ProjectReference>
</ItemGroup>
- <ItemGroup>
- <None Include="Libs\Xamarin.Forms.Maps.MacOS.Extra.dll" />
- </ItemGroup>
<Import Project="$(MSBuildExtensionsPath)\Xamarin\Mac\Xamarin.Mac.CSharp.targets" />
</Project> \ No newline at end of file
diff --git a/Xamarin.Forms.Maps.iOS/GeocoderBackend.cs b/Xamarin.Forms.Maps.iOS/GeocoderBackend.cs
index e5d1b25c..b80d7b59 100644
--- a/Xamarin.Forms.Maps.iOS/GeocoderBackend.cs
+++ b/Xamarin.Forms.Maps.iOS/GeocoderBackend.cs
@@ -6,12 +6,10 @@ using CoreLocation;
#if __MOBILE__
using AddressBookUI;
-using CCLGeocoder = CoreLocation.CLGeocoder;
-#else
-using Xamarin.Forms.Maps.MacOS.Extra;
-using CCLGeocoder = Xamarin.Forms.Maps.MacOS.Extra.CLGeocoder;
#endif
+using CCLGeocoder = CoreLocation.CLGeocoder;
+
#if __MOBILE__
namespace Xamarin.Forms.Maps.iOS
#else