Resharper warnings are slightly different for some reason than WError, resolve these (#66)

21 files changed, 6 insertions, 68 deletions

diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-BoundViewUITest.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-BoundViewUITest.cs
index 625a27ca..4f2a733a 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-BoundViewUITest.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-BoundViewUITest.cs
@@ -52,9 +52,6 @@ namespace Xamarin.Forms.Core.UITests
 //			App.WaitForElement (q => q.Marked ("Second Page"), "Timeout : Second Page");
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
 
 //		[Test]
 //		[Description ("Verify all elements are preset - landscape")]
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ClipToBoundsUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ClipToBoundsUITests.cs
index 9dffeaaf..b6a8ebc8 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ClipToBoundsUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ClipToBoundsUITests.cs
@@ -42,10 +42,6 @@ namespace Xamarin.Forms.Core.UITests
 //			App.Screenshot ("Clip elements");
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("Check all elements exist - landscape")]
 //		public void ClipToBoundsGalleryAllElementsExistLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-EntryUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-EntryUITests.cs
index e88ff6b6..d3fc8908 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-EntryUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-EntryUITests.cs
@@ -213,10 +213,6 @@ namespace Xamarin.Forms.Core.UITests
 //		}
 			
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("All Entry Gallery elements are present - landscape")]
 //		public void EntryGalleryAllElementsPresentLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-GroupedListActionsUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-GroupedListActionsUITests.cs
index 289b5389..374e0633 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-GroupedListActionsUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-GroupedListActionsUITests.cs
@@ -178,10 +178,6 @@ namespace Xamarin.Forms.Core.UITests
 
 //		}
 			
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("Child item action test - landscape")]
 //		public void GroupedListActionsGalleryAllElementsExistLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-InputIntentUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-InputIntentUITests.cs
index 10713087..8a0bb965 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-InputIntentUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-InputIntentUITests.cs
@@ -136,10 +136,6 @@ namespace Xamarin.Forms.Core.UITests
 //			}
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("All entries are shown - landscape")]
 //		public void InputIntentGalleryAllElementsExistLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ListUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ListUITests.cs
index e57ed902..17fb1eb8 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ListUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ListUITests.cs
@@ -62,10 +62,6 @@ namespace Xamarin.Forms.Core.UITests
 //			App.Screenshot ("At the bottom of the list");
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("Click 0 - 5 and reset - Landscape")]
 //		public void ListGalleryClickElementsAndResetLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-RelativeLayoutUITest.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-RelativeLayoutUITest.cs
index 72171f39..caa05eac 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-RelativeLayoutUITest.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-RelativeLayoutUITest.cs
@@ -30,10 +30,6 @@ namespace Xamarin.Forms.Core.UITests
 //				App.ScrollDownForElement (q => q.Marked (element.ToString ()), 10);
 		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("All elements are present - Landscape")]
 //		public void RelativeLayoutGalleryAllElementsPresentLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SearchBarUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SearchBarUITests.cs
index d9461cf6..399a4462 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SearchBarUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SearchBarUITests.cs
@@ -110,9 +110,6 @@ namespace Xamarin.Forms.Core.UITests
 
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
 //		[Test]
 //		[Category ("ManualReview")]
 //		[Description ("Enable disable keyboard, Issues #1182, #1237 - landscape")]
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SliderUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SliderUITests.cs
index 11c33d7f..ae2754dd 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SliderUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SliderUITests.cs
@@ -65,10 +65,6 @@ namespace Xamarin.Forms.Core.UITests
 
 		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		public void AllElementsPresentLandscape ()
 //		{
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-StackLayoutUITest.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-StackLayoutUITest.cs
index b17c7ec8..9f6d6d37 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-StackLayoutUITest.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-StackLayoutUITest.cs
@@ -58,9 +58,6 @@ namespace Xamarin.Forms.Core.UITests
 //			App.Screenshot ("All buttons clicked");
 		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
 //		[Test]
 //		[Description ("Check that each button is there and click them - Landscape")]
 //		public void StackLayoutGalleryClickEachButtonLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-StepperUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-StepperUITests.cs
index a468e310..aaf5f0e3 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-StepperUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-StepperUITests.cs
@@ -62,10 +62,6 @@ namespace Xamarin.Forms.Core.UITests
 //			}
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("Check all elements exist - Landscape")]
 //		public void StepperGalleryAllElementsPresetLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SwitchUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SwitchUITests.cs
index 67a23d88..c2eb1abf 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SwitchUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-SwitchUITests.cs
@@ -73,10 +73,6 @@ namespace Xamarin.Forms.Core.UITests
 //			}
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("Check all elements exist - Landscape")]
 //		public void SwitchGalleryAllElementsPresetLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TableViewUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TableViewUITests.cs
index 5f9bd80c..1f1dd012 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TableViewUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TableViewUITests.cs
@@ -45,10 +45,6 @@ namespace Xamarin.Forms.Core.UITests
 //			App.Screenshot ("TableCells are present");
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("Elements of CustomHeader are present - Landscape")]
 //		public void TableViewGalleryCustomHeaderLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TemplatedCarouselPageUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TemplatedCarouselPageUITests.cs
index f01641a5..47e3445f 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TemplatedCarouselPageUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TemplatedCarouselPageUITests.cs
@@ -300,9 +300,6 @@ namespace Xamarin.Forms.Core.UITests
 //			ScrollUpForQuery (q => q.Marked (title), scrollContainerBounds);
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
 
 //		[Test]
 //		[Description ("Insert page - Landscape")]
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TemplatedTabPageUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TemplatedTabPageUITests.cs
index 180c7bff..36d051b8 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TemplatedTabPageUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-TemplatedTabPageUITests.cs
@@ -250,10 +250,6 @@ namespace Xamarin.Forms.Core.UITests
 //			App.DragFromToForElement (2, query, screenBounds.Width - 10, screenBounds.Height / 3.0f, screenBounds.Width - 10,  (2 / 3.0f) * screenBounds.Height);
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("Insert tab - Landscape")]
 //		public void TemplatedTabPageGalleryInsertTabLandscape () 
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-UnevenViewCellUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-UnevenViewCellUITests.cs
index 1b826ec0..1cab2a1c 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-UnevenViewCellUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-UnevenViewCellUITests.cs
@@ -64,10 +64,6 @@ namespace Xamarin.Forms.Core.UITests
 //			Assert.Greater (unevenCellHeight, evenCellHeight);
 //		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("All views exist - Landscape")]
 //		public void UnevenViewCellGalleryScrollDownForAllElementsLandscape ()
diff --git a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ViewCellUITests.cs b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ViewCellUITests.cs
index c6a79e71..1dcc0de6 100644
--- a/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ViewCellUITests.cs
+++ b/Xamarin.Forms.Core.iOS.UITests/Tests/Legacy-ViewCellUITests.cs
@@ -47,10 +47,6 @@ namespace Xamarin.Forms.Core.UITests
 //			App.Screenshot ("All ViewCells exist");
 		}
 
-///*******************************************************/
-///**************** Landscape tests **********************/
-///*******************************************************/
-
 //		[Test]
 //		[Description ("All elements exist - Landscape")]
 //		public void ViewCellGalleryScrollDownForAllElementsLandscape ()
diff --git a/Xamarin.Forms.Maps.iOS/MapRenderer.cs b/Xamarin.Forms.Maps.iOS/MapRenderer.cs
index aa3bb447..94d5eee9 100644
--- a/Xamarin.Forms.Maps.iOS/MapRenderer.cs
+++ b/Xamarin.Forms.Maps.iOS/MapRenderer.cs
@@ -133,8 +133,7 @@ namespace Xamarin.Forms.Maps.iOS
 
 	public class MapRenderer : ViewRenderer
 	{
-		long _handle = 0;
-		CLLocationManager _locationManager;
+	    CLLocationManager _locationManager;
 
 		public override SizeRequest GetDesiredSize(double widthConstraint, double heightConstraint)
 		{
diff --git a/Xamarin.Forms.Platform.Android/Renderers/ImageExtensions.cs b/Xamarin.Forms.Platform.Android/Renderers/ImageExtensions.cs
index e48682c3..7ae3d281 100644
--- a/Xamarin.Forms.Platform.Android/Renderers/ImageExtensions.cs
+++ b/Xamarin.Forms.Platform.Android/Renderers/ImageExtensions.cs
@@ -19,7 +19,6 @@ namespace Xamarin.Forms.Platform.Android
 				default:
 				case Aspect.AspectFit:
 					return s_aspectFit ?? (s_aspectFit = ImageView.ScaleType.FitCenter);
-					;
 			}
 		}
 	}
diff --git a/Xamarin.Forms.Platform.WinRT/Platform.cs b/Xamarin.Forms.Platform.WinRT/Platform.cs
index df16ddc9..dbef5f7d 100644
--- a/Xamarin.Forms.Platform.WinRT/Platform.cs
+++ b/Xamarin.Forms.Platform.WinRT/Platform.cs
@@ -342,7 +342,9 @@ namespace Xamarin.Forms.Platform.WinRT
 		readonly ToolbarTracker _toolbarTracker = new ToolbarTracker();
 		readonly FileImageSourcePathConverter _fileImageSourcePathConverter = new FileImageSourcePathConverter();
 
-		IToolbarProvider _toolbarProvider;
+#pragma warning disable 649
+        IToolbarProvider _toolbarProvider;
+#pragma warning restore 649
 
 		class ToolbarProvider : IToolbarProvider
 		{
diff --git a/Xamarin.Forms.Platform.iOS/Renderers/CarouselViewRenderer.cs b/Xamarin.Forms.Platform.iOS/Renderers/CarouselViewRenderer.cs
index d52feb70..84f57a91 100644
--- a/Xamarin.Forms.Platform.iOS/Renderers/CarouselViewRenderer.cs
+++ b/Xamarin.Forms.Platform.iOS/Renderers/CarouselViewRenderer.cs
@@ -38,7 +38,9 @@ namespace Xamarin.Forms.Platform.iOS
 	///     The interfaces only implement required method while the UICollectionView exposes optional methods via
 	///     ExportAttribute.
 	///     The C# method name may be aliased. For example, C# "GetCell" maps to obj-C "CellForItemAtIndexPath".
+#pragma warning disable 1584
 	///     <seealso cref="https://developer.apple.com/library/ios/documentation/UIKit/Reference/UICollectionView_class/" />
+#pragma warning restore 1584
 	/// </summary>
 	public class CarouselViewRenderer : ViewRenderer<CarouselView, UICollectionView>
 	{