summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2016-06-21Switching ASan onsandbox/vbarinov/asanSlava Barinov1-0/+1
Change-Id: I4d02ee034226a00de0c7ffd81ba357a72ae5aea6 Signed-off-by: Slava Barinov <v.barinov@samsung.com>
2016-06-20Add Address Sanitizer support definesSlava Barinov3-5/+5
Address Sanitizer uses approach alike to Valgrind one and therefore reports memory issues on the same code sections with intentional operations. Code prepare for Valgrind will work for ASan as well. Change-Id: I65331237e4530861e9df2818db31cbfb0875a486 Signed-off-by: Slava Barinov <v.barinov@samsung.com>
2016-06-17Description : Fixed the warning of svace.submit/tizen/20160617.013208accepted/tizen/wearable/20160617.084045accepted/tizen/tv/20160617.083905accepted/tizen/mobile/20160617.084025accepted/tizen/ivi/20160617.084027accepted/tizen/common/20160620.163211wchang kim1-0/+2
Uninitialized data is read from local variable 'r. In case that strjoin returns NULL, r is not initialized. Change-Id: Ib2374e5b966766dc9594fb50937459ba3e1edd46 https://github.com/systemd/systemd/commit/c43b2132f37264600cc26e07c8d85dfdd6c969f0 Backported-by: Woochang Kim <wchang.kim@samsung.com> Signed-off-by: Woochang Kim <wchang.kim@samsung.com>
2016-06-09For using persistent storage in AUTO mode.submit/tizen/20160613.215643accepted/tizen/wearable/20160614.041503accepted/tizen/tv/20160614.041350accepted/tizen/mobile/20160614.041344accepted/tizen/ivi/20160614.041401accepted/tizen/common/20160614.143755Kunhoon Baik2-1/+5
As Tizen default, /opt is mounted seperately, and the /var -> /opt/var Thus, systemd flush should be done after mounting /opt. In generic, I think that systemd-journal-flush should be done after local-fs.target because several devices have own partition policies. Change-Id: I4acb4bd26365681ea798441c2f154b8ba5422665
2016-05-24Disable systemd-timedated and systemd-rfkillKunhoon Baik1-0/+16
Tizen 3.0 does not use systemd-timedated for changing time-zone and related things. Alarm-manager will manage the functionalities. Tizen 3.0 does not use systemd-rfkill any more. Net-config will manage the functionalities. Change-Id: Icb3011003060c213b2bdcd0de53480acaaeed70b
2016-05-24machined: use x-machine-unix prefix for the container bus on dbus1submit/tizen/20160524.111517accepted/tizen/wearable/20160602.020735accepted/tizen/tv/20160602.020719accepted/tizen/mobile/20160602.020731accepted/tizen/ivi/20160602.020817accepted/tizen/common/20160526.145923Benjamin Franzke1-1/+1
This fixes "machinectl login" on systems configured with --disable-kdbus. The error was: machinectl login foo Failed to get machine PTY: Input/output error Change-Id: Ib4228926ed33d2b628d1f381ade7c42098879b77 Origin: http://cgit.freedesktop.org/systemd/systemd/commit/?id=f2273101c21bc59a390379e182e53cd4f07a7e71 Backported-by: Karol Lewandowski <k.lewandowsk@samsung.com> Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
2016-05-13Add some groups for user session daemonssubmit/tizen/20160516.024300accepted/tizen/wearable/20160517.032001accepted/tizen/tv/20160517.032007accepted/tizen/mobile/20160517.031943accepted/tizen/ivi/20160517.032021accepted/tizen/common/20160516.143415Kidong Kim1-0/+1
Because user session daemons have same uid/gid with applications, include them in specific gids for checking privilege. The security-manager will drop these groups from applications. Change-Id: I1ed91e75cb605a4c6bffa604fe992ec995ff2845
2016-04-29tizen: kdbus: install user session dbus1 (kdbus) generator properlysubmit/tizen/20160502.064241accepted/tizen/wearable/20160503.011013accepted/tizen/tv/20160503.010950accepted/tizen/mobile/20160503.010934accepted/tizen/ivi/20160503.011035accepted/tizen/common/20160504.124920Karol Lewandowski1-1/+1
This commit fixes commit 30dfab97 ("build: remove --relative in 'ln'") which resulted in stale symlink being installed. $ stat /usr/lib/systemd/user-generators/systemd-dbus1-generator File: `/usr/lib/systemd/user-generators/systemd-dbus1-generator' -> `.//usr/lib/systemd/system-generators/systemd-dbus1-generator' Change-Id: I91266b015436d8208b62360d500c93a684e696be
2016-04-17Disable systemd-backlightKunhoon Baik1-0/+4
Tizen does not use systemd-backlight. Deviced will control whole backlight-related operation. Change-Id: I59b45eeb5dbc3d4ab716bcbf38df120fd1023a5f
2016-04-17Add nosuid and noexec option for mounting /tmpKunhoon Baik1-2/+2
Refer to : https://bugs.tizen.org/jira/browse/TM-233 Change-Id: Ibc06d23f6743b2c21007cef5e340048a1e0d1429
2016-04-06Disable systemd-coredumpKunhoon Baik1-0/+8
Tizen 3.0 does not use systemd-coredump due to performance issue. Instead of systemd coredump, Tizen 3.0 uses crash-manager Change-Id: Ic73aabc9ab874a8b88db501a0d2eef5727bfbacf
2016-04-06Remove bash-completion (and zsh-completion) of systemdKunhoon Baik1-0/+14
[Note] Bash shell of current Tizen does not support several completion command due to license issue. Thus, most bash-completion script of systemd does not work. In addtion, default Tizen wdoes not support zsh. Change-Id: I18d6a05866ff375e08402b9b4f832592c11531d0
2016-03-26Run the serial-getty (Open the serial console) eariler for debugging ↵Kunhoon Baik1-1/+1
convenience. Change-Id: I239977c2872ed219bf2591a80c1153eeba4cdc89
2016-03-18spec: change LGPL license version 2.0+ to 2.1+submit/tizen/20160318.115901accepted/tizen/wearable/20160321.005040accepted/tizen/tv/20160321.005022accepted/tizen/mobile/20160321.005005accepted/tizen/ivi/20160321.005057accepted/tizen/common/20160321.145934boseong choi1-6/+6
change LGPL license version. 2.0+ -> 2.1+ Change-Id: I56238c288bde2d21a13c390880270cee36bf1d37 Signed-off-by: boseong choi <boseong.choi@samsung.com>
2016-03-11spec: Remove unnecessary default.target for IVI profilesubmit/tizen/20160314.044644accepted/tizen/wearable/20160315.002020accepted/tizen/tv/20160315.002003accepted/tizen/mobile/20160315.001951accepted/tizen/ivi/20160315.002040accepted/tizen/common/20160316.155458Sangjung Woo2-19/+0
This removes unnecessary default.target file for IVI profile. Change-Id: Ib354a9028ab020f504e7c35cb5f9bb16ea112766 Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2016-02-23missing: add more btrfs definessubmit/tizen_common/20160229.190608submit/tizen/20160225.005022accepted/tizen/wearable/20160225.082240accepted/tizen/tv/20160225.082220accepted/tizen/mobile/20160225.082207accepted/tizen/ivi/20160225.082257accepted/tizen/common/20160301.120600Min Kang1-0/+28
this patch for support linux-kernel-3.4 origin: https://github.com/systemd/systemd/commit/d97fb4083 Change-Id: Ia06e81faf7aa2c4e37461979c078fca05d1b72cd Signed-off-by: Min Kang <min1023.kang@samsung.com>
2016-02-23missing.h: add NDA_*Min Kang2-1/+19
This is necessary to build with older kernel headers. NDA_VLAN was introduced in v3.9 and NDA_PORT, NDA_VNI and NDA_IFINDEX in v3.10 this patch for support linux-kernel-3.4 origin: https://github.com/systemd/systemd/commit/cf1755ba Change-Id: I26a320475c0a36b8eab6a22997b20f1b6915afab Signed-off-by: Min Kang <min1023.kang@samsung.com>
2016-02-23missing.h: add more btrfs types and definesMin Kang1-0/+151
this patch for support linux-kernel-3.4 origin: https://github.com/systemd/systemd/commit/8e8ba7922 Change-Id: I1bf5ee71b0e34d0662544576eb78d37edd4706f8 Signed-off-by: Min Kang <min1023.kang@samsung.com>
2016-02-23Add fallback for kcmp() in case __NR_kcmp is undefinedMin Kang1-0/+5
IA64 is missing this syscall as of linux-4.2. This works around it until the necessary kernel patch gets merged. this patch for support linux-kernel-3.4 origin: https://github.com/systemd/systemd/commit/75b55457 Change-Id: I2f6c4a6266f30fe7435d2e1b8a79c69ff2564c09 Signed-off-by: Min Kang <min1023.kang@samsung.com>
2016-02-22fix some user session targets wrong symlinkMin Kang1-1/+1
Some user session target files, which is under USER_UNIT_ALIASES, refers wrong relative path when install-aliases-hook Therefore fix install-relative-aliases Change-Id: I5f0c8d973c4ff85599fef586a439b40985403387 Signed-off-by: Min Kang <min1023.kang@samsung.com>
2016-01-14Merge "spec: exclude unused generators to speed up boot" into tizensubmit/tizen_ivi/20160217.000007submit/tizen_ivi/20160217.000000submit/tizen_common/20160218.142243submit/tizen/20160121.162134accepted/tizen/wearable/20160122.034746accepted/tizen/tv/20160122.034721accepted/tizen/mobile/20160122.034700accepted/tizen/ivi/20160218.025717Łukasz Stelmach1-3/+3
2016-01-13spec: exclude unused generators to speed up bootŁukasz Stelmach1-3/+3
Change-Id: I9dcde28a22d7301c68280c1f72ecb1c5641296d1 Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
2016-01-13spec: remove circular dependency on OBSsubmit/tizen/20160114.052109accepted/tizen/wearable/20160114.065941accepted/tizen/tv/20160114.065905accepted/tizen/mobile/20160114.065837Min Kang1-2/+2
remove dbus-1 BuildRequires and dbus Requires Change-Id: Ic2f4b419c15c5759743fbe3a5df60d4558c5bb53 Signed-off-by: Min Kang <min1023.kang@samsung.com>
2016-01-08systemd:dbus:modify unix:path=/var/run/dbus/system_bus_socketsubmit/tizen_common/20160113.121553submit/tizen/20160112.014458accepted/tizen/wearable/20160112.043212accepted/tizen/tv/20160112.043153accepted/tizen/mobile/20160112.043130accepted/tizen/common/20160118.121332sanghyeok.oh1-1/+1
Change-Id: Id2458b3765cb6ccb5b41a96eea42ae6da5d2c557 Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
2016-01-06packaging: remove hwdata package in BuildRequiressubmit/tizen/20160106.003256accepted/tizen/wearable/20160106.082214accepted/tizen/tv/20160106.082155accepted/tizen/mobile/20160106.082137Min Kang1-2/+0
hwdata package is unused, so remove BuildRequires and Requires Change-Id: I705d002269d273985584e4d6b009ab3401a0b626 Signed-off-by: Min Kang <min1023.kang@samsung.com>
2016-01-05build: remove --relative in 'ln'submit/tizen/20160105.083334submit/tizen/20160105.083230accepted/tizen/wearable/20160106.003356accepted/tizen/tv/20160106.003255accepted/tizen/mobile/20160106.003421Min Kang2-4/+6
removing --relative option in Makefile.am and configure.ac for coreutils TIZEN SPECIFIC Change-Id: If623dd6175507d62f0b34349aacecb8244882e4f Signed-off-by: Min Kang <min1023.kang@samsung.com>
2015-12-24core: fix cgroups-agent match for kdbussubmit/tizen/20160104.054848accepted/tizen/wearable/20160104.224356accepted/tizen/tv/20160104.224339accepted/tizen/mobile/20160104.224319David Herrmann1-16/+13
On kdbus, we get cgroups-agent messages via the system bus, not the private systemd socket. Therefore, we must install the match properly or we will never receive cgroup notifications. origin: https://github.com/systemd/systemd/commit/f5b51ea7fcb0b6380 Change-Id: Ifde091cdba0aa8dba961b1a1a09d7e30328f5e67 Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-12-24core: rewind message before forwarding itDavid Herrmann1-7/+11
Forwarding messages that are not rewinded will drop data. Fix this for cgroups-agent messages that we might remarshal before forwarding to the system bus. origin: https://github.com/systemd/systemd/commit/39881ed299a39ad33 Change-Id: I3611a9390a66e0d23da48df497058ecb82da5d15 Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-12-24bus: remarshal kdbus messages received from the kernelDavid Herrmann1-6/+18
If we receive an sd_bus_message from the kernel, m->kdbus will contain additional items that cannot be used when sending a message. Therefore, always remarshal the message if it is used again. origin: https://github.com/systemd/systemd/commit/908b8a42e645887f1 Change-Id: I691a71e645e0357cb2c063f5e2011784350fc9a3 Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-12-22bus: drop redundant assignmentDavid Herrmann1-2/+0
This assignment is already done in the parent context, no need to do it again. origin: https://github.com/systemd/systemd/commit/8b9972db Change-Id: Iefa9de732aaa46a5d3f1b20555d23698fd74695b Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-12-13spec: change default.target filesubmit/tizen_common/20151229.154718submit/tizen_common/20151229.144031submit/tizen_common/20151229.142028submit/tizen/20151214.012154accepted/tizen/wearable/20151214.055934accepted/tizen/tv/20151214.055907accepted/tizen/mobile/20151214.055847Min Kang2-21/+4
change default.target file to graphical.target symbolic link execpt for ivi Change-Id: Icba283120b59ffae3804ecbf6417dc34792421a3 Signed-off-by: Min Kang <min1023.kang@samsung.com>
2015-10-29kdbus: smack: Ensure new files on kdbusfs have '*' label by defaultsubmit/tizen/20151105.103851accepted/tizen/wearable/20151106.045611accepted/tizen/tv/20151106.045555accepted/tizen/mobile/20151106.045540Karol Lewandowski1-0/+5
This commit adds 'smackfsdef=*' to kdbusfs mount options. In kdbus system security checking is being handled in LSM layer on per-connection basis. This change does not affect non-kdbus systems. Change-Id: I85cd0d1aee3dc06a2b31ba45f6c55e1b6da64ddc Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
2015-10-29Merge "cg_get_root_path: Return default root path if it's not accessible due ↵Karol Lewandowski1-1/+7
to insufficient permission" into tizen
2015-10-28spec: Remove unnecessary BuildRequiressubmit/tizen/20151028.083249submit/tizen/20151028.020011accepted/tizen/wearable/20151028.094302accepted/tizen/tv/20151028.094252accepted/tizen/mobile/20151028.094237Sangjung Woo1-2/+0
In order to resolve the cycle build dependency, this removes unnecessary BuildRequires in spec file. Change-Id: I60e5bd573986be3febcf417109f79d13f607a732 Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-10-21cg_get_root_path: Return default root path if it's not accessible due to ↵Karol Lewandowski1-1/+7
insufficient permission This commit provides default value ("/") for root path in case where /proc/1/cgroup is not readable due to insufficient permission (eg. in MAC system). Inability to read root cgroup path leads to failure in determining instance type being used (system, user), eg. user@localhost:~$ /usr/lib/systemd/user-generators/systemd-dbus1-generator [13087.175648] audit: type=1400 audit(946701489.290:1463): lsm=SMACK fn=smack_inode_permission action=denied subject="User" object="System" requested=r pid=14081 comm="systemd-dbus1-g" name="cgroup" dev="proc" ino=11149 Failed to determine whether we are running as user or system instance: Permission denied strace: open("/proc/1/cgroup", O_RDONLY|O_LARGEFILE|O_CLOEXEC) = -1 EACCES (Permission denied) Change-Id: I60a17ad05b8b49cd1fb1c8aa3ad8f46d34231df3 Signed-off-by: Karol Lewandowski <k.lewandowsk@samsung.com>
2015-10-16units: add 'smackfsroot=*' option into tmp.mount when SMACK is enabledtizen_3.0.m2.a1_tv_releasetizen_3.0.m2.a1_mobile_releasesubmit/tizen/20151016.024343accepted/tizen/wearable/20151019.073928accepted/tizen/tv/20151019.073918accepted/tizen/mobile/20151019.073910Sangjung Woo2-2/+5
If SMACK is enabled, 'smackfsroot=*' option should be specified in tmp.mount file since many non-root processes use /tmp for temporary usage. If not, /tmp is labeled as '_' and smack denial occurs when writing. origin: https://github.com/systemd/systemd/commit/409c2a13fd65692c6 Change-Id: I11df1ad555f376eaf0588d35e91789c9e2b07f8d Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-10-16smack: label /etc/passwd and friends as '_' smack label when ↵Sangjung Woo1-12/+21
--with-smack-run-label' is enabled systemd-sysusers.service unit creates system users and groups and it could update /etc/passwd, /etc/group, /etc/shadow and /etc/gshadow. Those files should have '_' smack label because of accessibility. However, if systemd has its own smack label using '--with-smack-run-label' configuration, systemd-sysusers process spawned by systemd(pid:1) has its parent smack label and eventually updated files also is set as its parent smack label as below. --------------------------------------------------------------- sh-4.3# ls -alZ /etc/passwd -rw-r--r--. 1 root root System 2768 Dec 31 19:58 /etc/passwd --------------------------------------------------------------- This patch fixes that bug by labeling updated files as '_' smack label when --with-smack-run-label' is enabled. origin: https://github.com/systemd/systemd/commit/c02e7b1ecc7d88f65 Change-Id: I075b743d9364fe2724335a944912ddbc39b9ba83 Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-09-24exec: move mac_smack_apply_pid() and setup_pam() to same condition blockSangjung Woo1-17/+15
This cleans up exec_child() function by moving mac_smack_apply_pid() and setup_pam() to the same condition block, since both of them have the same condition (i.e params->apply_permissions). It improves readability without changing its operation. origin: https://github.com/systemd/systemd/commit/b213e1c1 Change-Id: I827f5f339910329e9cb492323002d4b9f0a247c1 Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-09-24exec: call setup_pam() after SMACK labelingSangjung Woo1-10/+10
When 'SmackProcessLabel=' is used in user@.service file, all processes launched in systemd user session should be labeled as the designated name of 'SmackProcessLabel' directive. However, if systemd has its own smack label using '--with-smack-run-label' configuration, '(sd-pam)' is labeled as the specific name of '--with-smack-run-label'. If 'SmackProcessLabel=' is used in user@.service file without '--with-smack-run-label' configuration, (sd-pam) is labeled as "_" since systemd (i.e. pid=1) is labeled as "_". This is mainly because setup_pam() function is called before applying smack label to child process. This patch fixes it by calling setup_pam() after setting the smack label. orgin: https://github.com/systemd/systemd/commit/6bf6e43e Change-Id: I71fd8cc87db5c3e59deed8bd305c39cb1fa741a8 Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-09-14smack: label /etc/mtab as "_" when '--with-smack-run-label' is enabled.submit/tizen_common/20151019.135620submit/tizen_common/20151015.190624submit/tizen_common/20151015.182633submit/tizen_common/20151015.181515submit/tizen/20150914.084623accepted/tizen/wearable/20150917.040309accepted/tizen/tv/20150917.040300accepted/tizen/mobile/20150917.040246Sangjung Woo2-1/+9
/etc/mtab should be labeled as "_", even though systemd has its own smack label using '--with-smack-run-label' configuration. This is mainly because all processes could read that file and the origin of this file (i.e. /proc/mounts) is labeled as "_". This labels /etc/mtab as "_" when '--with-smack-run-label' is enabled. Origin: https://github.com/systemd/systemd/commit/1fab0cb Change-Id: I098571444fe32ee67efea51e852610ff240b7a0a Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-09-08spec: disable systemd-randomseedtizen_3.0.m1_tv_releasetizen_3.0.m1_mobile_releasesubmit/tizen_common/20151026.085049submit/tizen_common/20151023.083358submit/tizen/20150908.055247accepted/tizen/wearable/20150908.231428accepted/tizen/tv/20150908.231437accepted/tizen/mobile/20150908.231421tizen_3.0.m1_tvtizen_3.0.m1_mobileSangjung Woo1-0/+7
When systemd-randomseed is enabled, random seed is generated in post script. However, the smack functionality of Tizen build system is not enabled so /var/lib/systemd directory is labeled as "_". Because of this reason, some daemons or tools such as loginctl which is labeled as "System" eventually failed to create some files in /var/lib/systemd. This patch resolves this issue by disabling systemd-randomseed since this functionality is not necessary for Tizen. Change-Id: Idd95dc97b84de400fbd7a6890bd6d78f8557c2fc Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-09-07spec: fix systemd-tmpfiles-setup.service failuresubmit/tizen/20150907.054259accepted/tizen/wearable/20150907.123535accepted/tizen/tv/20150907.123334accepted/tizen/mobile/20150907.123151Sangjung Woo1-2/+1
systemd-tmpfiles-setup.service is failed since /usr/share/factory/etc/nsswitch.conf is not installed. This patch fixes that bug by adding /usr/share/factory/etc/nsswitch.conf into systemd package. If /etc/nsswitch.conf already exists, /usr/share/factory/etc/nsswitch.conf file is not installed in /etc directory since etc.conf uses 'C' as the type of tmpfiles.d configuration so this patch does not make any error in network operation. Change-Id: I1c4ea8dcdaae002d5cfc3db4be53470c8d2169ca Signed-off-by: Sangjung Woo <sangjung.woo@samsung.com>
2015-09-02Temporarily disable Smack for POSIX shared memorysubmit/tizen/20150902.145139submit/tizen/20150902.144919accepted/tizen/wearable/20150903.000550accepted/tizen/tv/20150903.000312accepted/tizen/mobile/20150903.000114Rafal Krypa2-1/+10
Mount /dev/shm directory, used by glibc for implementation of POSIX shared memory segments, will now be mounted with System::Run label, transmutable. This effectively disables any access control by Smack on POSIX SHMs. Programs running with the same UID and GIDs, but different Smack labels (i.e. applications, user services) will be able to spy on each others SHM. This is a temporary workaround for problems with audio architecture not compliant with Tizen 3.0 security architecture. Applications using pulse audio try to exchange SHM segments. This patch is to be reverted in the near future. It is needed for now to have a working release. Change-Id: I82fa7b33ad415a5b57d6e2c3e8c6ea642c659ab7 Signed-off-by: Rafal Krypa <r.krypa@samsung.com>
2015-08-28Merge "sd-bus: fix encoding/decoding gvariant root container" into tizensubmit/tizen/20150902.123039Maciej Wereski1-7/+19
2015-08-28Merge "sd-bus: fix marshaling of unary type" into tizenMaciej Wereski3-11/+38
2015-08-28Merge "sd-bus: drop redundant code" into tizenMaciej Wereski1-6/+0
2015-08-28Merge "sd-bus: don't assert() on valid signatures" into tizenMaciej Wereski2-2/+7
2015-08-28Merge "sd-bus: fix gvariant structure encoding" into tizenMaciej Wereski2-2/+36
2015-08-28Merge "packaging: remove kdbus-kmod from Requires section" into tizenMaciej Wereski1-4/+0
2015-08-26sd-bus: fix encoding/decoding gvariant root containerDavid Herrmann1-7/+19
The gvariant root container contains a 'variant' at the end, which embeds the whole message body. This variant *must* contain a structure so we are compatible to dbus1. Otherwise, it could encode at most 1 type, instead of a full signature. Our gvariant message parser already parses the variant-content as a structure, so we're mostly good. However, it does *not* include the opening and closing parantheses, nor does it parse them. This patch fixes the decoder to verify a message contains the parantheses, and also make the encoder add those parantheses into the marshaled message. Change-Id: I351f482f7c8fd050cbbbe64dbc9028909172c305