Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
- These are internal helpers only, all refcount users need to use
fooFree() or similar for correct operation. Add fwd declarations
where necessary to avoid moving code around unnecessarily.
- We could add these back later as aliases to fooFree() but for now,
just get them out of the way.
|
|
|
|
- This mechanism has never been used by anything at all, which suggests
its not a particularly useful feature
- Removing unused rpmpsTrim() from rpmps
- Marking okProbs parameter of rpmtsRun() function as unused to avoid
unnecessary breakage
|
|
- Problems associated with a transaction element are necessarily unique
to that element, so when filtered there we don't have to worry about
skipping dupes elsewhere like in merged sets. This can actually lead
to apparent duplicates in the current problem report output (eg in cases
where multiple packages provide the same dependency which would be
removed, like multilib packages), but this is only an artifact of
they way the problems are currently printed out.
- While this is still a dumb linear search, it can be several seconds
faster than the previous filtering in rpmpsPrint(), which is now
just a dumb convenience function.
|
|
- This was only a convenience function that shouldn't really have been
exported to begin with, and is not necessary at all - bury it
inside rpmte.c for now to hide lazy problem set allocation
- In the other news of the day... According to git, this happens to be
the 10000th commit to the master branch of this codebase.
Happy anniversary to rpm :P
|
|
- rpmpsAppend() and rpmProblemCreate() have no use for fn/dn either,
its just stored in one string internally
- this is kinda unnecessary API break but these aren't used outside
rpm so it doesn't make much difference
|
|
|
|
- simply return the actual problem objects from the iterator instead
of "index" which is not usable for anything outside rpmps.c
- implement rpmpsNexIterator() on top of the new rpmpsiNext() as
backwards compatibility for now
|
|
- rpmps is just something that stores rpm problems, problems themselves
are individual and opaque "objects", deserving their own module
|
|
- turn around sameProblem() return, pay more attention to details
and make it public
- use it in rpmpsTrim() too
|
|
- this is an artifact from rpm 4.4.x-times, and even back then
nothing used it, the only api to set it was in python bindings and.. eww
- also killing this makes rpmpsTrim() do something semi-useful again
|
|
- avoid dumb pointer fiddles, ps->probs is just a bleeping array
|
|
- dont bother adding NULL problems
- avoid dumb pointer fiddles, ps->probs is just a bleeping array
|
|
|
|
|
|
- get the debug messages out of API, this is what should've been in commit
dbdbe8010cd944f026a5a4e5d071eb31d29d81c4
|
|
|
|
- also loose the related ancient compatibility goo
|
|
|
|
|
|
- remove ancient and likely irrelevant LCL comments and bogus NULL checks
|
|
- pretty much everything else in rpm returns NULL from unreference functions,
make be more consistent here...
- also tolerate NULL in both reference and unreference
|
|
|
|
- thanks to Pixel for spotting
|
|
|
|
|
|
- rename the parameters + internal use to more generic "number"
- rename ugly and dumb rpmProblemGetLong() to rpmProblemGetDiskNeed()
and return rpm_loff_t
- the number field is used for some other purposes too (whether dep problem
is for installed package), work around this for now by just defining
rpmProblemGetDiskNeed() result value as undefined on non-disk related
problems ;)
|
|
|
|
- we require C99 anyway
- snprintf is used unconditionally all around the tree
- if absolutely needed for portability, having insecure wrappers littered
over the source is not the best way
|
|
- replace with rpmtypes.h where needed
|
|
Just up the stupid static reservation "high enuff" for now.
asprintf() would be nice here but it's not at all portable, revisit later.
|
|
- its malloced so it needs to be freed
- fix all users to actually free
|
|
|
|
|
|
- adjust include paths accordingly
|
|
- add some helper macros to accomplish the same, easy to enable / disable
as needed
|
|
|
|
|
|
|
|
|
|
- problem set contains array of pointers to problems, not problems themselves
- add functions for creating and destroying problems
- use iterators for freeing the problems in rpmpsFree()
- new rpmpsAppendProblem() API for appending existing problem item to
problem set
- implement rpmpsAppend using the new methods
|
|
|
|
|
|
|
|
|
|
- leftover from pretrans syscall hack before %pretrans script days
|
|
|
|
CVS patchset: 7047
CVS date: 2003/12/30 13:14:49
|
|
- beecrypt: short hex string conversion overflows target buffer.
- mark "successors only" packages in transaction.
- reap scriptlets with SIGCHLD handler.
- rename PSM_t to rpmpsm, add methods and refcounts to manage.
- remove %%configure/%%makeinstall from arch-os/macros, default is OK.
- don't export MALLOC_CHECK_ to scriptlets.
- squeaky clean memory leak checking.
- always malloc rpmfi structure, refcounts are correct in rpmtsRun().
- skip redundant /sbin/ldconfig scripts on upgrade (if possible).
CVS patchset: 5645
CVS date: 2002/08/19 22:27:44
|