diff options
| author | Jindrich Novy <jnovy@redhat.com> | 2008-04-01 16:37:42 +0200 |
|---|---|---|
| committer | Jindrich Novy <jnovy@redhat.com> | 2008-04-01 16:40:15 +0200 |
| commit | 38b81493b044565271a277aa2c7a56408d3c8565 (patch) | |
| tree | 1c07600a2b671ffd09fdf6ef81575ff5b26f1cbe /rpmio | |
| parent | aabf8d59854c43f6bf1a11fee2b5100a0917b90c (diff) | |
| download | rpm-38b81493b044565271a277aa2c7a56408d3c8565.tar.gz rpm-38b81493b044565271a277aa2c7a56408d3c8565.tar.bz2 rpm-38b81493b044565271a277aa2c7a56408d3c8565.zip | |
Fix off-by one in urlOpen()
- the former implementation didn't take the ending '\0' into account
Diffstat (limited to 'rpmio')
| -rw-r--r-- | rpmio/rpmio.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/rpmio/rpmio.c b/rpmio/rpmio.c index 4e4de8162..39e0669af 100644 --- a/rpmio/rpmio.c +++ b/rpmio/rpmio.c @@ -783,8 +783,7 @@ static FD_t urlOpen(const char * url, int flags, mode_t mode) dest = rpmGenPath(NULL, "%{_tmppath}/", "rpm-transfer.XXXXXX"); close(mkstemp(dest)); - cmd = xmalloc(strlen(urlhelper) + strlen(dest) + strlen(url) + 3); - sprintf(cmd, "%s %s %s\n", urlhelper, dest, url); + rasprintf(&cmd, "%s %s %s\n", urlhelper, dest, url); urlhelper = _free(urlhelper); if ((pid = fork()) == 0) { |