From 73b77bc51213525bc47d2d73e516207614b950f0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9rgio=20Martins?= Date: Sat, 4 Jul 2015 10:15:15 +0100 Subject: Use by-ref in foreach when T is large or non-trivial Change-Id: I79271fdc3fa064e362dfaa64ff11d8a4c6b7e8c3 Reviewed-by: Simon Hausmann --- tools/qmlimportscanner/main.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tools') diff --git a/tools/qmlimportscanner/main.cpp b/tools/qmlimportscanner/main.cpp index beb47e43c..777ee1fdc 100644 --- a/tools/qmlimportscanner/main.cpp +++ b/tools/qmlimportscanner/main.cpp @@ -199,7 +199,7 @@ QVariantList findPathsForModuleImports(const QVariantList &imports) import[QStringLiteral("classname")] = classnames; if (plugininfo.contains(QStringLiteral("dependencies"))) { QStringList dependencies = plugininfo.value(QStringLiteral("dependencies")).toStringList(); - foreach (QString line, dependencies) { + foreach (const QString &line, dependencies) { QList dep = line.split(QStringLiteral(" ")); QVariantMap depImport; depImport[QStringLiteral("type")] = QStringLiteral("module"); -- cgit v1.2.3