summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Graf <agraf@suse.de>2012-07-10 20:40:55 +0200
committerhyokeun <hyokeun.jeon@samsung.com>2016-09-06 15:55:32 +0900
commit8f8f750a131b71d567bb5be15b2329b634408675 (patch)
tree853155253e105ea86b5d4d68ca187c26fdc36d1e
parent1336233c814d00a5f90b22e28058c3f848bbb985 (diff)
downloadqemu-8f8f750a131b71d567bb5be15b2329b634408675.tar.gz
qemu-8f8f750a131b71d567bb5be15b2329b634408675.tar.bz2
qemu-8f8f750a131b71d567bb5be15b2329b634408675.zip
linux-user: Run multi-threaded code on a single core
Running multi-threaded code can easily expose some of the fundamental breakages in QEMU's design. It's just not a well supported scenario. So if we pin the whole process to a single host CPU, we guarantee that we will never have concurrent memory access actually happen. We can still get scheduled away at any time, so it's no complete guarantee, but apparently it reduces the odds well enough to get my test cases to pass. This gets Java 1.7 working for me again on my test box. Signed-off-by: Alexander Graf <agraf@suse.de>
-rw-r--r--linux-user/syscall.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 8e69c151f..82195a2b0 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -6010,6 +6010,15 @@ static int do_fork(CPUArchState *env, unsigned int flags, abi_ulong newsp,
if (nptl_flags & CLONE_SETTLS)
cpu_set_tls (new_env, newtls);
+ /* agraf: Pin ourselves to a single CPU when running multi-threaded.
+ This turned out to improve stability for me. */
+ {
+ cpu_set_t mask;
+ CPU_ZERO(&mask);
+ CPU_SET(0, &mask);
+ sched_setaffinity(0, sizeof(mask), &mask);
+ }
+
/* Grab a mutex so that thread setup appears atomic. */
pthread_mutex_lock(&clone_lock);