diff options
| author | Alexander Graf <agraf@suse.de> | 2012-12-13 14:29:22 +0100 |
|---|---|---|
| committer | Yury Usishchev <y.usishchev@samsung.com> | 2014-12-10 14:51:42 +0300 |
| commit | a95b838171108bf540185913b01f4c2d123aa812 (patch) | |
| tree | bcb2c7273eb6e41c73a37aeef09ca50ffb2665f3 | |
| parent | 3180d55b5e2962b3c8f6f4f43050f25f0c719053 (diff) | |
| download | qemu-a95b838171108bf540185913b01f4c2d123aa812.tar.gz qemu-a95b838171108bf540185913b01f4c2d123aa812.tar.bz2 qemu-a95b838171108bf540185913b01f4c2d123aa812.zip | |
linux-user: lseek: explicitly cast non-set offsets to signed
When doing lseek, SEEK_SET indicates that the offset is an unsigned variable.
Other seek types have parameters that can be negative.
When converting from 32bit to 64bit parameters, we need to take this into
account and enable SEEK_END and SEEK_CUR to be negative, while SEEK_SET stays
absolute positioned which we need to maintain as unsigned.
Signed-off-by: Alexander Graf <agraf@suse.de>
| -rw-r--r-- | linux-user/syscall.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 02599cecb..a41dd43b5 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -5941,9 +5941,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_ulong arg1, case TARGET_NR_oldstat: goto unimplemented; #endif - case TARGET_NR_lseek: - ret = get_errno(lseek(arg1, arg2, arg3)); + case TARGET_NR_lseek: { + off_t off = arg2; + if (arg3 != SEEK_SET) { + off = (abi_long)arg2; + } + ret = get_errno(lseek(arg1, off, arg3)); break; + } #if defined(TARGET_NR_getxpid) && defined(TARGET_ALPHA) /* Alpha specific */ case TARGET_NR_getxpid: |