summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlexander Graf <agraf@suse.de>2012-07-10 20:40:55 +0200
committerJunfeng Dong <junfeng.dong@intel.com>2013-11-19 18:57:37 +0800
commit8c0bfdd62ef3cdf3f0b810659932c55c80da9537 (patch)
tree109df212f24fced385e29056aa62f61ddf01547e
parentc4721bdf400b21a4c2a356ad962e3cfba4a0133a (diff)
downloadqemu-8c0bfdd62ef3cdf3f0b810659932c55c80da9537.tar.gz
qemu-8c0bfdd62ef3cdf3f0b810659932c55c80da9537.tar.bz2
qemu-8c0bfdd62ef3cdf3f0b810659932c55c80da9537.zip
linux-user: Run multi-threaded code on a single core
Running multi-threaded code can easily expose some of the fundamental breakages in QEMU's design. It's just not a well supported scenario. So if we pin the whole process to a single host CPU, we guarantee that we will never have concurrent memory access actually happen. We can still get scheduled away at any time, so it's no complete guarantee, but apparently it reduces the odds well enough to get my test cases to pass. This gets Java 1.7 working for me again on my test box. Signed-off-by: Alexander Graf <agraf@suse.de>
-rw-r--r--linux-user/syscall.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 38ca7af2e..8aef3e89c 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -4326,6 +4326,15 @@ static int do_fork(CPUArchState *env, unsigned int flags, abi_ulong newsp,
if (nptl_flags & CLONE_SETTLS)
cpu_set_tls (new_env, newtls);
+ /* agraf: Pin ourselves to a single CPU when running multi-threaded.
+ This turned out to improve stability for me. */
+ {
+ cpu_set_t mask;
+ CPU_ZERO(&mask);
+ CPU_SET(0, &mask);
+ sched_setaffinity(0, sizeof(mask), &mask);
+ }
+
/* Grab a mutex so that thread setup appears atomic. */
pthread_mutex_lock(&clone_lock);