From 7b09bc72a55aba4614194ea2acd77bddd6490e70 Mon Sep 17 00:00:00 2001 From: Peter Goldsborough Date: Sat, 28 Apr 2018 01:51:16 +0100 Subject: [WIP] Enable WERROR in tests (#6539) * Enable WERROR in tests * Also set WERROR=1 for cpp_build in CI * Enable Werror after the compiler checks * Remove -DWERROR because its picked up from the env var * Had to fix some errors in aten/contrib/data * Allow an uninitialized variable in ReduceOpsKernel.cpp * Use CUDNN_DATA_UINT8 in cuDNN type string conversion * Fixes and use target_compile_options * Fix uninitialized variables in THNN * Include Python.h earlier in tensor_types.cpp * Use CUDNN_VERSION 7100 instead of 7000? * More Python.h includes * Make switch case in common_subexpression_elimination.cpp exhaustive * Build with WERROR=0 just to see all the warnings * Remove some Python includes * Enable WERROR=1 again * Bring back switch case default --- .jenkins/pytorch/build.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to '.jenkins') diff --git a/.jenkins/pytorch/build.sh b/.jenkins/pytorch/build.sh index 107b5df608..fd60d9bfca 100755 --- a/.jenkins/pytorch/build.sh +++ b/.jenkins/pytorch/build.sh @@ -27,7 +27,7 @@ if ! which conda; then pip install mkl mkl-devel fi -python setup.py install +WERROR=1 python setup.py install # Add the ATen test binaries so that they won't be git clean'ed away git add -f aten/build/src/ATen/test @@ -63,5 +63,5 @@ if [[ "$BUILD_TEST_LIBTORCH" == "1" ]]; then echo "Building libtorch with NO_PYTHON" # NB: Install outside of source directory (at the same level as the root # pytorch folder) so that it doesn't get cleaned away prior to docker push. - VERBOSE=1 tools/cpp_build/build_all.sh "$PWD/../cpp-build" + WERROR=1 VERBOSE=1 tools/cpp_build/build_all.sh "$PWD/../cpp-build" fi -- cgit v1.2.3