summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-02-03Remove --without-parallel (#16704)Pieter Noordhuis1-1/+1
Summary: See homebrew/homebrew-core@60c72ba9 and homebrew/homebrew-core#31510. Pull Request resolved: https://github.com/pytorch/pytorch/pull/16704 Differential Revision: D13938093 Pulled By: pietern fbshipit-source-id: 8a70d462180257f96202a0373a86a273b524045c
2019-02-03Bump gloo (#16638)Pieter Noordhuis1-0/+0
Summary: This bump includes: * Memory leak fix where the Gloo transport would hold on to auxiliary structures for send/recv pairs after they finished. * Fix write-after-free from Gloo thread during stack unwinding on error. * Removal of the PATENTS file. Fixes #16144. Pull Request resolved: https://github.com/pytorch/pytorch/pull/16638 Differential Revision: D13937950 Pulled By: pietern fbshipit-source-id: 3cfecaf13ee0f214c06681386557a4b1c3e1d6b9
2019-02-02Fix issue with scalars and __rpow__ (#16687)vishwakftw3-3/+15
Summary: Changelog: - Modify __rpow__ function in tensor.py to adapt to scalars Pull Request resolved: https://github.com/pytorch/pytorch/pull/16687 Differential Revision: D13936720 Pulled By: soumith fbshipit-source-id: b0c8727968b04efbc6e7461807c812d962f03370
2019-02-02Improve LeftRight (#16524)Sebastian Messmer2-56/+389
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16524 - Make it exception safe. When an exception happens during write, the old state is recovered. - Use RAII instead of try/catch to increment counters in readers. This is more readable, and it also makes it work with reader closures that return void, which previously didn't work because the reader return value was stored on the stack. - Assert there's no reads or writes happening when it's destructed to avoid destruction race conditions - Explain the algorithm in detail in comments - Add test cases Reviewed By: ezyang Differential Revision: D13866609 fbshipit-source-id: 01306a282a3f555569caa13d8041486f960d00e2
2019-02-02Updating submodulessvcscm1-0/+0
Reviewed By: zpao fbshipit-source-id: e66e01e164d1784740fcb8bebc4817d2a8cd7903
2019-02-02Updating submodulessvcscm1-0/+0
Reviewed By: zpao fbshipit-source-id: 31a8d843ffba2d7405b4742ea553937a00dff216
2019-02-02fix conditional in mean workaround (#16686)James Reed1-1/+1
Summary: When trying to get a test to pass I was missing an exclamation mark. Instead now I just use a different function in the conditional Pull Request resolved: https://github.com/pytorch/pytorch/pull/16686 Differential Revision: D13935182 Pulled By: jamesr66a fbshipit-source-id: 7525a1a829276641dbafe06734f03f6202df6b22
2019-02-01Use macro for reduce on 2d blocks (#16344)Xiaomeng Yang6-289/+183
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16344 Use macro for reduce on 2d blocks i-am-not-moving-c2-to-c10 Reviewed By: houseroad Differential Revision: D13808988 fbshipit-source-id: b68c0fb6079c1b6e203a072083aba7a95c202bc2
2019-02-01Simplify layer_norm_op_testSebastian Messmer1-24/+6
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16570 Reviewed By: ezyang Differential Revision: D13883913 fbshipit-source-id: 7437d3cbc00c0de92bb01562c620cb658aa9f0d3
2019-02-01Make predictor base classHao Lu1-5/+5
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16541 Reviewed By: ajtulloch Differential Revision: D13858261 fbshipit-source-id: acbfdbea59bd20ab1cc7956ee0d8856d6faa8361
2019-02-01Tag model_id and onnxifi index in OnnxifiOp (#16648)Yinghai Lu2-7/+27
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16648 We added onnxGraph sharing keyed on model id and net seq number but we forgot to supply these info to the Onnxifi. Therefore, we will only create ONE onnxGraph whatsoever... This diff adds necessary info to the OnnxifiOp to prevent this from happening. Reviewed By: bertmaher, rdzhabarov Differential Revision: D13912356 fbshipit-source-id: fe8982327287a35f32fe3b125d94b617d18c0ab5
2019-02-01Updating submodulessvcscm1-0/+0
Reviewed By: zpao fbshipit-source-id: ed389204bc423d2d5f7a36e2d61c0f55fe0522e1
2019-02-01Add @ignore annotation (#16055)David Riazati9-6/+124
Summary: Adds a decorator `torch.jit.ignore` for Python functions that tells the compiler to skip over these Python values, putting a `prim::Error` in their place which always throws an exception when run. This lets you have Python-only code in your model in an explicit way, which is useful for debugging, and still be able to save/load the model. Fixes #15815 Pull Request resolved: https://github.com/pytorch/pytorch/pull/16055 Differential Revision: D13797286 Pulled By: driazati fbshipit-source-id: 29d36776608ec101649a702952fc6ff3c27655b1
2019-02-01Add Winograd Conv method for CPU (#15196)Hui Wu4-9/+71
Summary: Add winograd conv method. Users can select the direct conv or winograd conv in the model file. We close the origin pr https://github.com/pytorch/pytorch/pull/12154 and create this new one for better rebasing. Pull Request resolved: https://github.com/pytorch/pytorch/pull/15196 Differential Revision: D13463721 Pulled By: yinghai fbshipit-source-id: c5cd5c8aa7622ae7e52aeabd3dbb8ffb99b9b4ee
2019-02-01Increase timeout on anaconda loginsJesse Hellemn1-5/+3
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16682 Differential Revision: D13931438 Pulled By: pjh5 fbshipit-source-id: 9961e91a80d8c59ab6347e830b1da38533524dd2
2019-02-01Tensor method rename ndim()->dim() - 3/3 (#16680)Jerry Zhang4-6/+6
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16680 Codemod generated with clangr shard mode, 25 files per diff, Reviewed By: houseroad Differential Revision: D13929471 fbshipit-source-id: b284ead11031f96fd8b6d96d2f29ffeb14207faa
2019-02-01fix the ONNX ci (#16674)Lu Fang7-62/+4
Summary: ~~Let's see whether this trigger and fix the problem~~ remove the expect files from test_verify Pull Request resolved: https://github.com/pytorch/pytorch/pull/16674 Reviewed By: zrphercule Differential Revision: D13930668 Pulled By: houseroad fbshipit-source-id: 092157af07f475cf3809c95a4fe586e050c53b7e
2019-02-01Allow USE_NINJA to be toggled by an env variableJesse Hellemn1-1/+1
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16665 Differential Revision: D13930021 Pulled By: pjh5 fbshipit-source-id: 4b490f952a56e8561329ab8898be2bf779b46b9d
2019-02-01fix tracing using a dictionary as input (#16616)Michael Suo2-1/+17
Summary: Previously this would fail with the error message: ``` ValueError: Auto nesting doesn't know how to process an input object of type dict. Accepted types: Tensors, or lists/tuples of them ``` Turns out we're not using the line that causes this error (or a side effect of that line), so removing it fixes the issue. Also cleaned up some related dead code (cc apaszke to make sure the code isn't useful in some way) Pull Request resolved: https://github.com/pytorch/pytorch/pull/16616 Differential Revision: D13908352 Pulled By: suo fbshipit-source-id: 27094f1f4ea0af215b901f7ed3520e94fbc587b3
2019-02-01Implement new c10 dispatcher (#16625)Sebastian Messmer82-1620/+1197
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16625 This is a squash of multiple PRs that refactored the old c10 dispatcher into a new one that follows the c10 dispatcher design doc. It is now unboxed and follows the Stack semantics from JIT. It also uses the runtime JIT schema instead of its own compile time schema definitions. Reviewed By: ezyang Differential Revision: D13907069 fbshipit-source-id: edcc4806ccd21474fdfb5a98516219b1956db13d
2019-02-01Add train() / eval() / is_training() to C++ ScriptModule API (#16044)Will Feng11-0/+87
Summary: This PR aims to fix https://discuss.pytorch.org/t/how-to-change-a-loaded-model-to-evaluation-mode-in-c/32330, by adding `train()` / `eval()` / `is_training()` to C++ ScriptModule API. Pull Request resolved: https://github.com/pytorch/pytorch/pull/16044 Differential Revision: D13857724 Pulled By: yf225 fbshipit-source-id: 16d3969fb5840ff7e66c7f72e800e6c75db8d2ff
2019-02-01Revert "Fixes selection of cuDNN algorithm (#15881)" (#16484)Syed Tousif Ahmed2-188/+143
Summary: There is a regression in cudnnGet*_v7 that causes slowdown in resnet50 training. I am opening a bug with cuDNN team about this. This reverts commit 38374468832e307ca741901870914857a836dd5d. ezyang :crying_cat_face: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16484 Differential Revision: D13924755 Pulled By: soumith fbshipit-source-id: 8c719345fc443f1289539bfae630eea9224ba4a5
2019-02-01Revert "Upgrade mkl-dnn to v0.17.3 to fix core dump issue (github#161… ↵Soumith Chintala1-0/+0
(#16660) Summary: …83) (#16653)" This reverts commit 87ae1558a6c8c7c0693bfa995458d16239c484d7. Pull Request resolved: https://github.com/pytorch/pytorch/pull/16660 Differential Revision: D13924272 Pulled By: soumith fbshipit-source-id: 79747d728adff1a9c32d8529846f0305052e57e8
2019-02-01Expose backend extensions to pythonRoy Li6-6/+155
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16582 Reviewed By: gchanan Differential Revision: D13887539 fbshipit-source-id: 8755babf2e3e849af974655f2f3a91740efe977e
2019-02-01Introduce backend extensions (overriding operators on custom backends)Roy Li17-13/+317
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/15153 Reviewed By: gchanan Differential Revision: D13445571 fbshipit-source-id: 62e2ebe0a6e81c4983b47cddb57ee5eb78e96708
2019-02-01Dispatch factory functions on Type (#15093)Roy Li1-25/+14
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/15093 Needed for backend extensions. Reviewed By: ezyang Differential Revision: D13427897 fbshipit-source-id: d0b34b0072e597ae599bd3bc25356831d7a18d6a
2019-02-01Only run Travis on master branch, not on export-DXXXXX branches. (#16628)Edward Yang1-0/+3
Summary: Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: https://github.com/pytorch/pytorch/pull/16628 Differential Revision: D13922097 Pulled By: ezyang fbshipit-source-id: eb16d90cc61167af5edc0c4e361d7a807a3099e5
2019-02-01Ignore assert_git_not_dirty for xla tests (#16611)Ailing Zhang2-1/+4
Summary: Testing, will restore the branch filter before landing. Pull Request resolved: https://github.com/pytorch/pytorch/pull/16611 Differential Revision: D13902234 Pulled By: ailzhang fbshipit-source-id: 7fa4048b891645f5253c48b905fb9630e3079524
2019-02-01Better bounds checks in ctcloss (#16269)Asher Mancinelli3-8/+40
Summary: Adds better bounds checks for target lengths in CTC loss, checks for integral types for target and prediction lengths, and adds tests for each, according to #15946 Pull Request resolved: https://github.com/pytorch/pytorch/pull/16269 Differential Revision: D13847567 Pulled By: ezyang fbshipit-source-id: 5d7a975565e02baf78fe388813a1d1ef56dfb212
2019-02-01Upgrade mkl-dnn to v0.17.3 to fix core dump issue (github#16183) (#16653)Gu, Jinghui1-0/+0
Summary: Upgrade mkl-dnn to 0.17.3 to fix core dump issue in #16183 Pull Request resolved: https://github.com/pytorch/pytorch/pull/16653 Differential Revision: D13918278 Pulled By: soumith fbshipit-source-id: b9c09c50ef188b4099966216e155c9f3f2542276
2019-02-01Skip dag_net_forking test on Rocm (#16639)peter.yeh@amd.com1-6/+9
Summary: -Skip the test due to flaky behavior on AMD/Rocm -The fix is expected in Rocm 2.2 ( HSA runtime) bddppq Pull Request resolved: https://github.com/pytorch/pytorch/pull/16639 Differential Revision: D13915231 Pulled By: bddppq fbshipit-source-id: 66e1d275836337170b15ceb9d60cfdd3242d4df8
2019-01-31add SingleLoadedNetSupplier (#16620)Amy Yang1-1/+22
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16620 LogfiledbNetLoader loads all external input blobs into a workspace instance, we pack a shared pointer to this loaded workspace into the SingleLoadedNetSupplier. SingleLoadedNetSupplier will pass this workspace to BlackBoxPredictor to be executed. (D13891759 is a WIP of how it all comes together) Reviewed By: pjh5 Differential Revision: D13901467 fbshipit-source-id: 20589f898922f5f1aec50be131dad17a8c38e9b2
2019-01-31Update conv_base to support empty batch (#16603)Xiaomeng Yang10-235/+308
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16603 Update conv_base to support empty batch Reviewed By: houseroad Differential Revision: D13894111 fbshipit-source-id: fc4370ff16ba6046f374e77bd845d28e6af05ea3
2019-01-31Improving docs for MultiLabelSoftMarginLoss (#16644)James Malcolm1-2/+2
Summary: Resolves #15863 Changed the documentation for MultiLabelSoftMarginLoss and MultiLabelMarginLoss to be more explicit about the `target` format. More than happy to change the messaging based on discussion. Pull Request resolved: https://github.com/pytorch/pytorch/pull/16644 Differential Revision: D13912395 Pulled By: soumith fbshipit-source-id: 24a3c214c5f6f9d043e25b13ac758c1c1211b641
2019-01-31respect MAX_JOBS (#16641)Zachary DeVito1-10/+9
Summary: We inadvertently switch the OSX build over to ninja on CI. It then fails to respect MAX_JOBS and hits the same scache deadlock bug, this makes the ninja build respect MAX_JOBS. Pull Request resolved: https://github.com/pytorch/pytorch/pull/16641 Differential Revision: D13910751 Pulled By: zdevito fbshipit-source-id: 61bec500539519b019b74421a13cd87fc1d86090
2019-01-31Workaround unvectorized mean implementation (#16618)James Reed1-0/+17
Summary: Workaround for https://github.com/pytorch/pytorch/issues/16617 Pull Request resolved: https://github.com/pytorch/pytorch/pull/16618 Differential Revision: D13904276 Pulled By: jamesr66a fbshipit-source-id: f8b5ea4c5f12dbc405123c9080c55b342c95bcd1
2019-01-31Updating submodulessvcscm1-0/+0
Reviewed By: zpao fbshipit-source-id: 4d94eb18d4da58541a96c9f9c2ecc9746f779933
2019-01-31Add compare_exchange_deleter to DataPtr/UniqueVoidPtr (#16513)Edward Yang2-0/+45
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16513 compare_exchange_deleter makes it easier to replace a deleter on a DataPtr with a new one, without requiring allocating another closure to hold the old deleter. See comment for details. This diff was originally landed as part of D13762540 (#16226) but we are reverting that diff D13863610 (#16510) Reviewed By: smessmer Differential Revision: D13864245 fbshipit-source-id: 56eda4748238dd3a5130ba6434fda463fe7c690e
2019-01-31Shim caffe2 GetRepeatedArgument helper for use with Ivalue (#16519)Bram Wasti1-3/+46
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16519 GetRepeatedArguments is needed for some ops Reviewed By: dzhulgakov Differential Revision: D13864293 fbshipit-source-id: a39255cd391c28acd75a6f0e81d558542417e032
2019-01-31Add torch.backends.openmp.is_available(); fix some cmake messages (#16425)SsnL11-38/+69
Summary: 1. add `torch.backends.openmp.is_available()` 2. Improve various `cmake` outputs 3. Fix LDFLAGS not respected by `caffe2_pybind11_state_*` targets 4. Fix `MKL` warning message, and QUIET flag. 5. Fix various typos Pull Request resolved: https://github.com/pytorch/pytorch/pull/16425 Differential Revision: D13903395 Pulled By: soumith fbshipit-source-id: d15c5d46f53e1ff1c27fca2887b9d23d0bd85b4d
2019-01-31Move outplace ops to ATen (#12413)Xiang Gao11-41/+156
Summary: So that things like below can be JITable, and available in C++ API: ```python import torch torch.jit.script def f(x, y, z): x.index_add(0, y, z) ``` Pull Request resolved: https://github.com/pytorch/pytorch/pull/12413 Differential Revision: D13899948 Pulled By: suo fbshipit-source-id: b0006b4bee2d1085c813733e1037e2dcde4ce626
2019-01-31Grant credentials to s3 html update jobJesse Hellemn1-1/+2
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16631 Differential Revision: D13908331 Pulled By: pjh5 fbshipit-source-id: 846a4f933d947f7217b856bd79ff85b7f97288a8
2019-01-31fix scope related naming issue in build_quant_conv_bn_relu, and also format ↵Jerry Zhang1-0/+3
function signature Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/14885 Reviewed By: harouwu Differential Revision: D13374077 fbshipit-source-id: 5082c4ea0d2fdc197243b022b9b489f38b04c8e9
2019-01-31Disable layernorm_c10 test for now (#16630)Dmytro Dzhulgakov1-0/+1
Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16630 two PRs landed concurrently - enforcing tensor constraints and refactoring c10. Since it's not a prod code - disable test and I'll let Sebastian to fix it properly. Reviewed By: ezyang Differential Revision: D13908117 fbshipit-source-id: 381c5626078b794afa1fc7a95cb1ea529650424c
2019-01-31Remove constant propagation expect files (#16348)Elias Ellison8-138/+91
Summary: Remove constant prop expect files, and express graph conditions via python bindings. First diff in larger effort to remove expect files Pull Request resolved: https://github.com/pytorch/pytorch/pull/16348 Differential Revision: D13906929 Pulled By: eellison fbshipit-source-id: 7963caa3ccbc7bfc0006a160c952aa173d1ce633
2019-01-31Fix a lot of C++ build warnings (#16411)James Reed19-64/+21
Summary: I went through my build log and did what I thought were reasonable fixes to all the C++ compilation warnings that came up Pull Request resolved: https://github.com/pytorch/pytorch/pull/16411 Differential Revision: D13901006 Pulled By: jamesr66a fbshipit-source-id: 02df4e3e5a5c8dd9e69ac9f065cd3f2a80645033
2019-01-31Add immutable dict support (#16208)David Riazati18-7/+454
Summary: This PR adds basic support (creation and indexing) for immutable dictionaries in Script. This includes Python/string frontend support and a `IValue::GenericDict` type backed by a `std::unordered_map`. Only `str`, `int`, and `float` are supported as keys, any type can be a value. Structure is pretty similar to list. Pull Request resolved: https://github.com/pytorch/pytorch/pull/16208 Differential Revision: D13881686 Pulled By: driazati fbshipit-source-id: 29ce9835b953c3456f57bcc2bbdf7fe0cbf941c0
2019-01-31Make the miopen handle part of ConvolutionParams (#16613)Jithun Nair1-4/+6
Summary: so that it's included in the hashed key that decides whether to call Find or not. This is required to ensure that Find is run for all devices Pull Request resolved: https://github.com/pytorch/pytorch/pull/16613 Differential Revision: D13901769 Pulled By: bddppq fbshipit-source-id: 7d29ea9e40231cd4eef80847afa1307efeb0945c
2019-01-31Back out "Revert D13596031: Improve c2-aten tensor interop and add proper ↵Dmytro Dzhulgakov12-70/+448
testing" (#16514) Summary: Pull Request resolved: https://github.com/pytorch/pytorch/pull/16514 Original commit changeset: dc371697f14b Relanding https://github.com/pytorch/pytorch/pull/15860 - the problem was that layer_norm was using at::empty which is not yet on mobile Reviewed By: ezyang Differential Revision: D13861480 fbshipit-source-id: e2116da32bc117175c96b9151b1beba9b31eff36
2019-01-31use distutils to discover msvc compiler paths (#16540)Zachary DeVito2-25/+37
Summary: This simplifies the process for building on windows, since users no longer have to find and run the vcvarsall.bat file. Pull Request resolved: https://github.com/pytorch/pytorch/pull/16540 Differential Revision: D13893596 Pulled By: zdevito fbshipit-source-id: 79b7ad55c3251b3f573fd8464931138f8a52dd1d