diff options
| author | Edward Yang <ezyang@fb.com> | 2018-11-14 07:25:52 -0800 |
|---|---|---|
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | 2018-11-14 07:39:37 -0800 |
| commit | fbabe5bf62b6045d457d52d9aa18dc374f5c9c2d (patch) | |
| tree | fde8a4abafa8005565ea8f199e65db52e47daf4c /c10/macros | |
| parent | db5aeafa6074e480a3ebd312963a7cc876d5a129 (diff) | |
| download | pytorch-fbabe5bf62b6045d457d52d9aa18dc374f5c9c2d.tar.gz pytorch-fbabe5bf62b6045d457d52d9aa18dc374f5c9c2d.tar.bz2 pytorch-fbabe5bf62b6045d457d52d9aa18dc374f5c9c2d.zip | |
Rename c10::detail to c10::impl (#13838)
Summary:
Pull Request resolved: https://github.com/pytorch/pytorch/pull/13838
According to Sebastian, the detail convention is specifically for header-private
functionality. That's not what c10/detail is; it's general, library private headers
which may be used in multiple places within PyTorch. Rename it to impl to avoid
the confusion in nomenclature.
Reviewed By: smessmer
Differential Revision: D13024368
fbshipit-source-id: 050f2632d83a69e3ae53ded88e8f938c5d61f0ef
Diffstat (limited to 'c10/macros')
| -rw-r--r-- | c10/macros/Macros.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/c10/macros/Macros.h b/c10/macros/Macros.h index 0138a9cb79..2dcf0062da 100644 --- a/c10/macros/Macros.h +++ b/c10/macros/Macros.h @@ -53,7 +53,6 @@ // Simply define the namespace, in case a dependent library want to refer to // the c10 namespace but not any nontrivial files. namespace c10 {} // namespace c10 -namespace c10 { namespace detail {} } // Since C10 is the core library for caffe2 (and aten), we will simply reroute // all abstractions defined in c10 to be available in caffe2 as well. @@ -61,7 +60,6 @@ namespace c10 { namespace detail {} } // c10 namespace where possible. namespace caffe2 {using namespace c10;} namespace at {using namespace c10;} -namespace at { namespace detail { using namespace c10::detail; }} // C10_NORETURN #if defined(_MSC_VER) |