diff options
| author | Yangqing Jia <jiayq84@gmail.com> | 2018-10-15 13:28:08 -0700 |
|---|---|---|
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | 2018-10-15 13:33:18 -0700 |
| commit | 713e706618e55ab7ce531c5749f0fc588352aeed (patch) | |
| tree | 384dc76c3ef6682b4e27123ba6994f69b533dbb8 /CONTRIBUTING.md | |
| parent | aef8cadb9a6fcb27473f0af14cba8a6beb014a38 (diff) | |
| download | pytorch-713e706618e55ab7ce531c5749f0fc588352aeed.tar.gz pytorch-713e706618e55ab7ce531c5749f0fc588352aeed.tar.bz2 pytorch-713e706618e55ab7ce531c5749f0fc588352aeed.zip | |
Move exception to C10 (#12354)
Summary:
There are still a few work to be done:
- Move logging and unify AT_WARN with LOG(ERROR).
- A few header files are still being plumbed through, need cleaning.
- caffe2::EnforceNotMet aliasing is not done yet.
- need to unify the macros. See c10/util/Exception.h
This is mainly a codemod and not causing functional changes. If you find your job failing and trace back to this diff, usually it can be fixed by the following approaches:
(1) add //caffe2/c10:c10 to your dependency (or transitive dependency).
(2) change objects such as at::Error, at::Optional to the c10 namespace.
(3) change functions to the c10 namespace. Especially, caffe2::MakeString is not overridden by the unified c10::str function. Nothing else changes.
Please kindly consider not reverting this diff - it involves multiple rounds of rebasing and the fix is usually simple. Contact jiayq@ or AI Platform Dev for details.
Pull Request resolved: https://github.com/pytorch/pytorch/pull/12354
Reviewed By: orionr
Differential Revision: D10238910
Pulled By: Yangqing
fbshipit-source-id: 7794d5bf2797ab0ca6ebaccaa2f7ebbd50ff8f32
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 57800d887f..61025e2b0b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -325,7 +325,7 @@ Here are a few well known pitfalls and workarounds: catch all of these problems: stay vigilant to the possibility that your crash is due to a real memory problem. -* (NVCC) `at::optional` does not work when used from device code. Don't use +* (NVCC) `c10::optional` does not work when used from device code. Don't use it from kernels. Upstream issue: https://github.com/akrzemi1/Optional/issues/58 and our local issue #10329. |