diff options
| author | Peter Goldsborough <psag@fb.com> | 2018-10-10 07:21:57 -0700 |
|---|---|---|
| committer | Facebook Github Bot <facebook-github-bot@users.noreply.github.com> | 2018-10-10 07:23:57 -0700 |
| commit | 033e95765c19e208a0ac04376ae7cacb62940e9a (patch) | |
| tree | 096bd2022c84c214fd1a1cb2d4632163686a2718 /.clang-tidy | |
| parent | 727609f435582f70a57775f04694f619ff8add80 (diff) | |
| download | pytorch-033e95765c19e208a0ac04376ae7cacb62940e9a.tar.gz pytorch-033e95765c19e208a0ac04376ae7cacb62940e9a.tar.bz2 pytorch-033e95765c19e208a0ac04376ae7cacb62940e9a.zip | |
Diff against master and enable bugprone-* checks (#12378)
Summary:
This PR:
1. Makes clang-tidy diff against `master` instead of `HEAD~1` in CI, which makes much more sense
2. Enables all checks in the `bugprone-*` category (see https://clang.llvm.org/extra/clang-tidy/checks/list.html) except one about parantheses in macros, because it doesn't always apply too well for us.
Fixed some nice code smells.
ezyang
Pull Request resolved: https://github.com/pytorch/pytorch/pull/12378
Differential Revision: D10247972
Pulled By: goldsborough
fbshipit-source-id: 97dc9e262effa6874d2854584bf41a86684eb8bd
Diffstat (limited to '.clang-tidy')
| -rw-r--r-- | .clang-tidy | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/.clang-tidy b/.clang-tidy index 3513ae8dbb..d72484f359 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -3,6 +3,8 @@ Checks: ' -* ,modernize-deprecated-headers + ,bugprone-* + ,-bugprone-macro-parentheses ' WarningsAsErrors: '*' HeaderFilterRegex: 'torch/csrc/.*' |